From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] fs-test: Add test for a filename using '..' to go back to the root
Date: Sun, 24 Sep 2017 17:38:43 -0400 [thread overview]
Message-ID: <20170924213843.GC29028@bill-the-cat> (raw)
In-Reply-To: <20170924210736.13335-3-tuomas.tynkkynen@iki.fi>
On Mon, Sep 25, 2017 at 12:07:36AM +0300, Tuomas Tynkkynen wrote:
> The previous commit fixed a problem in FAT code where going back to the
> root directory using '..' wouldn't work correctly on FAT12 or FAT16.
> Add a test to exercise this case (which was once fixed in commit
> 18a10d46f26 "fat: handle paths that include ../" but reintroduced due to
> the directory iterator refactoring).
>
> This test only very barely catches the problem - without the fix the
> size command still gives valid output but the additional spurious
> "Invalid FAT entry" error message makes it not get caught in the
> 'egrep -A3 ' output. I tried to make a proper test that grows the root
> directory to two clusters lots of with dummy files but that causes the
> write tests to crash the sandbox totally...
Can you post, unrelated, the code that totally crashed sandbox? Maybe
that's a problem we need to fix too :)
Otherwise fine, but we need to update the expected results.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170924/cb08bbbc/attachment.sig>
next prev parent reply other threads:[~2017-09-24 21:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 21:07 [U-Boot] [PATCH 1/3] fs-test: Add FAT16 support Tuomas Tynkkynen
2017-09-24 21:07 ` [U-Boot] [PATCH 2/3] fs/fat: Fix pathnames using '..' that lead to the root directory Tuomas Tynkkynen
2017-09-24 21:36 ` Tom Rini
2017-09-24 21:07 ` [U-Boot] [PATCH 3/3] fs-test: Add test for a filename using '..' to go back to the root Tuomas Tynkkynen
2017-09-24 21:38 ` Tom Rini [this message]
2017-09-24 21:53 ` Rob Clark
2017-09-24 22:35 ` Tuomas Tynkkynen
2017-09-24 21:36 ` [U-Boot] [PATCH 1/3] fs-test: Add FAT16 support Tom Rini
2017-09-24 21:48 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170924213843.GC29028@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.