From: Kalle Valo <kvalo@codeaurora.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: b43: make const arrays static, reduces object code size
Date: Mon, 25 Sep 2017 08:30:44 +0000 [thread overview]
Message-ID: <20170925083044.D348A6025D@smtp.codeaurora.org> (raw)
In-Reply-To: <20170922153902.15372-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const arrays on the stack, instead make them static.
> Makes the object code smaller by over 60 bytes:
>
> Before:
> text data bss dec hex filename
> 14816 1296 0 16112 3ef0 b43/phy_ht.o
>
> After:
> text data bss dec hex filename
> 14551 1496 0 16047 3eaf b43/phy_ht.o
>
> (gcc 6.3.0, x86-64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
96cbe3d638e4 b43: make const arrays static, reduces object code size
--
https://patchwork.kernel.org/patch/9966415/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: b43: make const arrays static, reduces object code size
Date: Mon, 25 Sep 2017 08:30:44 +0000 (UTC) [thread overview]
Message-ID: <20170925083044.D348A6025D@smtp.codeaurora.org> (raw)
In-Reply-To: <20170922153902.15372-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const arrays on the stack, instead make them static.
> Makes the object code smaller by over 60 bytes:
>
> Before:
> text data bss dec hex filename
> 14816 1296 0 16112 3ef0 b43/phy_ht.o
>
> After:
> text data bss dec hex filename
> 14551 1496 0 16047 3eaf b43/phy_ht.o
>
> (gcc 6.3.0, x86-64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
96cbe3d638e4 b43: make const arrays static, reduces object code size
--
https://patchwork.kernel.org/patch/9966415/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-09-25 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 15:39 [PATCH] b43: make const arrays static, reduces object code size Colin King
2017-09-22 15:39 ` Colin King
2017-09-25 8:30 ` Kalle Valo [this message]
2017-09-25 8:30 ` Kalle Valo
2017-09-25 8:30 ` Kalle Valo
2017-09-25 8:30 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925083044.D348A6025D@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=b43-dev@lists.infradead.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.