From: Vinod Koul <vinod.koul@intel.com>
To: Ravi Shankar Jonnalagadda <venkata.ravi.jonnalagadda@xilinx.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
lorenzo.pieralisi@arm.com, dmaengine@vger.kernel.org,
bharat.kumar.gogada@xilinx.com, linux-pci@vger.kernel.org,
michal.simek@xilinx.com, linux-kernel@vger.kernel.org,
vjonnal@xilinx.com, robh+dt@kernel.org, rgummal@xilinx.com,
linux-arm-kernel@lists.infradead.org, bhelgaas@google.com,
dan.j.williams@intel.com, soren.brinkmann@xilinx.com
Subject: Re: [PATCH v2 4/5] dmaengine: zynqmp_ps_pcie: Adding PS PCIe platform DMA driver
Date: Tue, 26 Sep 2017 23:04:35 +0530 [thread overview]
Message-ID: <20170926173435.GS30097@localhost> (raw)
In-Reply-To: <1504873388-29195-6-git-send-email-vjonnal@xilinx.com>
On Fri, Sep 08, 2017 at 05:53:07PM +0530, Ravi Shankar Jonnalagadda wrote:
> Platform driver handles transactions for PCIe EP DMA and Root DMA
>
> Signed-off-by: Ravi Shankar Jonnalagadda <vjonnal@xilinx.com>
> Signed-off-by: RaviKiran Gummaluri <rgummal@xilinx.com>
> ---
> drivers/dma/xilinx/ps_pcie_platform.c | 3055 +++++++++++++++++++++++++++++++++
I dont want to loose my sanity trying to review a 3k patch. If you don't put
an effort to make your code easier to review, I dont want to see this...
Nacked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/5] dmaengine: zynqmp_ps_pcie: Adding PS PCIe platform DMA driver
Date: Tue, 26 Sep 2017 23:04:35 +0530 [thread overview]
Message-ID: <20170926173435.GS30097@localhost> (raw)
In-Reply-To: <1504873388-29195-6-git-send-email-vjonnal@xilinx.com>
On Fri, Sep 08, 2017 at 05:53:07PM +0530, Ravi Shankar Jonnalagadda wrote:
> Platform driver handles transactions for PCIe EP DMA and Root DMA
>
> Signed-off-by: Ravi Shankar Jonnalagadda <vjonnal@xilinx.com>
> Signed-off-by: RaviKiran Gummaluri <rgummal@xilinx.com>
> ---
> drivers/dma/xilinx/ps_pcie_platform.c | 3055 +++++++++++++++++++++++++++++++++
I dont want to loose my sanity trying to review a 3k patch. If you don't put
an effort to make your code easier to review, I dont want to see this...
Nacked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Ravi Shankar Jonnalagadda
<venkata.ravi.jonnalagadda-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
vjonnal-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org,
bharat.kumar.gogada-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
rgummal-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v2 4/5] dmaengine: zynqmp_ps_pcie: Adding PS PCIe platform DMA driver
Date: Tue, 26 Sep 2017 23:04:35 +0530 [thread overview]
Message-ID: <20170926173435.GS30097@localhost> (raw)
In-Reply-To: <1504873388-29195-6-git-send-email-vjonnal-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
On Fri, Sep 08, 2017 at 05:53:07PM +0530, Ravi Shankar Jonnalagadda wrote:
> Platform driver handles transactions for PCIe EP DMA and Root DMA
>
> Signed-off-by: Ravi Shankar Jonnalagadda <vjonnal-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: RaviKiran Gummaluri <rgummal-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/dma/xilinx/ps_pcie_platform.c | 3055 +++++++++++++++++++++++++++++++++
I dont want to loose my sanity trying to review a 3k patch. If you don't put
an effort to make your code easier to review, I dont want to see this...
Nacked-by: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Ravi Shankar Jonnalagadda <venkata.ravi.jonnalagadda@xilinx.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
dan.j.williams@intel.com, bhelgaas@google.com,
vjonnal@xilinx.com, lorenzo.pieralisi@arm.com,
bharat.kumar.gogada@xilinx.com, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
rgummal@xilinx.com
Subject: Re: [PATCH v2 4/5] dmaengine: zynqmp_ps_pcie: Adding PS PCIe platform DMA driver
Date: Tue, 26 Sep 2017 23:04:35 +0530 [thread overview]
Message-ID: <20170926173435.GS30097@localhost> (raw)
In-Reply-To: <1504873388-29195-6-git-send-email-vjonnal@xilinx.com>
On Fri, Sep 08, 2017 at 05:53:07PM +0530, Ravi Shankar Jonnalagadda wrote:
> Platform driver handles transactions for PCIe EP DMA and Root DMA
>
> Signed-off-by: Ravi Shankar Jonnalagadda <vjonnal@xilinx.com>
> Signed-off-by: RaviKiran Gummaluri <rgummal@xilinx.com>
> ---
> drivers/dma/xilinx/ps_pcie_platform.c | 3055 +++++++++++++++++++++++++++++++++
I dont want to loose my sanity trying to review a 3k patch. If you don't put
an effort to make your code easier to review, I dont want to see this...
Nacked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
next prev parent reply other threads:[~2017-09-26 17:34 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 12:23 [PATCH v2 0/5] dmaengine: ZynqMP PS PCIe DMA driver Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` [PATCH v2 1/5] PCI:xilinx-nwl: Enable Root DMA Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-19 19:36 ` Bjorn Helgaas
2017-09-19 19:36 ` Bjorn Helgaas
2017-09-19 19:36 ` Bjorn Helgaas
2017-09-08 12:23 ` [PATCH v2 2/5] PCI:xilinx-nwl: Correcting Styling checks Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` [PATCH v2 3/5] dmaengine: zynqmp_ps_pcie: Adding PS PCIe DMA driver Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-11 3:43 ` kbuild test robot
2017-09-11 3:43 ` kbuild test robot
2017-09-11 3:43 ` kbuild test robot
2017-09-11 3:43 ` kbuild test robot
2017-09-20 5:49 ` Michal Simek
2017-09-20 5:49 ` Michal Simek
2017-09-20 5:49 ` Michal Simek
2017-09-26 17:32 ` Vinod Koul
2017-09-26 17:32 ` Vinod Koul
2017-09-26 17:32 ` Vinod Koul
2017-09-08 12:23 ` [PATCH v2 4/5] dmaengine: zynqmp_ps_pcie: Adding PS PCIe platform " Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-26 17:34 ` Vinod Koul [this message]
2017-09-26 17:34 ` Vinod Koul
2017-09-26 17:34 ` Vinod Koul
2017-09-26 17:34 ` Vinod Koul
2017-09-08 12:23 ` [PATCH v2 5/5] devicetree: zynqmp_ps_pcie: Devicetree binding for Root DMA Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-08 12:23 ` Ravi Shankar Jonnalagadda
2017-09-13 20:25 ` Rob Herring
2017-09-13 20:25 ` Rob Herring
2017-09-13 20:25 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926173435.GS30097@localhost \
--to=vinod.koul@intel.com \
--cc=bharat.kumar.gogada@xilinx.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=rgummal@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=soren.brinkmann@xilinx.com \
--cc=venkata.ravi.jonnalagadda@xilinx.com \
--cc=vjonnal@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.