All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Arvind Yadav <arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iommu/amd: pr_err() strings should end with newlines
Date: Wed, 27 Sep 2017 17:02:11 +0200	[thread overview]
Message-ID: <20170927150211.e6vr2tpwxr5iautm@8bytes.org> (raw)
In-Reply-To: <a981b82525849ccf4fa869c74c0358f350a9998d.1506411289.git.arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Tue, Sep 26, 2017 at 01:07:46PM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated. So replace '/n' with '\n'.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  drivers/iommu/amd_iommu_init.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Thanks, I completly missed that in the review. Applied the patch to
iommu/fixes.

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/amd: pr_err() strings should end with newlines
Date: Wed, 27 Sep 2017 17:02:11 +0200	[thread overview]
Message-ID: <20170927150211.e6vr2tpwxr5iautm@8bytes.org> (raw)
In-Reply-To: <a981b82525849ccf4fa869c74c0358f350a9998d.1506411289.git.arvind.yadav.cs@gmail.com>

On Tue, Sep 26, 2017 at 01:07:46PM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated. So replace '/n' with '\n'.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/iommu/amd_iommu_init.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Thanks, I completly missed that in the review. Applied the patch to
iommu/fixes.

  parent reply	other threads:[~2017-09-27 15:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-26  7:37 [PATCH] iommu/amd: pr_err() strings should end with newlines Arvind Yadav
2017-09-26  7:37 ` Arvind Yadav
     [not found] ` <a981b82525849ccf4fa869c74c0358f350a9998d.1506411289.git.arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-09-27 15:02   ` Joerg Roedel [this message]
2017-09-27 15:02     ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170927150211.e6vr2tpwxr5iautm@8bytes.org \
    --to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
    --cc=arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.