From: Jonathan.Cameron@huawei.com (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 6/7] perf: cavium: Support transmit-link PMU counters
Date: Wed, 27 Sep 2017 16:48:46 +0100 [thread overview]
Message-ID: <20170927164846.00001cbe@huawei.com> (raw)
In-Reply-To: <20170925123502.17289-7-jglauber@cavium.com>
On Mon, 25 Sep 2017 14:35:01 +0200
Jan Glauber <jglauber@cavium.com> wrote:
> Add support for the transmit-link (OCX TLK) PMU counters found
> on Caviums SOCs with a processor interconnect.
>
> Properties of the OCX TLK counters:
> - per-unit control
> - fixed purpose
> - writable
> - one PCI device with multiple TLK units
>
> Signed-off-by: Jan Glauber <jglauber@cavium.com>
Something odd happened in
drivers/soc/cavium/Kconfig...
Otherwise whole series looks sensible to me.
Jonathan
> ---
> drivers/perf/Kconfig | 7 ++
> drivers/perf/cavium_pmu.c | 230 ++++++++++++++++++++++++++++++++++++++++
> drivers/soc/cavium/Kconfig | 4 +
> drivers/soc/cavium/cavium_ocx.c | 4 +
> include/linux/soc/cavium/ocx.h | 3 +
> 5 files changed, 248 insertions(+)
>
<snip>
> static int __init cvm_pmu_init(void)
> {
> INIT_LIST_HEAD(&cvm_pmu_lmcs);
> diff --git a/drivers/soc/cavium/Kconfig b/drivers/soc/cavium/Kconfig
> index fe56503d20f4..2c7406872b18 100644
> --- a/drivers/soc/cavium/Kconfig
> +++ b/drivers/soc/cavium/Kconfig
> @@ -8,3 +8,7 @@ config CAVIUM_LMC
> config CAVIUM_OCX
> depends on ARCH_THUNDER
> def_tristate m
> +
> +config CAVIUM_OCX
> + depends on ARCH_THUNDER
> + def_tristate m
Something odd going on here...
> diff --git a/drivers/soc/cavium/cavium_ocx.c b/drivers/soc/cavium/cavium_ocx.c
> index fa3341b0744f..de1ad146c0dd 100644
> --- a/drivers/soc/cavium/cavium_ocx.c
> +++ b/drivers/soc/cavium/cavium_ocx.c
> @@ -13,6 +13,8 @@
> static int cvm_ocx_probe(struct pci_dev *pdev,
> const struct pci_device_id *ent)
> {
> + if (IS_ENABLED(CONFIG_CAVIUM_PMU_OCX_TLK))
> + cvm_ocx_tlk_pmu_probe(pdev, ent);
> if (IS_ENABLED(CONFIG_EDAC_THUNDERX))
> thunderx_edac_ocx_probe(pdev, ent);
> return 0;
> @@ -20,6 +22,8 @@ static int cvm_ocx_probe(struct pci_dev *pdev,
>
> static void cvm_ocx_remove(struct pci_dev *pdev)
> {
> + if (IS_ENABLED(CONFIG_CAVIUM_PMU_OCX_TLK))
> + cvm_ocx_tlk_pmu_remove(pdev);
> if (IS_ENABLED(CONFIG_EDAC_THUNDERX))
> thunderx_edac_ocx_remove(pdev);
> }
> diff --git a/include/linux/soc/cavium/ocx.h b/include/linux/soc/cavium/ocx.h
> index 29f55b3d3171..f7b2caada671 100644
> --- a/include/linux/soc/cavium/ocx.h
> +++ b/include/linux/soc/cavium/ocx.h
> @@ -3,6 +3,9 @@
>
> #include <linux/pci.h>
>
> +int cvm_ocx_tlk_pmu_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
> +void cvm_ocx_tlk_pmu_remove(struct pci_dev *pdev);
> +
> int thunderx_edac_ocx_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
> void thunderx_edac_ocx_remove(struct pci_dev *pdev);
>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Jan Glauber <jglauber@cavium.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will.deacon@arm.com>,
David Daney <david.daney@cavium.com>,
Suzuki K Poulose <Suzuki.Poulose@arm.com>,
<linux-kernel@vger.kernel.org>,
Zhangshaokun <zhangshaokun@hisilicon.com>,
Borislav Petkov <bp@alien8.de>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v10 6/7] perf: cavium: Support transmit-link PMU counters
Date: Wed, 27 Sep 2017 16:48:46 +0100 [thread overview]
Message-ID: <20170927164846.00001cbe@huawei.com> (raw)
In-Reply-To: <20170925123502.17289-7-jglauber@cavium.com>
On Mon, 25 Sep 2017 14:35:01 +0200
Jan Glauber <jglauber@cavium.com> wrote:
> Add support for the transmit-link (OCX TLK) PMU counters found
> on Caviums SOCs with a processor interconnect.
>
> Properties of the OCX TLK counters:
> - per-unit control
> - fixed purpose
> - writable
> - one PCI device with multiple TLK units
>
> Signed-off-by: Jan Glauber <jglauber@cavium.com>
Something odd happened in
drivers/soc/cavium/Kconfig...
Otherwise whole series looks sensible to me.
Jonathan
> ---
> drivers/perf/Kconfig | 7 ++
> drivers/perf/cavium_pmu.c | 230 ++++++++++++++++++++++++++++++++++++++++
> drivers/soc/cavium/Kconfig | 4 +
> drivers/soc/cavium/cavium_ocx.c | 4 +
> include/linux/soc/cavium/ocx.h | 3 +
> 5 files changed, 248 insertions(+)
>
<snip>
> static int __init cvm_pmu_init(void)
> {
> INIT_LIST_HEAD(&cvm_pmu_lmcs);
> diff --git a/drivers/soc/cavium/Kconfig b/drivers/soc/cavium/Kconfig
> index fe56503d20f4..2c7406872b18 100644
> --- a/drivers/soc/cavium/Kconfig
> +++ b/drivers/soc/cavium/Kconfig
> @@ -8,3 +8,7 @@ config CAVIUM_LMC
> config CAVIUM_OCX
> depends on ARCH_THUNDER
> def_tristate m
> +
> +config CAVIUM_OCX
> + depends on ARCH_THUNDER
> + def_tristate m
Something odd going on here...
> diff --git a/drivers/soc/cavium/cavium_ocx.c b/drivers/soc/cavium/cavium_ocx.c
> index fa3341b0744f..de1ad146c0dd 100644
> --- a/drivers/soc/cavium/cavium_ocx.c
> +++ b/drivers/soc/cavium/cavium_ocx.c
> @@ -13,6 +13,8 @@
> static int cvm_ocx_probe(struct pci_dev *pdev,
> const struct pci_device_id *ent)
> {
> + if (IS_ENABLED(CONFIG_CAVIUM_PMU_OCX_TLK))
> + cvm_ocx_tlk_pmu_probe(pdev, ent);
> if (IS_ENABLED(CONFIG_EDAC_THUNDERX))
> thunderx_edac_ocx_probe(pdev, ent);
> return 0;
> @@ -20,6 +22,8 @@ static int cvm_ocx_probe(struct pci_dev *pdev,
>
> static void cvm_ocx_remove(struct pci_dev *pdev)
> {
> + if (IS_ENABLED(CONFIG_CAVIUM_PMU_OCX_TLK))
> + cvm_ocx_tlk_pmu_remove(pdev);
> if (IS_ENABLED(CONFIG_EDAC_THUNDERX))
> thunderx_edac_ocx_remove(pdev);
> }
> diff --git a/include/linux/soc/cavium/ocx.h b/include/linux/soc/cavium/ocx.h
> index 29f55b3d3171..f7b2caada671 100644
> --- a/include/linux/soc/cavium/ocx.h
> +++ b/include/linux/soc/cavium/ocx.h
> @@ -3,6 +3,9 @@
>
> #include <linux/pci.h>
>
> +int cvm_ocx_tlk_pmu_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
> +void cvm_ocx_tlk_pmu_remove(struct pci_dev *pdev);
> +
> int thunderx_edac_ocx_probe(struct pci_dev *pdev, const struct pci_device_id *ent);
> void thunderx_edac_ocx_remove(struct pci_dev *pdev);
>
next prev parent reply other threads:[~2017-09-27 15:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 12:34 [PATCH v10 0/7] Cavium ARM64 uncore PMU support Jan Glauber
2017-09-25 12:34 ` Jan Glauber
2017-09-25 12:34 ` [PATCH v10 1/7] edac: thunderx: Remove suspend/resume support Jan Glauber
2017-09-25 12:34 ` Jan Glauber
2017-09-27 15:48 ` Borislav Petkov
2017-09-27 15:48 ` Borislav Petkov
2017-09-25 12:34 ` [PATCH v10 2/7] perf: export perf_event_update_userpage() Jan Glauber
2017-09-25 12:34 ` Jan Glauber
2017-09-25 12:34 ` [PATCH v10 3/7] edac, soc: thunderx: Add wrapper for EDAC LMC PCI device Jan Glauber
2017-09-25 12:34 ` [PATCH v10 3/7] edac,soc: " Jan Glauber
2017-09-27 16:19 ` [PATCH v10 3/7] edac, soc: " Borislav Petkov
2017-09-27 16:19 ` [PATCH v10 3/7] edac,soc: " Borislav Petkov
2017-10-02 15:17 ` [PATCH v10 3/7] edac, soc: " Jan Glauber
2017-10-02 15:17 ` [PATCH v10 3/7] edac,soc: " Jan Glauber
2017-10-04 10:34 ` [PATCH v10 3/7] edac, soc: " Borislav Petkov
2017-10-04 10:34 ` [PATCH v10 3/7] edac,soc: " Borislav Petkov
2017-09-25 12:34 ` [PATCH v10 4/7] edac, soc: thunderx: Add wrapper for EDAC OCX " Jan Glauber
2017-09-25 12:34 ` [PATCH v10 4/7] edac,soc: " Jan Glauber
2017-09-25 12:35 ` [PATCH v10 5/7] perf: cavium: Support memory controller PMU counters Jan Glauber
2017-09-25 12:35 ` Jan Glauber
2017-11-09 10:07 ` Suzuki K Poulose
2017-11-09 10:07 ` Suzuki K Poulose
2017-09-25 12:35 ` [PATCH v10 6/7] perf: cavium: Support transmit-link " Jan Glauber
2017-09-25 12:35 ` Jan Glauber
2017-09-27 15:48 ` Jonathan Cameron [this message]
2017-09-27 15:48 ` Jonathan Cameron
2017-09-25 12:35 ` [PATCH v10 7/7] perf: cavium: Add Documentation Jan Glauber
2017-09-25 12:35 ` Jan Glauber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927164846.00001cbe@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.