[PATCH] staging: vc04_services: Remove duplicate extern variable

[PATCH] staging: vc04_services: Remove duplicate extern variable

[Mihaela Muraru]

This patch removes the extern vchiq_arm_log_level variable from
vchiq_2835_arm.c.The variable is also declared in vchiq_arm.h header.

Issue found by checpatch.pl

Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
index 0159ca4..12b0e0d 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
@@ -84,7 +84,6 @@ static char *g_free_fragments;
 static struct semaphore g_free_fragments_sema;
 static struct device *g_dev;
 
-extern int vchiq_arm_log_level;
 
 static DEFINE_SEMAPHORE(g_free_fragments_mutex);
 
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] staging: vc04_services: Remove duplicate extern variable

[Julia Lawall]

On Thu, 28 Sep 2017, Mihaela Muraru wrote:

> This patch removes the extern vchiq_arm_log_level variable from
> vchiq_2835_arm.c.The variable is also declared in vchiq_arm.h header.
>
> Issue found by checpatch.pl

checpatch.pl -> checkpatch.pl

>
> Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
> ---
>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> index 0159ca4..12b0e0d 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> @@ -84,7 +84,6 @@ static char *g_free_fragments;
>  static struct semaphore g_free_fragments_sema;
>  static struct device *g_dev;
>
> -extern int vchiq_arm_log_level;
>

You're going to end up with two blank lines here.

julia

>  static DEFINE_SEMAPHORE(g_free_fragments_mutex);
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170928093917.GA5023%40ubuntu.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] staging: vc04_services: Remove duplicate extern variable

[Mihaela Muraru]

On Thu, Sep 28, 2017 at 12:35:40PM +0200, Julia Lawall wrote:
> 
> 
> On Thu, 28 Sep 2017, Mihaela Muraru wrote:
> 
> > This patch removes the extern vchiq_arm_log_level variable from
> > vchiq_2835_arm.c.The variable is also declared in vchiq_arm.h header.
> >
> > Issue found by checpatch.pl
> 
> checpatch.pl -> checkpatch.pl
> 
> >
> > Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
> > ---
> >  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> > index 0159ca4..12b0e0d 100644
> > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> > @@ -84,7 +84,6 @@ static char *g_free_fragments;
> >  static struct semaphore g_free_fragments_sema;
> >  static struct device *g_dev;
> >
> > -extern int vchiq_arm_log_level;
> >
> 
> You're going to end up with two blank lines here.
> 
> julia

Thank you,

I will send patch v2 with these changes

Mihaela
> >  static DEFINE_SEMAPHORE(g_free_fragments_mutex);
> >
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170928093917.GA5023%40ubuntu.
> > For more options, visit https://groups.google.com/d/optout.
> >