Re: [PATCH v4 02/15] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general

[Yi Sun <yi.y.sun@linux.intel.com>]

On 17-09-28 04:21:10, Jan Beulich wrote:
> >>> On 23.09.17 at 11:48, <yi.y.sun@linux.intel.com> wrote:
> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > @@ -37,7 +37,7 @@
> >  #include "hvm/save.h"
> >  #include "memory.h"
> >  
> > -#define XEN_DOMCTL_INTERFACE_VERSION 0x0000000e
> > +#define XEN_DOMCTL_INTERFACE_VERSION 0x0000000f
> 
> This is needed only if the series doesn't make 4.10; 4.9 had it
> ad 0x0000000d.
> 
Thanks! So, this version number is upgraded only for one release. I thought
every interface change should bump it.

> > @@ -743,22 +743,22 @@ struct xen_sysctl_pcitopoinfo {
> >  typedef struct xen_sysctl_pcitopoinfo xen_sysctl_pcitopoinfo_t;
> >  DEFINE_XEN_GUEST_HANDLE(xen_sysctl_pcitopoinfo_t);
> >  
> > -#define XEN_SYSCTL_PSR_CAT_get_l3_info               0
> > -#define XEN_SYSCTL_PSR_CAT_get_l2_info               1
> > -struct xen_sysctl_psr_cat_op {
> > -    uint32_t cmd;       /* IN: XEN_SYSCTL_PSR_CAT_* */
> > +#define XEN_SYSCTL_PSR_get_l3_info               0
> > +#define XEN_SYSCTL_PSR_get_l2_info               1
> > +struct xen_sysctl_psr_alloc {
> > +    uint32_t cmd;       /* IN: XEN_SYSCTL_PSR_* */
> >      uint32_t target;    /* IN */
> >      union {
> >          struct {
> >              uint32_t cbm_len;   /* OUT: CBM length */
> >              uint32_t cos_max;   /* OUT: Maximum COS */
> > -#define XEN_SYSCTL_PSR_CAT_L3_CDP       (1u << 0)
> > +#define XEN_SYSCTL_PSR_L3_CDP       (1u << 0)
> 
> Is MBA have something like CDP as well, which can go through the
> same subop? Otherwise I think CAT would better remain present
> in this constant's name.
>
No. I will keep CAT for this macro.
 
> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel