From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] usb: Use angle brackets for cacard include directive
Date: Fri, 29 Sep 2017 18:34:11 +0800 [thread overview]
Message-ID: <20170929103411.GF26066@lemon.lan> (raw)
In-Reply-To: <20170920085952.3872-1-famz@redhat.com>
On Wed, 09/20 16:59, Fam Zheng wrote:
> This is a library header, so angle brackets are more appropriate; also
> move the line to before QEMU headers, as is recommended in HACKING.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> hw/usb/ccid-card-passthru.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c
> index 45d96b03c6..117711862e 100644
> --- a/hw/usb/ccid-card-passthru.c
> +++ b/hw/usb/ccid-card-passthru.c
> @@ -9,11 +9,11 @@
> */
>
> #include "qemu/osdep.h"
> +#include <cacard/vscard_common.h>
> #include "chardev/char-fe.h"
> #include "qemu/error-report.h"
> #include "qemu/sockets.h"
> #include "ccid.h"
> -#include "cacard/vscard_common.h"
>
> #define DPRINTF(card, lvl, fmt, ...) \
> do { \
> --
> 2.13.5
>
>
Cc: qemu-trivial@nongnu.org
WARNING: multiple messages have this Message-ID (diff)
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] usb: Use angle brackets for cacard include directive
Date: Fri, 29 Sep 2017 18:34:11 +0800 [thread overview]
Message-ID: <20170929103411.GF26066@lemon.lan> (raw)
In-Reply-To: <20170920085952.3872-1-famz@redhat.com>
On Wed, 09/20 16:59, Fam Zheng wrote:
> This is a library header, so angle brackets are more appropriate; also
> move the line to before QEMU headers, as is recommended in HACKING.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> hw/usb/ccid-card-passthru.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c
> index 45d96b03c6..117711862e 100644
> --- a/hw/usb/ccid-card-passthru.c
> +++ b/hw/usb/ccid-card-passthru.c
> @@ -9,11 +9,11 @@
> */
>
> #include "qemu/osdep.h"
> +#include <cacard/vscard_common.h>
> #include "chardev/char-fe.h"
> #include "qemu/error-report.h"
> #include "qemu/sockets.h"
> #include "ccid.h"
> -#include "cacard/vscard_common.h"
>
> #define DPRINTF(card, lvl, fmt, ...) \
> do { \
> --
> 2.13.5
>
>
Cc: qemu-trivial@nongnu.org
next prev parent reply other threads:[~2017-09-29 10:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 8:59 [Qemu-devel] [PATCH] usb: Use angle brackets for cacard include directive Fam Zheng
2017-09-29 10:34 ` Fam Zheng [this message]
2017-09-29 10:34 ` Fam Zheng
2017-09-29 10:42 ` [Qemu-trivial] " Gerd Hoffmann
2017-09-29 10:42 ` Gerd Hoffmann
2017-09-29 10:59 ` [Qemu-trivial] " Fam Zheng
2017-09-29 10:59 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170929103411.GF26066@lemon.lan \
--to=famz@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.