* [PATCH] Staging: speakup: replace 'S_IRUGO' macro with octal 0444
@ 2017-09-28 15:38 Keerthi Reddy
2017-09-28 23:19 ` Samuel Thibault
2017-09-29 13:29 ` [Outreachy kernel] " Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Keerthi Reddy @ 2017-09-28 15:38 UTC (permalink / raw)
To: outreachy-kernel; +Cc: speakup, w.d.hubbs, chris, kirk, samuel.thibault
Everyone knows what 0444 means. But one has read through docs
to understand the meaning of 'S_IRUGO'.
Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com>
---
drivers/staging/speakup/speakup_apollo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/speakup_apollo.c b/drivers/staging/speakup/speakup_apollo.c
index 2edb56c..dcf0c3b 100644
--- a/drivers/staging/speakup/speakup_apollo.c
+++ b/drivers/staging/speakup/speakup_apollo.c
@@ -200,7 +200,7 @@ static void do_catch_up(struct spk_synth *synth)
}
module_param_named(ser, synth_apollo.ser, int, 0444);
-module_param_named(dev, synth_apollo.dev_name, charp, S_IRUGO);
+module_param_named(dev, synth_apollo.dev_name, charp, 0444);
module_param_named(start, synth_apollo.startup, short, 0444);
MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: speakup: replace 'S_IRUGO' macro with octal 0444
2017-09-28 15:38 [PATCH] Staging: speakup: replace 'S_IRUGO' macro with octal 0444 Keerthi Reddy
@ 2017-09-28 23:19 ` Samuel Thibault
2017-09-29 13:29 ` [Outreachy kernel] " Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Thibault @ 2017-09-28 23:19 UTC (permalink / raw)
To: Keerthi Reddy; +Cc: outreachy-kernel, speakup, w.d.hubbs, chris, kirk
Hello,
Keerthi Reddy, on jeu. 28 sept. 2017 21:08:26 +0530, wrote:
> Everyone knows what 0444 means. But one has read through docs
> to understand the meaning of 'S_IRUGO'.
Yes. Could you do the same on all files of the
drivers/staging/speakup/ directory altogether?
Thanks,
Samuel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: speakup: replace 'S_IRUGO' macro with octal 0444
2017-09-28 15:38 [PATCH] Staging: speakup: replace 'S_IRUGO' macro with octal 0444 Keerthi Reddy
2017-09-28 23:19 ` Samuel Thibault
@ 2017-09-29 13:29 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2017-09-29 13:29 UTC (permalink / raw)
To: Keerthi Reddy
Cc: outreachy-kernel, speakup, w.d.hubbs, chris, kirk,
samuel.thibault
On Thu, Sep 28, 2017 at 09:08:26PM +0530, Keerthi Reddy wrote:
> Everyone knows what 0444 means. But one has read through docs
> to understand the meaning of 'S_IRUGO'.
>
> Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com>
> ---
> drivers/staging/speakup/speakup_apollo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This change is already in my tree, please make sure you work against the
correct kenel tree/branch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-29 13:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-28 15:38 [PATCH] Staging: speakup: replace 'S_IRUGO' macro with octal 0444 Keerthi Reddy
2017-09-28 23:19 ` Samuel Thibault
2017-09-29 13:29 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.