* Re: [Qemu-devel] [PATCH] target/mips: remove commented out codes intranslate.c
@ 2017-09-30 0:38 jiang.biao2
0 siblings, 0 replies; only message in thread
From: jiang.biao2 @ 2017-09-30 0:38 UTC (permalink / raw)
To: yongbok.kim; +Cc: f4bug, aurelien, zhong.weidong, qemu-devel
> On 29/09/2017 10:58, Philippe Mathieu-Daudé wrote:
> > Hi Jiang,
> >
> > I'm not sure it is really helpful to remove those comment, they are here as
> > debt to the project, reminding what should be implemented.
> >
> > Are you proposing to accept this instructions will never get implemented?
> >
> > Regards,
> >
> > Phil.
>>
>
> Hi Phil,
>
> The commented codes are all trivial. When the time we implement those
> features it is merely copy & paste from the specification. I don't think
> there is much harm to remove the comments.
> Besides there is TODO file in the same directory but that has not been
> updated for a while, perhaps updating the file is much relevant with this
> patch.
Can't agree more :), it should be better put the reminder in other place
rather in release code.
Regards,
Jiang
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-09-30 0:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-30 0:38 [Qemu-devel] [PATCH] target/mips: remove commented out codes intranslate.c jiang.biao2
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.