From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, andreas.noever@gmail.com,
michael.jamet@intel.com, yehezkel.bernat@intel.com,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] thunderbolt: make tb_domain_type const
Date: Mon, 2 Oct 2017 12:28:25 +0300 [thread overview]
Message-ID: <20171002092825.GP4630@lahna.fi.intel.com> (raw)
In-Reply-To: <1506789432-9967-1-git-send-email-bhumirks@gmail.com>
On Sat, Sep 30, 2017 at 10:07:12PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in the const field of a device
> structure. Make the declaration in header const too.
>
> Structure found using Coccinelle and changes done by hand.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
This looks good. However, I'm currently doing some shuffling in
drivers/thunderbolt/tb.h to get Thunderbolt services supported which
makes this patch not to apply cleanly anymore:
https://lkml.org/lkml/2017/9/25/225
I wonder if you could rebase your patch on top of that?
Also please Cc Greg as well.
prev parent reply other threads:[~2017-10-02 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 16:37 [PATCH] thunderbolt: make tb_domain_type const Bhumika Goyal
2017-10-02 9:28 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002092825.GP4630@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andreas.noever@gmail.com \
--cc=bhumirks@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=yehezkel.bernat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.