From: Jerome Glisse <jglisse@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Ralph Campbell <rcampbell@nvidia.com>
Subject: Re: [PATCH] mm/hmm: constify hmm_devmem_page_get_drvdata() parameter
Date: Mon, 2 Oct 2017 17:47:23 -0400 [thread overview]
Message-ID: <20171002214722.GA5184@redhat.com> (raw)
In-Reply-To: <20171002144042.e33ff3cf7dc95845e255d2c0@linux-foundation.org>
On Mon, Oct 02, 2017 at 02:40:42PM -0700, Andrew Morton wrote:
> On Mon, 2 Oct 2017 15:32:54 -0400 Jerome Glisse <jglisse@redhat.com> wrote:
>
> > From: Ralph Campbell <rcampbell@nvidia.com>
> >
> > Constify pointer parameter to avoid issue when use from code that
> > only has const struct page pointer to use in the first place.
>
> That's rather vague. Does such calling code exist in the kernel? This
> affects the which-kernel-gets-patched decision.
This is use by device driver, no driver upstream yet so it does not
affect anybody upstream yet.
Jerome
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Glisse <jglisse@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Ralph Campbell <rcampbell@nvidia.com>
Subject: Re: [PATCH] mm/hmm: constify hmm_devmem_page_get_drvdata() parameter
Date: Mon, 2 Oct 2017 17:47:23 -0400 [thread overview]
Message-ID: <20171002214722.GA5184@redhat.com> (raw)
In-Reply-To: <20171002144042.e33ff3cf7dc95845e255d2c0@linux-foundation.org>
On Mon, Oct 02, 2017 at 02:40:42PM -0700, Andrew Morton wrote:
> On Mon, 2 Oct 2017 15:32:54 -0400 Jérôme Glisse <jglisse@redhat.com> wrote:
>
> > From: Ralph Campbell <rcampbell@nvidia.com>
> >
> > Constify pointer parameter to avoid issue when use from code that
> > only has const struct page pointer to use in the first place.
>
> That's rather vague. Does such calling code exist in the kernel? This
> affects the which-kernel-gets-patched decision.
This is use by device driver, no driver upstream yet so it does not
affect anybody upstream yet.
Jérôme
next prev parent reply other threads:[~2017-10-02 21:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 19:32 [PATCH] mm/hmm: constify hmm_devmem_page_get_drvdata() parameter Jérôme Glisse
2017-10-02 19:32 ` Jérôme Glisse
2017-10-02 21:40 ` Andrew Morton
2017-10-02 21:40 ` Andrew Morton
2017-10-02 21:47 ` Jerome Glisse [this message]
2017-10-02 21:47 ` Jerome Glisse
2017-10-02 21:54 ` Ralph Campbell
2017-10-02 21:54 ` Ralph Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002214722.GA5184@redhat.com \
--to=jglisse@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.