From: Guenter Roeck <linux@roeck-us.net>
To: Colin King <colin.king@canonical.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andrew Duggan <aduggan@synaptics.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: synaptics-rmi4: make array rmi_f54_report_type_names static
Date: Mon, 02 Oct 2017 22:18:52 +0000 [thread overview]
Message-ID: <20171002221852.GA12530@roeck-us.net> (raw)
In-Reply-To: <20171002220525.11339-1-colin.king@canonical.com>
On Mon, Oct 02, 2017 at 11:05:25PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The array rmi_f54_report_type_names is local to the source and does
> not need to be in global scope, so make it static. Also make the array
> const char * const
>
> Cleans up sparse warning:
> symbol 'rmi_f54_report_type_names' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/input/rmi4/rmi_f54.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
> index f5206e2c767e..70f6310f1d15 100644
> --- a/drivers/input/rmi4/rmi_f54.c
> +++ b/drivers/input/rmi4/rmi_f54.c
> @@ -73,7 +73,7 @@ enum rmi_f54_report_type {
> F54_MAX_REPORT_TYPE,
> };
>
> -const char *rmi_f54_report_type_names[] = {
> +static const char * const rmi_f54_report_type_names[] = {
> [F54_REPORT_NONE] = "Unknown",
> [F54_8BIT_IMAGE] = "Normalized 8-Bit Image",
> [F54_16BIT_IMAGE] = "Normalized 16-Bit Image",
> --
> 2.14.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Colin King <colin.king@canonical.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andrew Duggan <aduggan@synaptics.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: synaptics-rmi4: make array rmi_f54_report_type_names static
Date: Mon, 2 Oct 2017 15:18:52 -0700 [thread overview]
Message-ID: <20171002221852.GA12530@roeck-us.net> (raw)
In-Reply-To: <20171002220525.11339-1-colin.king@canonical.com>
On Mon, Oct 02, 2017 at 11:05:25PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The array rmi_f54_report_type_names is local to the source and does
> not need to be in global scope, so make it static. Also make the array
> const char * const
>
> Cleans up sparse warning:
> symbol 'rmi_f54_report_type_names' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/input/rmi4/rmi_f54.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
> index f5206e2c767e..70f6310f1d15 100644
> --- a/drivers/input/rmi4/rmi_f54.c
> +++ b/drivers/input/rmi4/rmi_f54.c
> @@ -73,7 +73,7 @@ enum rmi_f54_report_type {
> F54_MAX_REPORT_TYPE,
> };
>
> -const char *rmi_f54_report_type_names[] = {
> +static const char * const rmi_f54_report_type_names[] = {
> [F54_REPORT_NONE] = "Unknown",
> [F54_8BIT_IMAGE] = "Normalized 8-Bit Image",
> [F54_16BIT_IMAGE] = "Normalized 16-Bit Image",
> --
> 2.14.1
>
next prev parent reply other threads:[~2017-10-02 22:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 22:05 [PATCH] input: synaptics-rmi4: make array rmi_f54_report_type_names static Colin King
2017-10-02 22:05 ` Colin King
2017-10-02 22:18 ` Guenter Roeck [this message]
2017-10-02 22:18 ` Guenter Roeck
2017-10-05 0:00 ` Dmitry Torokhov
2017-10-05 0:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002221852.GA12530@roeck-us.net \
--to=linux@roeck-us.net \
--cc=aduggan@synaptics.com \
--cc=colin.king@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.