From: Roman Gushchin <guro@fb.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, Vladimir Davydov <vdavydov.dev@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>,
kernel-team@fb.com, cgroups@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [v9 4/5] mm, oom: add cgroup v2 mount option for cgroup-aware OOM killer
Date: Tue, 3 Oct 2017 13:49:36 +0100 [thread overview]
Message-ID: <20171003124936.GA28904@castle.DHCP.thefacebook.com> (raw)
In-Reply-To: <20171003115036.3zzydsiiz7hbx4jg@dhcp22.suse.cz>
On Tue, Oct 03, 2017 at 01:50:36PM +0200, Michal Hocko wrote:
> On Wed 27-09-17 14:09:35, Roman Gushchin wrote:
> > Add a "groupoom" cgroup v2 mount option to enable the cgroup-aware
> > OOM killer. If not set, the OOM selection is performed in
> > a "traditional" per-process way.
> >
> > The behavior can be changed dynamically by remounting the cgroupfs.
>
> I do not have a strong preference about this. I would just be worried
> that it is usually systemd which tries to own the whole hierarchy
I actually like this fact.
It gives us the opportunity to change the default behavior for most users
at the point when we'll be sure that new behavior is better; but at the same
time we'll save full compatibility on the kernel level.
With growing popularity of memory cgroups, I don't think that hiding
this functionality with a boot option makes any sense. It's just not
this type of feature, that should be hidden.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Roman Gushchin <guro@fb.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: <linux-mm@kvack.org>, Vladimir Davydov <vdavydov.dev@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, <kernel-team@fb.com>,
<cgroups@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [v9 4/5] mm, oom: add cgroup v2 mount option for cgroup-aware OOM killer
Date: Tue, 3 Oct 2017 13:49:36 +0100 [thread overview]
Message-ID: <20171003124936.GA28904@castle.DHCP.thefacebook.com> (raw)
In-Reply-To: <20171003115036.3zzydsiiz7hbx4jg@dhcp22.suse.cz>
On Tue, Oct 03, 2017 at 01:50:36PM +0200, Michal Hocko wrote:
> On Wed 27-09-17 14:09:35, Roman Gushchin wrote:
> > Add a "groupoom" cgroup v2 mount option to enable the cgroup-aware
> > OOM killer. If not set, the OOM selection is performed in
> > a "traditional" per-process way.
> >
> > The behavior can be changed dynamically by remounting the cgroupfs.
>
> I do not have a strong preference about this. I would just be worried
> that it is usually systemd which tries to own the whole hierarchy
I actually like this fact.
It gives us the opportunity to change the default behavior for most users
at the point when we'll be sure that new behavior is better; but at the same
time we'll save full compatibility on the kernel level.
With growing popularity of memory cgroups, I don't think that hiding
this functionality with a boot option makes any sense. It's just not
this type of feature, that should be hidden.
next prev parent reply other threads:[~2017-10-03 12:49 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 13:09 [v9 0/5] cgroup-aware OOM killer Roman Gushchin
2017-09-27 13:09 ` Roman Gushchin
2017-09-27 13:09 ` [v9 1/5] mm, oom: refactor the oom_kill_process() function Roman Gushchin
2017-09-27 13:09 ` Roman Gushchin
2017-09-27 13:09 ` [v9 2/5] mm: implement mem_cgroup_scan_tasks() for the root memory cgroup Roman Gushchin
2017-09-27 13:09 ` Roman Gushchin
2017-10-03 10:49 ` Michal Hocko
2017-10-03 10:49 ` Michal Hocko
2017-10-03 12:50 ` Roman Gushchin
2017-10-03 12:50 ` Roman Gushchin
2017-09-27 13:09 ` [v9 3/5] mm, oom: cgroup-aware OOM killer Roman Gushchin
2017-09-27 13:09 ` Roman Gushchin
2017-10-03 11:48 ` Michal Hocko
2017-10-03 11:48 ` Michal Hocko
2017-10-03 12:37 ` Roman Gushchin
2017-10-03 12:37 ` Roman Gushchin
2017-10-03 12:37 ` Roman Gushchin
2017-10-03 13:36 ` Michal Hocko
2017-10-03 13:36 ` Michal Hocko
2017-10-03 14:08 ` Roman Gushchin
2017-10-03 14:08 ` Roman Gushchin
2017-10-03 14:22 ` Michal Hocko
2017-10-03 14:22 ` Michal Hocko
[not found] ` <20171003142246.xactdt7xddqdhvtu-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2017-10-03 14:35 ` Tejun Heo
2017-10-03 14:35 ` Tejun Heo
2017-10-03 14:35 ` Tejun Heo
2017-10-04 9:29 ` Michal Hocko
2017-10-04 9:29 ` Michal Hocko
2017-10-03 14:38 ` Roman Gushchin
2017-10-03 14:38 ` Roman Gushchin
2017-10-03 14:38 ` Roman Gushchin
2017-10-03 14:43 ` Michal Hocko
2017-10-03 14:43 ` Michal Hocko
2017-10-04 15:04 ` Roman Gushchin
2017-10-04 15:04 ` Roman Gushchin
2017-10-04 15:04 ` Roman Gushchin
2017-09-27 13:09 ` [v9 4/5] mm, oom: add cgroup v2 mount option for " Roman Gushchin
2017-09-27 13:09 ` Roman Gushchin
2017-10-03 11:50 ` Michal Hocko
2017-10-03 11:50 ` Michal Hocko
2017-10-03 12:49 ` Roman Gushchin [this message]
2017-10-03 12:49 ` Roman Gushchin
2017-10-03 13:39 ` Michal Hocko
2017-10-03 13:39 ` Michal Hocko
2017-09-27 13:09 ` [v9 5/5] mm, oom, docs: describe the " Roman Gushchin
2017-09-27 13:09 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003124936.GA28904@castle.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.