From: Jean Delvare <jdelvare@suse.de>
To: Colin King <colin.king@canonical.com>
Cc: Mike Waychison <mikew@google.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: google: make structure gsmi_dev static
Date: Tue, 03 Oct 2017 12:20:11 +0000 [thread overview]
Message-ID: <20171003142011.4bd5a033@endymion> (raw)
In-Reply-To: <20171003084048.24375-1-colin.king@canonical.com>
On Tue, 3 Oct 2017 09:40:48 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The structure gsmi_dev is local to the source and does not need to be
> in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'gsmi_dev' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/firmware/google/gsmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
> index c8f169bf2e27..734146eec1b9 100644
> --- a/drivers/firmware/google/gsmi.c
> +++ b/drivers/firmware/google/gsmi.c
> @@ -84,7 +84,7 @@ struct gsmi_buf {
> u32 address; /* physical address of buffer */
> };
>
> -struct gsmi_device {
> +static struct gsmi_device {
> struct platform_device *pdev; /* platform device */
> struct gsmi_buf *name_buf; /* variable name buffer */
> struct gsmi_buf *data_buf; /* generic data buffer */
Acked-by: Jean Delvare <jdelvare@suse.de>
Thanks,
--
Jean Delvare
SUSE L3 Support
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <jdelvare@suse.de>
To: Colin King <colin.king@canonical.com>
Cc: Mike Waychison <mikew@google.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: google: make structure gsmi_dev static
Date: Tue, 3 Oct 2017 14:20:11 +0200 [thread overview]
Message-ID: <20171003142011.4bd5a033@endymion> (raw)
In-Reply-To: <20171003084048.24375-1-colin.king@canonical.com>
On Tue, 3 Oct 2017 09:40:48 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The structure gsmi_dev is local to the source and does not need to be
> in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'gsmi_dev' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/firmware/google/gsmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
> index c8f169bf2e27..734146eec1b9 100644
> --- a/drivers/firmware/google/gsmi.c
> +++ b/drivers/firmware/google/gsmi.c
> @@ -84,7 +84,7 @@ struct gsmi_buf {
> u32 address; /* physical address of buffer */
> };
>
> -struct gsmi_device {
> +static struct gsmi_device {
> struct platform_device *pdev; /* platform device */
> struct gsmi_buf *name_buf; /* variable name buffer */
> struct gsmi_buf *data_buf; /* generic data buffer */
Acked-by: Jean Delvare <jdelvare@suse.de>
Thanks,
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2017-10-03 12:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 8:40 [PATCH] firmware: google: make structure gsmi_dev static Colin King
2017-10-03 8:40 ` Colin King
2017-10-03 12:20 ` Jean Delvare [this message]
2017-10-03 12:20 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003142011.4bd5a033@endymion \
--to=jdelvare@suse.de \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.