From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme-pci: Use PCI bus address for data/queues in CMB
Date: Tue, 3 Oct 2017 09:06:49 -0600 [thread overview]
Message-ID: <20171003150649.GA2195@localhost.localdomain> (raw)
In-Reply-To: <CAKUFe6YHJ+jBgxtEy+YTTDQtphtOEz6+xfBXdowsFKy7ZMqW3w@mail.gmail.com>
On Sat, Sep 30, 2017@02:30:16PM +0530, Abhishek Shah wrote:
> > On a similar note, we also break CMB usage in virutalization with direct
> > assigned devices: the guest doesn't know the host physical bus address,
> > so it sets the CMB queue address incorrectly there, too. I don't know of
> > a way to fix that other than disabling CMB.
>
> I don't have much idea on CMB usage in virtualization... will let
> someone else comment on this.
It's okay, I think it's a gap in the NVMe specification that would allow
such usage.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: Abhishek Shah <abhishek.shah@broadcom.com>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org,
open list <linux-kernel@vger.kernel.org>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] nvme-pci: Use PCI bus address for data/queues in CMB
Date: Tue, 3 Oct 2017 09:06:49 -0600 [thread overview]
Message-ID: <20171003150649.GA2195@localhost.localdomain> (raw)
In-Reply-To: <CAKUFe6YHJ+jBgxtEy+YTTDQtphtOEz6+xfBXdowsFKy7ZMqW3w@mail.gmail.com>
On Sat, Sep 30, 2017 at 02:30:16PM +0530, Abhishek Shah wrote:
> > On a similar note, we also break CMB usage in virutalization with direct
> > assigned devices: the guest doesn't know the host physical bus address,
> > so it sets the CMB queue address incorrectly there, too. I don't know of
> > a way to fix that other than disabling CMB.
>
> I don't have much idea on CMB usage in virtualization... will let
> someone else comment on this.
It's okay, I think it's a gap in the NVMe specification that would allow
such usage.
next prev parent reply other threads:[~2017-10-03 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 5:29 [PATCH] nvme-pci: Use PCI bus address for data/queues in CMB Abhishek Shah
2017-09-29 5:29 ` Abhishek Shah
2017-09-29 14:42 ` Keith Busch
2017-09-29 14:42 ` Keith Busch
2017-09-30 9:00 ` Abhishek Shah
2017-09-30 9:00 ` Abhishek Shah
2017-10-03 15:06 ` Keith Busch [this message]
2017-10-03 15:06 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003150649.GA2195@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.