* [PATCH v3] staging: rtl8188eu: Use __func__ instead of function name
@ 2017-10-01 22:08 Mihaela Muraru
2017-10-03 16:21 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Mihaela Muraru @ 2017-10-01 22:08 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Greg Kroah-Hartman
Use identifier __func__ instead of the name of the function.
Issue found by checkpatch.pl.
Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
Changes in v3:
- remove unnecessary ()
---
.../staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 28 +++++++++++-----------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
index c7ae332..4e21475 100644
--- a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
+++ b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
@@ -126,10 +126,10 @@ static int odm_RateDown_8188E(struct odm_dm_struct *dm_odm,
u8 i;
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE,
- ODM_DBG_TRACE, ("=====>%s()\n", __func__));
+ ODM_DBG_TRACE, ("=====>%s\n", __func__));
if (!pRaInfo) {
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_LOUD,
- ("%s(): pRaInfo is NULL\n", __func__));
+ ("%s: pRaInfo is NULL\n", __func__));
return -1;
}
RateID = pRaInfo->PreRate;
@@ -179,7 +179,7 @@ static int odm_RateDown_8188E(struct odm_dm_struct *dm_odm,
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_LOUD,
("Rate down to RateID %d RateSGI %d\n", RateID, pRaInfo->RateSGI));
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_TRACE,
- ("<===== %s()\n", __func__));
+ ("<===== %s\n", __func__));
return 0;
}
@@ -192,10 +192,10 @@ static int odm_RateUp_8188E(
u8 i;
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE,
- ODM_DBG_TRACE, ("=====>%s()\n", __func__));
+ ODM_DBG_TRACE, ("=====>%s\n", __func__));
if (!pRaInfo) {
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_LOUD,
- ("%s(): pRaInfo is NULL\n", __func__));
+ ("%s: pRaInfo is NULL\n", __func__));
return -1;
}
RateID = pRaInfo->PreRate;
@@ -212,7 +212,7 @@ static int odm_RateUp_8188E(
}
odm_SetTxRPTTiming_8188E(dm_odm, pRaInfo, 0);
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_LOUD,
- ("%s():Decrease RPT Timing\n", __func__));
+ ("%s:Decrease RPT Timing\n", __func__));
if (RateID < HighestRate) {
for (i = RateID+1; i <= HighestRate; i++) {
@@ -243,7 +243,7 @@ static int odm_RateUp_8188E(
("RAWaitingCounter %d, RAPendingCounter %d",
pRaInfo->RAWaitingCounter, pRaInfo->RAPendingCounter));
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE,
- ODM_DBG_TRACE, ("<===== %s()\n", __func__));
+ ODM_DBG_TRACE, ("<===== %s\n", __func__));
return 0;
}
@@ -265,7 +265,7 @@ static void odm_RateDecision_8188E(struct odm_dm_struct *dm_odm,
static u8 DynamicTxRPTTimingCounter;
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_TRACE,
- ("=====>%s()\n", __func__));
+ ("=====>%s\n", __func__));
if (pRaInfo->Active && (pRaInfo->TOTAL > 0)) { /* STA used and data packet exits */
if ((pRaInfo->RssiStaRA < (pRaInfo->PreRssiStaRA - 3)) ||
@@ -345,7 +345,7 @@ static void odm_RateDecision_8188E(struct odm_dm_struct *dm_odm,
odm_ResetRaCounter_8188E(pRaInfo);
}
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE,
- ODM_DBG_TRACE, ("<===== %s()\n", __func__));
+ ODM_DBG_TRACE, ("<===== %s\n", __func__));
}
static int odm_ARFBRefresh_8188E(struct odm_dm_struct *dm_odm, struct odm_ra_info *pRaInfo)
@@ -532,7 +532,7 @@ odm_RATxRPTTimerSetting(
)
{
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE,
- ODM_DBG_TRACE, (" =====>%s()\n", __func__));
+ ODM_DBG_TRACE, (" =====>%s\n", __func__));
if (dm_odm->CurrminRptTime != minRptTime) {
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_LOUD,
@@ -541,7 +541,7 @@ odm_RATxRPTTimerSetting(
dm_odm->CurrminRptTime = minRptTime;
}
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE,
- ODM_DBG_TRACE, (" <===== %s()\n", __func__));
+ ODM_DBG_TRACE, (" <===== %s\n", __func__));
}
void
@@ -550,7 +550,7 @@ ODM_RASupport_Init(
)
{
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE,
- ODM_DBG_LOUD, ("=====>%s()\n", __func__));
+ ODM_DBG_LOUD, ("=====>%s\n", __func__));
dm_odm->RaSupport88E = true;
}
@@ -705,7 +705,7 @@ void ODM_RA_TxRPT2Handle_8188E(struct odm_dm_struct *dm_odm, u8 *TxRPT_Buf, u16
u16 minRptTime = 0x927c;
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_LOUD,
- ("=====>%s(): valid0 =%d valid1 =%d BufferLength =%d\n",
+ ("=====>%s: valid0 =%d valid1 =%d BufferLength =%d\n",
__func__, macid_entry0, macid_entry1, TxRPT_Len));
ItemNum = TxRPT_Len >> 3;
@@ -781,5 +781,5 @@ void ODM_RA_TxRPT2Handle_8188E(struct odm_dm_struct *dm_odm, u8 *TxRPT_Buf, u16
odm_RATxRPTTimerSetting(dm_odm, minRptTime);
ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE,
- ODM_DBG_LOUD, ("<===== %s()\n", __func__));
+ ODM_DBG_LOUD, ("<===== %s\n", __func__));
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] staging: rtl8188eu: Use __func__ instead of function name
2017-10-01 22:08 [PATCH v3] staging: rtl8188eu: Use __func__ instead of function name Mihaela Muraru
@ 2017-10-03 16:21 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2017-10-03 16:21 UTC (permalink / raw)
To: Mihaela Muraru; +Cc: outreachy-kernel
On Mon, Oct 02, 2017 at 01:08:56AM +0300, Mihaela Muraru wrote:
> Use identifier __func__ instead of the name of the function.
>
> Issue found by checkpatch.pl.
>
> Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
>
> Changes in v3:
> - remove unnecessary ()
That goes below the --- line. And this patch does not apply at all,
please always make patches against my tree, not your previous patch that
was not accepted yet.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-03 16:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-01 22:08 [PATCH v3] staging: rtl8188eu: Use __func__ instead of function name Mihaela Muraru
2017-10-03 16:21 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.