All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Juergen Borleis <jbe@pengutronix.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] iptables: change large file support handling
Date: Wed, 4 Oct 2017 16:14:58 +0200	[thread overview]
Message-ID: <20171004141458.GA28637@salvia> (raw)
In-Reply-To: <201709281059.45061.jbe@pengutronix.de>

Hi Juergen,

On Thu, Sep 28, 2017 at 10:59:44AM +0200, Juergen Borleis wrote:
> The configure script handles the "--*-largefile" parameter badly. It
> defaults to large file support if not given and always disables largefile
> support if given (and it doesn't matter if 'enable' or 'disable' was used)

It seems the default behaviour for a while has been to enable
largefile by default.

Then, someone came in to add this --disable-largefile configure time
option, see:

commit 967cb7106f0f61cd7b8fbb10bc2451a3f7372a43
Author: Karl Hiramoto <karl@hiramoto.org>
Date:   Mon May 10 17:50:41 2010 +0200

    iptables: optionally disable largefile support

So I would just fix --enable-* --disable-*.

Would you follow up on this? Let me know, thanks.

  reply	other threads:[~2017-10-04 14:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-28  8:59 [PATCH] iptables: change large file support handling Juergen Borleis
2017-10-04 14:14 ` Pablo Neira Ayuso [this message]
2017-10-04 14:39   ` Juergen Borleis
2017-10-04 14:46     ` Pablo Neira Ayuso
2017-10-04 14:52       ` Juergen Borleis
2017-10-04 15:09         ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171004141458.GA28637@salvia \
    --to=pablo@netfilter.org \
    --cc=jbe@pengutronix.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.