From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Harsha Sharma <harshasharmaiitr@gmail.com>
Cc: netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 3/3] evaluate: make pointers in string arrays constant
Date: Wed, 4 Oct 2017 16:29:10 +0200 [thread overview]
Message-ID: <20171004142910.GA22122@salvia> (raw)
In-Reply-To: <9b81cec687c3082f5fd762ece696f1272945e0ad.1506928244.git.harshasharmaiitr@gmail.com>
On Mon, Oct 02, 2017 at 01:02:50PM +0530, Harsha Sharma wrote:
> static const char * array should probably be static const char * const
> array
> as per linux-kernel coding style
>
> Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
> ---
> src/evaluate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/evaluate.c b/src/evaluate.c
> index b783054..f48801a 100644
> --- a/src/evaluate.c
> +++ b/src/evaluate.c
> @@ -33,7 +33,7 @@
> static struct output_ctx octx_debug_dummy;
> static int expr_evaluate(struct eval_ctx *ctx, struct expr **expr);
>
> -static const char *byteorder_names[] = {
> +static const char * const byteorder_names[] = {
I can see more string array that could use this in the nftables tree.
Please, fix all in one single patch.
Thanks.
prev parent reply other threads:[~2017-10-04 14:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 7:32 [PATCH 0/3] evaluate: Follow linux-kernel coding style Harsha Sharma
2017-10-02 7:32 ` [PATCH 1/3] evaluate: Remove unnecessary spaces Harsha Sharma
2017-10-02 7:32 ` [PATCH 2/3] evaluate: Place constant on right side in comparison Harsha Sharma
2017-10-02 7:32 ` [PATCH 3/3] evaluate: make pointers in string arrays constant Harsha Sharma
2017-10-04 14:29 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004142910.GA22122@salvia \
--to=pablo@netfilter.org \
--cc=harshasharmaiitr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.