From: Harsha Sharma <harshasharmaiitr@gmail.com>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com,
Harsha Sharma <harshasharmaiitr@gmail.com>
Subject: [PATCH 0/3] evaluate: Follow linux-kernel coding style
Date: Mon, 2 Oct 2017 13:02:47 +0530 [thread overview]
Message-ID: <cover.1506928244.git.harshasharmaiitr@gmail.com> (raw)
Issues found using checkpatch.pl
As per linux-kernel coding style, code indent should use tabs wherever
possible and avoid unnecessary spaces.
Comparisons shoukd place the constant on the right side of the test.
static const char * array should be static const * char const array
Harsha Sharma (3):
evaluate: Remove unnecessary spaces
evaluate: Place constant on right side in comparison
evaluate: fix checkpatch issue for static const char * array
src/evaluate.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
--
1.9.1
next reply other threads:[~2017-10-02 7:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 7:32 Harsha Sharma [this message]
2017-10-02 7:32 ` [PATCH 1/3] evaluate: Remove unnecessary spaces Harsha Sharma
2017-10-02 7:32 ` [PATCH 2/3] evaluate: Place constant on right side in comparison Harsha Sharma
2017-10-02 7:32 ` [PATCH 3/3] evaluate: make pointers in string arrays constant Harsha Sharma
2017-10-04 14:29 ` [Outreachy kernel] " Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1506928244.git.harshasharmaiitr@gmail.com \
--to=harshasharmaiitr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.