Re: [PATCH 2/2] arm64: dts: qcom: Rename SBC to DragonBoard 410c

[Stephen Boyd <sboyd@codeaurora.org>]

On 10/04, Rob Clark wrote:
> On Wed, Oct 4, 2017 at 6:09 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > On 10/04, Rob Clark wrote:
> >> If we managed to get this in before the 4.14 LTS I might feel
> >> differently.  But afterwards, totally not. :-(
> >>
> >
> > How do you install dtbs onto your device? Should be simple enough
> > to run 'mv' on the new filename to the old one?
> >
> 
> it is part of the kernel package

Are you copying the file out of the arch/arm64/boot/dts
directory? Or you're using dtbs_install rule?

> but fixing it in the distro means fixing it in *every* distro..

That assumes every distro has a bootloader that's looking for one
file name vs. the other. And that the distro hasn't updated the
bootloader to pick a different name.

> 
> if we are going for a workaround, then it should be the kernel
> installing a symlink.  Not every distro having to fix things up in the
> same way for one particular board.

There was a discussion about this years ago when the dtbs_install
rule was introduced to the kernel makefiles[1]. Maybe the
sentiment has changed, but it seems that people involved in that
thread didn't consider the filename an ABI. Also, take a look at
commit f4d4ffc03efc ("kbuild: dtbs_install: new make target")
where it says:

"Removed option to call external script. Copying the files should
be sufficient and a build system can post-process the install
directory.  Despite the fact an external script is used for
installing the kernel, I don't think that is a pattern that
should be encouraged. I would rather see buildroot type tools
post process the install directory to rename or move dtb files
after installing to a staging directory."

which makes it look like the distro installation scripts would
rename things if desired.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-November/210562.html

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project