From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH v2 2/7] nvme_fc: change ctlr state assignments during reset/reconnect
Date: Thu, 5 Oct 2017 00:57:30 -0700 [thread overview]
Message-ID: <20171005075730.GA5063@infradead.org> (raw)
In-Reply-To: <20170927045046.22238-3-jsmart2021@gmail.com>
> changed = nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_LIVE);
> - WARN_ON_ONCE(!changed);
>
> ctrl->ctrl.nr_reconnects = 0;
>
> - nvme_start_ctrl(&ctrl->ctrl);
> + if (changed)
> + nvme_start_ctrl(&ctrl->ctrl);
It's just cosmetic, but can you folow the RDMA pattern here:
changed = nvme_change_ctrl_state(&ctrl->ctrl, NVME_CTRL_LIVE);
if (!changed) {
/* state change failure is ok if we're in DELETING state */
WARN_ON_ONCE(ctrl->ctrl.state != NVME_CTRL_DELETING);
return;
}
else the patch looks fine:
Reviewed-by: Christoph Hellwig <hch at lst.de>
next prev parent reply other threads:[~2017-10-05 7:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 4:50 [PATCH v2 0/7] nvme_fc: add dev_loss_tmo support James Smart
2017-09-27 4:50 ` [PATCH v2 1/7] nvme core: allow controller RESETTING to RECONNECTING transition James Smart
2017-10-04 8:28 ` Christoph Hellwig
2017-10-11 10:02 ` Sagi Grimberg
2017-09-27 4:50 ` [PATCH v2 2/7] nvme_fc: change ctlr state assignments during reset/reconnect James Smart
2017-10-05 7:57 ` Christoph Hellwig [this message]
2017-10-07 15:53 ` James Smart
2017-10-11 10:07 ` Sagi Grimberg
2017-10-11 14:29 ` James Smart
2017-09-27 4:50 ` [PATCH v2 3/7] nvme_fc: add a dev_loss_tmo field to the remoteport James Smart
2017-10-11 10:11 ` Sagi Grimberg
2017-10-11 14:35 ` James Smart
2017-09-27 4:50 ` [PATCH v2 4/7] nvme_fc: add dev_loss_tmo to controller James Smart
2017-10-05 8:00 ` Christoph Hellwig
2017-10-07 16:08 ` James Smart
2017-10-11 10:17 ` Sagi Grimberg
2017-10-11 15:10 ` James Smart
2017-10-11 10:14 ` Sagi Grimberg
2017-09-27 4:50 ` [PATCH v2 5/7] nvme_fc: check connectivity before initiating reconnects James Smart
2017-10-05 8:01 ` Christoph Hellwig
2017-09-27 4:50 ` [PATCH v2 6/7] nvme_fc: move remote port get/put/free location James Smart
2017-10-05 8:03 ` Christoph Hellwig
2017-10-11 10:18 ` Sagi Grimberg
2017-09-27 4:50 ` [PATCH v2 7/7] nvme_fc: add dev_loss_tmo timeout and remoteport resume support James Smart
2017-10-11 10:29 ` Sagi Grimberg
2017-10-11 14:52 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005075730.GA5063@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.