From: Jesper Dangaard Brouer <brouer@redhat.com>
To: baloo@gandi.net
Cc: lvs-devel@vger.kernel.org, Julian Anastasov <ja@ssi.bg>,
Simon Horman <horms@verge.net.au>,
brouer@redhat.com
Subject: Re: [PATCH] libipvs: discrepancy with libnl genlmsg_put
Date: Thu, 5 Oct 2017 12:03:33 +0200 [thread overview]
Message-ID: <20171005120333.3de32b15@redhat.com> (raw)
In-Reply-To: <20170927153105.7222-1-baloo@gandi.net>
On Wed, 27 Sep 2017 15:31:05 +0000
baloo@gandi.net wrote:
> From: Arthur Gautier <baloo@gandi.net>
>
> There is a mixup between NL_AUTO_PORT and NL_AUTO_PID. The
> first should be used with genlmsg_put while the second with
> nlmsg_put.
>
> This is not a problem, because both NL_AUTO_PORT and NL_AUTO_PID
> have the same value, but still a discrepancy with libnl documentation.
>
> see documentation of genlmsg_put here:
> http://www.infradead.org/~tgr/libnl/doc/api/group__genl.html#ga9a86a71bbba6961d41b8a75f62f9e946
>
> Cc: Julian Anastasov <ja@ssi.bg>
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Jesper Dangaard Brouer <brouer@redhat.com>
> Signed-off-by: Arthur Gautier <baloo@gandi.net>
> ---
Applied this here:
https://git.kernel.org/pub/scm/utils/kernel/ipvsadm/ipvsadm.git/commit/?id=76c12701481
Thank you Arthur for bringing this discrepancy in-order :-)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2017-10-05 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 15:31 [PATCH] libipvs: discrepancy with libnl genlmsg_put baloo
2017-10-05 10:03 ` Jesper Dangaard Brouer [this message]
2017-10-05 17:20 ` Arthur Gautier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005120333.3de32b15@redhat.com \
--to=brouer@redhat.com \
--cc=baloo@gandi.net \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.