[PATCH] libipvs: discrepancy with libnl genlmsg_put

[PATCH] libipvs: discrepancy with libnl genlmsg_put

[baloo]

From: Arthur Gautier <baloo@gandi.net>

There is a mixup between NL_AUTO_PORT and NL_AUTO_PID. The
first should be used with genlmsg_put while the second with
nlmsg_put.

This is not a problem, because both NL_AUTO_PORT and NL_AUTO_PID
have the same value, but still a discrepancy with libnl documentation.

see documentation of genlmsg_put here:
  http://www.infradead.org/~tgr/libnl/doc/api/group__genl.html#ga9a86a71bbba6961d41b8a75f62f9e946

Cc: Julian Anastasov <ja@ssi.bg>
Cc: Simon Horman <horms@verge.net.au>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Arthur Gautier <baloo@gandi.net>
---
 libipvs/libipvs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libipvs/libipvs.c b/libipvs/libipvs.c
index d271c48e36faa..a8432431fbbf6 100644
--- a/libipvs/libipvs.c
+++ b/libipvs/libipvs.c
@@ -63,7 +63,7 @@ struct nl_msg *ipvs_nl_message(int cmd, int flags)
 	if (!msg)
 		return NULL;
 
-	genlmsg_put(msg, NL_AUTO_PID, NL_AUTO_SEQ, family, 0, flags,
+	genlmsg_put(msg, NL_AUTO_PORT, NL_AUTO_SEQ, family, 0, flags,
 		    cmd, IPVS_GENL_VERSION);
 
 	return msg;
-- 
2.14.1

Re: [PATCH] libipvs: discrepancy with libnl genlmsg_put

[Jesper Dangaard Brouer]

On Wed, 27 Sep 2017 15:31:05 +0000
baloo@gandi.net wrote:

> From: Arthur Gautier <baloo@gandi.net>
> 
> There is a mixup between NL_AUTO_PORT and NL_AUTO_PID. The
> first should be used with genlmsg_put while the second with
> nlmsg_put.
> 
> This is not a problem, because both NL_AUTO_PORT and NL_AUTO_PID
> have the same value, but still a discrepancy with libnl documentation.
> 
> see documentation of genlmsg_put here:
>   http://www.infradead.org/~tgr/libnl/doc/api/group__genl.html#ga9a86a71bbba6961d41b8a75f62f9e946
> 
> Cc: Julian Anastasov <ja@ssi.bg>
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Jesper Dangaard Brouer <brouer@redhat.com>
> Signed-off-by: Arthur Gautier <baloo@gandi.net>
> ---

Applied this here:
 https://git.kernel.org/pub/scm/utils/kernel/ipvsadm/ipvsadm.git/commit/?id=76c12701481

Thank you Arthur for bringing this discrepancy in-order :-)
-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer

Re: [PATCH] libipvs: discrepancy with libnl genlmsg_put

[Arthur Gautier]

On Thu, Oct 05, 2017 at 12:03:33PM +0200, Jesper Dangaard Brouer wrote:
> On Wed, 27 Sep 2017 15:31:05 +0000
> baloo@gandi.net wrote:
> 
> > From: Arthur Gautier <baloo@gandi.net>
> > 
> > There is a mixup between NL_AUTO_PORT and NL_AUTO_PID. The
> > first should be used with genlmsg_put while the second with
> > nlmsg_put.
> > 
> > This is not a problem, because both NL_AUTO_PORT and NL_AUTO_PID
> > have the same value, but still a discrepancy with libnl documentation.
> > 
> > see documentation of genlmsg_put here:
> >   http://www.infradead.org/~tgr/libnl/doc/api/group__genl.html#ga9a86a71bbba6961d41b8a75f62f9e946
> > 
> > Cc: Julian Anastasov <ja@ssi.bg>
> > Cc: Simon Horman <horms@verge.net.au>
> > Cc: Jesper Dangaard Brouer <brouer@redhat.com>
> > Signed-off-by: Arthur Gautier <baloo@gandi.net>
> > ---
> 
> Applied this here:
>  https://git.kernel.org/pub/scm/utils/kernel/ipvsadm/ipvsadm.git/commit/?id=76c12701481
> 
> Thank you Arthur for bringing this discrepancy in-order :-)

My OCD says thank you.

-- 
\o/ Arthur
 G  Gandi.net