From: Dan Carpenter <dan.carpenter@oracle.com>
To: Srinivasan Shanmugam <srinivasan.rns@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: rtl8723bs: Externs should be avoided in .C file
Date: Thu, 5 Oct 2017 15:43:33 +0300 [thread overview]
Message-ID: <20171005124333.z2msohwvyjicmikj@mwanda> (raw)
In-Reply-To: <1507149242-3269-1-git-send-email-srinivasan.rns@gmail.com>
On Wed, Oct 04, 2017 at 10:34:02PM +0200, Srinivasan Shanmugam wrote:
> Removed all the unnecessary extern from rtl8723bs
>
The patch is good but doesn't match the description.
regards,
dan carpenter
prev parent reply other threads:[~2017-10-05 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 20:34 [PATCH 2/2] Staging: rtl8723bs: Externs should be avoided in .C file Srinivasan Shanmugam
2017-10-05 12:43 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005124333.z2msohwvyjicmikj@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivasan.rns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.