From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Robert Jarzmik <robert.jarzmik@free.fr>,
arm@kernel.org
Subject: Re: [PATCH] ARM: pxa: cm-x255: Fix up GPIO NAND device name in table
Date: Sat, 7 Oct 2017 07:49:39 +0200 [thread overview]
Message-ID: <20171007074939.516ae693@bbrezillon> (raw)
In-Reply-To: <20171006215144.18039-1-linus.walleij@linaro.org>
On Fri, 6 Oct 2017 23:51:44 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:
> My patch set the device name wrong because I confused the
> device name for a partition name. Sorry.
>
> Cc: arm@kernel.org
> Fixes: ("mtd: nand: gpio: Convert to use GPIO descriptors")
> Reported-by: Robert Jarzmik <robert.jarzmik@free.fr>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> This can be squashed into the commit or applied on top
> as a fix. The original patch was ACKed by the ARM SoC
> maintainers so I believe this is fine to apply.
> ---
> arch/arm/mach-pxa/cm-x255.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-pxa/cm-x255.c b/arch/arm/mach-pxa/cm-x255.c
> index f8d67acb7194..fa8e7dd4d898 100644
> --- a/arch/arm/mach-pxa/cm-x255.c
> +++ b/arch/arm/mach-pxa/cm-x255.c
> @@ -178,7 +178,7 @@ static inline void cmx255_init_nor(void) {}
> #if defined(CONFIG_MTD_NAND_GPIO) || defined(CONFIG_MTD_NAND_GPIO_MODULE)
>
> static struct gpiod_lookup_table cmx255_nand_gpiod_table = {
> - .dev_id = "cmx255-nand",
> + .dev_id = "gpio-nand",
Are you sure it works? AFAIR, you have to set "<driver-name>.<dev-id>"
here, which, assuming there's only one gpio-nand dev, would give
.dev_id = "gpio-nand.0",
Regards,
Boris
> .table = {
> GPIO_LOOKUP("gpio-pxa", GPIO_NAND_CS, "nce", GPIO_ACTIVE_HIGH),
> GPIO_LOOKUP("gpio-pxa", GPIO_NAND_CLE, "cle", GPIO_ACTIVE_HIGH),
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pxa: cm-x255: Fix up GPIO NAND device name in table
Date: Sat, 7 Oct 2017 07:49:39 +0200 [thread overview]
Message-ID: <20171007074939.516ae693@bbrezillon> (raw)
In-Reply-To: <20171006215144.18039-1-linus.walleij@linaro.org>
On Fri, 6 Oct 2017 23:51:44 +0200
Linus Walleij <linus.walleij@linaro.org> wrote:
> My patch set the device name wrong because I confused the
> device name for a partition name. Sorry.
>
> Cc: arm at kernel.org
> Fixes: ("mtd: nand: gpio: Convert to use GPIO descriptors")
> Reported-by: Robert Jarzmik <robert.jarzmik@free.fr>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> This can be squashed into the commit or applied on top
> as a fix. The original patch was ACKed by the ARM SoC
> maintainers so I believe this is fine to apply.
> ---
> arch/arm/mach-pxa/cm-x255.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-pxa/cm-x255.c b/arch/arm/mach-pxa/cm-x255.c
> index f8d67acb7194..fa8e7dd4d898 100644
> --- a/arch/arm/mach-pxa/cm-x255.c
> +++ b/arch/arm/mach-pxa/cm-x255.c
> @@ -178,7 +178,7 @@ static inline void cmx255_init_nor(void) {}
> #if defined(CONFIG_MTD_NAND_GPIO) || defined(CONFIG_MTD_NAND_GPIO_MODULE)
>
> static struct gpiod_lookup_table cmx255_nand_gpiod_table = {
> - .dev_id = "cmx255-nand",
> + .dev_id = "gpio-nand",
Are you sure it works? AFAIR, you have to set "<driver-name>.<dev-id>"
here, which, assuming there's only one gpio-nand dev, would give
.dev_id = "gpio-nand.0",
Regards,
Boris
> .table = {
> GPIO_LOOKUP("gpio-pxa", GPIO_NAND_CS, "nce", GPIO_ACTIVE_HIGH),
> GPIO_LOOKUP("gpio-pxa", GPIO_NAND_CLE, "cle", GPIO_ACTIVE_HIGH),
next prev parent reply other threads:[~2017-10-07 5:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 21:51 [PATCH] ARM: pxa: cm-x255: Fix up GPIO NAND device name in table Linus Walleij
2017-10-06 21:51 ` Linus Walleij
2017-10-07 5:49 ` Boris Brezillon [this message]
2017-10-07 5:49 ` Boris Brezillon
2017-10-07 8:00 ` Robert Jarzmik
2017-10-07 8:00 ` Robert Jarzmik
2017-10-07 9:22 ` Boris Brezillon
2017-10-07 9:22 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171007074939.516ae693@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=arm@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.