From: Will Deacon <will.deacon@arm.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org, Ley Foon Tan <lftan@altera.com>,
linux-kernel@vger.kernel.org, nios2-dev@lists.rocketboards.org,
Catalin Marinas <catalin.marinas@arm.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] kbuild: fix dependency of dtbs targets
Date: Mon, 9 Oct 2017 15:55:59 +0100 [thread overview]
Message-ID: <20171009145558.GC28164@arm.com> (raw)
In-Reply-To: <1507091240-12756-1-git-send-email-yamada.masahiro@socionext.com>
On Wed, Oct 04, 2017 at 01:27:20PM +0900, Masahiro Yamada wrote:
> The target "dtbs" should depend on "scripts" because it needs to
> build dtc. The "prepare" target is unneeded here.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/arm/Makefile | 2 +-
> arch/arm64/Makefile | 2 +-
> arch/nios2/Makefile | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 47d3a1a..cdb5b55 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -342,7 +342,7 @@ $(INSTALL_TARGETS):
>
> PHONY += dtbs dtbs_install
>
> -dtbs: prepare scripts
> +dtbs: scripts
> $(Q)$(MAKE) $(build)=$(boot)/dts
>
> dtbs_install:
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index 939b310..fd56fbc 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -133,7 +133,7 @@ zinstall install:
>
> PHONY += dtbs dtbs_install
>
> -dtbs: prepare scripts
> +dtbs: scripts
> $(Q)$(MAKE) $(build)=$(boot)/dts
>
> dtbs_install:
I think this is ok, although I was initially nervous about the possibility
of the archprepare step having interactions with the dt-bindings headers.
That doesn't appear to be the case, so for arm64:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] kbuild: fix dependency of dtbs targets
Date: Mon, 9 Oct 2017 15:55:59 +0100 [thread overview]
Message-ID: <20171009145558.GC28164@arm.com> (raw)
In-Reply-To: <1507091240-12756-1-git-send-email-yamada.masahiro@socionext.com>
On Wed, Oct 04, 2017 at 01:27:20PM +0900, Masahiro Yamada wrote:
> The target "dtbs" should depend on "scripts" because it needs to
> build dtc. The "prepare" target is unneeded here.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/arm/Makefile | 2 +-
> arch/arm64/Makefile | 2 +-
> arch/nios2/Makefile | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 47d3a1a..cdb5b55 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -342,7 +342,7 @@ $(INSTALL_TARGETS):
>
> PHONY += dtbs dtbs_install
>
> -dtbs: prepare scripts
> +dtbs: scripts
> $(Q)$(MAKE) $(build)=$(boot)/dts
>
> dtbs_install:
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index 939b310..fd56fbc 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -133,7 +133,7 @@ zinstall install:
>
> PHONY += dtbs dtbs_install
>
> -dtbs: prepare scripts
> +dtbs: scripts
> $(Q)$(MAKE) $(build)=$(boot)/dts
>
> dtbs_install:
I think this is ok, although I was initially nervous about the possibility
of the archprepare step having interactions with the dt-bindings headers.
That doesn't appear to be the case, so for arm64:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2017-10-09 14:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 4:27 [PATCH] kbuild: fix dependency of dtbs targets Masahiro Yamada
2017-10-04 4:27 ` Masahiro Yamada
2017-10-09 14:55 ` Will Deacon [this message]
2017-10-09 14:55 ` Will Deacon
2017-10-09 15:05 ` Russell King - ARM Linux
2017-10-09 15:05 ` Russell King - ARM Linux
2017-10-25 5:40 ` Masahiro Yamada
2017-10-25 5:40 ` Masahiro Yamada
2017-12-13 21:31 ` Rob Herring
2017-12-13 21:31 ` Rob Herring
2017-12-16 3:05 ` Masahiro Yamada
2017-12-16 3:05 ` Masahiro Yamada
2017-10-12 1:01 ` Masahiro Yamada
2017-10-12 1:01 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009145558.GC28164@arm.com \
--to=will.deacon@arm.com \
--cc=catalin.marinas@arm.com \
--cc=lftan@altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nios2-dev@lists.rocketboards.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.