* [PATCH] Bluetooth: avoid silent hci_bcm ACPI PM regression
@ 2017-10-10 8:01 ` Johan Hovold
0 siblings, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2017-10-10 8:01 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Gustavo Padovan, Johan Hedberg,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA, Sebastian Reichel,
Frédéric Danis, robh-DgEjT+Ai2ygdnm+yROfE0A,
loic.poulain-Re5JQEeQqe8AvxtiuMwx3w, lukas-JFq808J9C/izQB+pC5nmwQ,
hdegoede-H+wXaHxf7aLQT0dZR+AlfA,
linux-serial-u79uwXL29TY76Z2rM5mHXA,
linux-acpi-u79uwXL29TY76Z2rM5mHXA, Johan Hovold
The hci_bcm platform-device hack which was used to implement
power management for ACPI devices is being replaced by a
serial-device-bus implementation.
Unfortunately, when the corresponding change to the ACPI code lands (a
change that will stop enumerating and registering the serial-device-node
child as a platform device) PM will break silently unless serdev
TTY-port controller support has been enabled. Specifically, hciattach
(btattach) would still succeed, but power management would no longer
work.
Although this is strictly a runtime dependency, let's make the driver
depend on SERIAL_DEV_CTRL_TTYPORT, which is the particular serdev
controller implementation used by the ACPI devices currently managed by
this driver, to avoid breaking PM without anyone noticing.
Note that the driver already has a (build-time) dependency on the serdev
bus code.
Signed-off-by: Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
drivers/bluetooth/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index fae5a74dc737..082e1c7329de 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -169,6 +169,7 @@ config BT_HCIUART_BCM
bool "Broadcom protocol support"
depends on BT_HCIUART
depends on BT_HCIUART_SERDEV
+ depends on (!ACPI || SERIAL_DEV_CTRL_TTYPORT)
select BT_HCIUART_H4
select BT_BCM
help
--
2.14.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] Bluetooth: avoid silent hci_bcm ACPI PM regression
@ 2017-10-10 8:01 ` Johan Hovold
0 siblings, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2017-10-10 8:01 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Gustavo Padovan, Johan Hedberg, linux-bluetooth,
Sebastian Reichel, Frédéric Danis, robh, loic.poulain,
lukas, hdegoede, linux-serial, linux-acpi, Johan Hovold
The hci_bcm platform-device hack which was used to implement
power management for ACPI devices is being replaced by a
serial-device-bus implementation.
Unfortunately, when the corresponding change to the ACPI code lands (a
change that will stop enumerating and registering the serial-device-node
child as a platform device) PM will break silently unless serdev
TTY-port controller support has been enabled. Specifically, hciattach
(btattach) would still succeed, but power management would no longer
work.
Although this is strictly a runtime dependency, let's make the driver
depend on SERIAL_DEV_CTRL_TTYPORT, which is the particular serdev
controller implementation used by the ACPI devices currently managed by
this driver, to avoid breaking PM without anyone noticing.
Note that the driver already has a (build-time) dependency on the serdev
bus code.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/bluetooth/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index fae5a74dc737..082e1c7329de 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -169,6 +169,7 @@ config BT_HCIUART_BCM
bool "Broadcom protocol support"
depends on BT_HCIUART
depends on BT_HCIUART_SERDEV
+ depends on (!ACPI || SERIAL_DEV_CTRL_TTYPORT)
select BT_HCIUART_H4
select BT_BCM
help
--
2.14.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: avoid silent hci_bcm ACPI PM regression
2017-10-10 8:01 ` Johan Hovold
(?)
@ 2017-10-10 8:07 ` Marcel Holtmann
-1 siblings, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2017-10-10 8:07 UTC (permalink / raw)
To: Johan Hovold
Cc: Gustavo F. Padovan, Johan Hedberg,
bluez mailin list (linux-bluetooth@vger.kernel.org),
Sebastian Reichel, Frédéric Danis, Rob Herring,
Loic Poulain, Lukas Wunner, Hans de Goede, linux-serial,
linux-acpi
Hi Johan,
> The hci_bcm platform-device hack which was used to implement
> power management for ACPI devices is being replaced by a
> serial-device-bus implementation.
>
> Unfortunately, when the corresponding change to the ACPI code lands (a
> change that will stop enumerating and registering the serial-device-node
> child as a platform device) PM will break silently unless serdev
> TTY-port controller support has been enabled. Specifically, hciattach
> (btattach) would still succeed, but power management would no longer
> work.
>
> Although this is strictly a runtime dependency, let's make the driver
> depend on SERIAL_DEV_CTRL_TTYPORT, which is the particular serdev
> controller implementation used by the ACPI devices currently managed by
> this driver, to avoid breaking PM without anyone noticing.
>
> Note that the driver already has a (build-time) dependency on the serdev
> bus code.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/bluetooth/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-10 8:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-10 8:01 [PATCH] Bluetooth: avoid silent hci_bcm ACPI PM regression Johan Hovold
2017-10-10 8:01 ` Johan Hovold
2017-10-10 8:07 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.