From: Minchan Kim <minchan@kernel.org>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>, Shaohua Li <shli@kernel.org>,
Hugh Dickins <hughd@google.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Tim Chen <tim.c.chen@intel.com>,
Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH -mm] mm, swap: Use page-cluster as max window of VMA based swap readahead
Date: Tue, 10 Oct 2017 17:55:24 +0900 [thread overview]
Message-ID: <20171010085524.GA16752@bbox> (raw)
In-Reply-To: <87r2ubo08t.fsf@yhuang-dev.intel.com>
On Tue, Oct 10, 2017 at 04:50:10PM +0800, Huang, Ying wrote:
> Minchan Kim <minchan@kernel.org> writes:
>
> > On Tue, Oct 10, 2017 at 02:08:55PM +0800, Huang, Ying wrote:
> >> From: Huang Ying <ying.huang@intel.com>
> >>
> >> When the VMA based swap readahead was introduced, a new knob
> >>
> >> /sys/kernel/mm/swap/vma_ra_max_order
> >>
> >> was added as the max window of VMA swap readahead. This is to make it
> >> possible to use different max window for VMA based readahead and
> >> original physical readahead. But Minchan Kim pointed out that this
> >> will cause a regression because setting page-cluster sysctl to zero
> >> cannot disable swap readahead with the change.
> >>
> >> To fix the regression, the page-cluster sysctl is used as the max
> >> window of both the VMA based swap readahead and original physical swap
> >> readahead. If more fine grained control is needed in the future, more
> >> knobs can be added as the subordinate knobs of the page-cluster
> >> sysctl.
> >>
> >> The vma_ra_max_order knob is deleted. Because the knob was
> >> introduced in v4.14-rc1, and this patch is targeting being merged
> >> before v4.14 releasing, there should be no existing users of this
> >> newly added ABI.
> >>
> >> Cc: Johannes Weiner <hannes@cmpxchg.org>
> >> Cc: Rik van Riel <riel@redhat.com>
> >> Cc: Shaohua Li <shli@kernel.org>
> >> Cc: Hugh Dickins <hughd@google.com>
> >> Cc: Fengguang Wu <fengguang.wu@intel.com>
> >> Cc: Tim Chen <tim.c.chen@intel.com>
> >> Cc: Dave Hansen <dave.hansen@intel.com>
> >> Reported-by: Minchan Kim <minchan@kernel.org>
> >
> > It seems your script is Ccing only with Cc: tag, not other tags.
> > Fix it so any participant of topic can get the mail.
>
> I just used `git send-email`, no other scripts. We need to fix `git send-email`?
You can do it via cccmd.
Just a reference:
~/bin/kcccmd
sed -nre 's/^(Acked|Reviewed|Reported|Tested|Suggested)-by: //p' "$1"
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>, Shaohua Li <shli@kernel.org>,
Hugh Dickins <hughd@google.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Tim Chen <tim.c.chen@intel.com>,
Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH -mm] mm, swap: Use page-cluster as max window of VMA based swap readahead
Date: Tue, 10 Oct 2017 17:55:24 +0900 [thread overview]
Message-ID: <20171010085524.GA16752@bbox> (raw)
In-Reply-To: <87r2ubo08t.fsf@yhuang-dev.intel.com>
On Tue, Oct 10, 2017 at 04:50:10PM +0800, Huang, Ying wrote:
> Minchan Kim <minchan@kernel.org> writes:
>
> > On Tue, Oct 10, 2017 at 02:08:55PM +0800, Huang, Ying wrote:
> >> From: Huang Ying <ying.huang@intel.com>
> >>
> >> When the VMA based swap readahead was introduced, a new knob
> >>
> >> /sys/kernel/mm/swap/vma_ra_max_order
> >>
> >> was added as the max window of VMA swap readahead. This is to make it
> >> possible to use different max window for VMA based readahead and
> >> original physical readahead. But Minchan Kim pointed out that this
> >> will cause a regression because setting page-cluster sysctl to zero
> >> cannot disable swap readahead with the change.
> >>
> >> To fix the regression, the page-cluster sysctl is used as the max
> >> window of both the VMA based swap readahead and original physical swap
> >> readahead. If more fine grained control is needed in the future, more
> >> knobs can be added as the subordinate knobs of the page-cluster
> >> sysctl.
> >>
> >> The vma_ra_max_order knob is deleted. Because the knob was
> >> introduced in v4.14-rc1, and this patch is targeting being merged
> >> before v4.14 releasing, there should be no existing users of this
> >> newly added ABI.
> >>
> >> Cc: Johannes Weiner <hannes@cmpxchg.org>
> >> Cc: Rik van Riel <riel@redhat.com>
> >> Cc: Shaohua Li <shli@kernel.org>
> >> Cc: Hugh Dickins <hughd@google.com>
> >> Cc: Fengguang Wu <fengguang.wu@intel.com>
> >> Cc: Tim Chen <tim.c.chen@intel.com>
> >> Cc: Dave Hansen <dave.hansen@intel.com>
> >> Reported-by: Minchan Kim <minchan@kernel.org>
> >
> > It seems your script is Ccing only with Cc: tag, not other tags.
> > Fix it so any participant of topic can get the mail.
>
> I just used `git send-email`, no other scripts. We need to fix `git send-email`?
You can do it via cccmd.
Just a reference:
~/bin/kcccmd
sed -nre 's/^(Acked|Reviewed|Reported|Tested|Suggested)-by: //p' "$1"
next prev parent reply other threads:[~2017-10-10 8:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 6:08 [PATCH -mm] mm, swap: Use page-cluster as max window of VMA based swap readahead Huang, Ying
2017-10-10 6:08 ` Huang, Ying
2017-10-10 8:20 ` Minchan Kim
2017-10-10 8:20 ` Minchan Kim
2017-10-10 8:50 ` Huang, Ying
2017-10-10 8:50 ` Huang, Ying
2017-10-10 8:55 ` Minchan Kim [this message]
2017-10-10 8:55 ` Minchan Kim
2017-10-11 1:11 ` Huang, Ying
2017-10-11 1:11 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010085524.GA16752@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
--cc=tim.c.chen@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.