From: Eduardo Habkost <ehabkost@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Michael Tokarev <mjt@tls.msk.ru>,
"Michael S . Tsirkin" <mst@redhat.com>,
Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [Qemu-trivial] [PATCH] pc: remove useless hot_add_cpu initialisation
Date: Tue, 10 Oct 2017 13:00:15 -0300 [thread overview]
Message-ID: <20171010160015.GF3246@localhost.localdomain> (raw)
In-Reply-To: <20171010133241.11330-1-lvivier@redhat.com>
On Tue, Oct 10, 2017 at 03:32:41PM +0200, Laurent Vivier wrote:
> Since 4458fb3a79 (pc: Eliminate pc_default_machine_options()),
> hot_add_cpu is set in pc_machine_class_init(), so we don't
> need to set it in pc_q35_machine_options(), pc_i440fx_machine_options()
> and xenfv_machine_options(), except to clear it in
> pc_i440fx_1_4_machine_opt().
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Michael Tokarev <mjt@tls.msk.ru>,
"Michael S . Tsirkin" <mst@redhat.com>,
Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [Qemu-devel] [PATCH] pc: remove useless hot_add_cpu initialisation
Date: Tue, 10 Oct 2017 13:00:15 -0300 [thread overview]
Message-ID: <20171010160015.GF3246@localhost.localdomain> (raw)
In-Reply-To: <20171010133241.11330-1-lvivier@redhat.com>
On Tue, Oct 10, 2017 at 03:32:41PM +0200, Laurent Vivier wrote:
> Since 4458fb3a79 (pc: Eliminate pc_default_machine_options()),
> hot_add_cpu is set in pc_machine_class_init(), so we don't
> need to set it in pc_q35_machine_options(), pc_i440fx_machine_options()
> and xenfv_machine_options(), except to clear it in
> pc_i440fx_1_4_machine_opt().
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
next prev parent reply other threads:[~2017-10-10 16:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 13:32 [Qemu-trivial] [PATCH] pc: remove useless hot_add_cpu initialisation Laurent Vivier
2017-10-10 13:32 ` [Qemu-devel] " Laurent Vivier
2017-10-10 14:12 ` [Qemu-trivial] " Igor Mammedov
2017-10-10 14:12 ` Igor Mammedov
2017-10-10 16:00 ` Eduardo Habkost [this message]
2017-10-10 16:00 ` Eduardo Habkost
2017-10-11 16:15 ` [Qemu-trivial] " Anthony PERARD
2017-10-11 16:15 ` [Qemu-devel] " Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010160015.GF3246@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=lvivier@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.