All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tobin C. Harding" <me@tobin.cc>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>,
	KVM list <kvm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Tycho Andersen <tycho@docker.com>,
	"Roberts, William C" <william.c.roberts@intel.com>,
	Tejun Heo <tj@kernel.org>,
	Jordan Glover <Golden_Miller83@protonmail.ch>,
	Greg KH <gregkh@linuxfoundation.org>,
	Petr Mladek <pmladek@suse.com>, Joe Perches <joe@perches.com>,
	Ian Campbell <ijc@hellion.org.uk>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Chris Fries <cfries@google.com>,
	Dave Weinstein <olorin@google.com>,
	Daniel Micay <danielmicay@gmail.com>,
	Djalal Harouni <tixxdz@gmail.com>
Subject: [kernel-hardening] Re: [PATCH 0/3] add %pX specifier
Date: Wed, 11 Oct 2017 10:31:16 +1100	[thread overview]
Message-ID: <20171010233116.GA2049@eros> (raw)
In-Reply-To: <CA+55aFyH5X2nx0kf_hPeOjMQYF-UX6r3ov61=VqTOLLZLE3-vQ@mail.gmail.com>

On Tue, Oct 10, 2017 at 04:16:55PM -0700, Linus Torvalds wrote:
> On Tue, Oct 10, 2017 at 4:09 PM, Tobin C. Harding <me@tobin.cc> wrote:
> >
> > This patch is a softer version of Linus' suggestion because it does not change the behaviour of the
> > %p specifier. I don't see the benefit in making such a breaking change without addressing the issue
> > of %x (and I don't the balls to right now).
> 
> The thing is, this continues to have the exact same issue that %pK has
> - because it is opt-in, effectively nobody will actually use it.
> 
> That's why I would suggest that if we do this way, we really change %p
> and %pa to use the hashed value, to convert *everybody*. And then
> people who have a good reason to actually expose the pointer have to
> do the extra work and opt out.
> 
>                   Linus

Righto, I'll wait 24 hours and submit v2 with the change as suggested. I guess now is as good a time
as any annoy everybody and cause them to do work (for the greater good :)

Then I can direct effort at finding any users of %x for kernel addresses.

thanks,
Tobin.

WARNING: multiple messages have this Message-ID (diff)
From: "Tobin C. Harding" <me@tobin.cc>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>,
	KVM list <kvm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Tycho Andersen <tycho@docker.com>,
	"Roberts, William C" <william.c.roberts@intel.com>,
	Tejun Heo <tj@kernel.org>,
	Jordan Glover <Golden_Miller83@protonmail.ch>,
	Greg KH <gregkh@linuxfoundation.org>,
	Petr Mladek <pmladek@suse.com>, Joe Perches <joe@perches.com>,
	Ian Campbell <ijc@hellion.org.uk>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Chris Fries <cfries@google.com>,
	Dave Weinstein
Subject: Re: [PATCH 0/3] add %pX specifier
Date: Wed, 11 Oct 2017 10:31:16 +1100	[thread overview]
Message-ID: <20171010233116.GA2049@eros> (raw)
In-Reply-To: <CA+55aFyH5X2nx0kf_hPeOjMQYF-UX6r3ov61=VqTOLLZLE3-vQ@mail.gmail.com>

On Tue, Oct 10, 2017 at 04:16:55PM -0700, Linus Torvalds wrote:
> On Tue, Oct 10, 2017 at 4:09 PM, Tobin C. Harding <me@tobin.cc> wrote:
> >
> > This patch is a softer version of Linus' suggestion because it does not change the behaviour of the
> > %p specifier. I don't see the benefit in making such a breaking change without addressing the issue
> > of %x (and I don't the balls to right now).
> 
> The thing is, this continues to have the exact same issue that %pK has
> - because it is opt-in, effectively nobody will actually use it.
> 
> That's why I would suggest that if we do this way, we really change %p
> and %pa to use the hashed value, to convert *everybody*. And then
> people who have a good reason to actually expose the pointer have to
> do the extra work and opt out.
> 
>                   Linus

Righto, I'll wait 24 hours and submit v2 with the change as suggested. I guess now is as good a time
as any annoy everybody and cause them to do work (for the greater good :)

Then I can direct effort at finding any users of %x for kernel addresses.

thanks,
Tobin.

WARNING: multiple messages have this Message-ID (diff)
From: "Tobin C. Harding" <me@tobin.cc>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "kernel-hardening@lists.openwall.com" 
	<kernel-hardening@lists.openwall.com>,
	KVM list <kvm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Tycho Andersen <tycho@docker.com>,
	"Roberts, William C" <william.c.roberts@intel.com>,
	Tejun Heo <tj@kernel.org>,
	Jordan Glover <Golden_Miller83@protonmail.ch>,
	Greg KH <gregkh@linuxfoundation.org>,
	Petr Mladek <pmladek@suse.com>, Joe Perches <joe@perches.com>,
	Ian Campbell <ijc@hellion.org.uk>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Chris Fries <cfries@google.com>,
	Dave Weinstein <olorin@google.com>,
	Daniel Micay <danielmicay@gmail.com>,
	Djalal Harouni <tixxdz@gmail.com>
Subject: Re: [PATCH 0/3] add %pX specifier
Date: Wed, 11 Oct 2017 10:31:16 +1100	[thread overview]
Message-ID: <20171010233116.GA2049@eros> (raw)
In-Reply-To: <CA+55aFyH5X2nx0kf_hPeOjMQYF-UX6r3ov61=VqTOLLZLE3-vQ@mail.gmail.com>

On Tue, Oct 10, 2017 at 04:16:55PM -0700, Linus Torvalds wrote:
> On Tue, Oct 10, 2017 at 4:09 PM, Tobin C. Harding <me@tobin.cc> wrote:
> >
> > This patch is a softer version of Linus' suggestion because it does not change the behaviour of the
> > %p specifier. I don't see the benefit in making such a breaking change without addressing the issue
> > of %x (and I don't the balls to right now).
> 
> The thing is, this continues to have the exact same issue that %pK has
> - because it is opt-in, effectively nobody will actually use it.
> 
> That's why I would suggest that if we do this way, we really change %p
> and %pa to use the hashed value, to convert *everybody*. And then
> people who have a good reason to actually expose the pointer have to
> do the extra work and opt out.
> 
>                   Linus

Righto, I'll wait 24 hours and submit v2 with the change as suggested. I guess now is as good a time
as any annoy everybody and cause them to do work (for the greater good :)

Then I can direct effort at finding any users of %x for kernel addresses.

thanks,
Tobin.

  reply	other threads:[~2017-10-10 23:31 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10 23:09 [kernel-hardening] [PATCH 0/3] add %pX specifier Tobin C. Harding
2017-10-10 23:09 ` Tobin C. Harding
2017-10-10 23:09 ` Tobin C. Harding
2017-10-10 23:15 ` [kernel-hardening] " Linus Torvalds
2017-10-10 23:15   ` Linus Torvalds
2017-10-10 23:15   ` Linus Torvalds
2017-10-10 23:32   ` [kernel-hardening] " Tobin C. Harding
2017-10-10 23:32     ` Tobin C. Harding
2017-10-10 23:32     ` Tobin C. Harding
2017-10-11  3:27     ` [kernel-hardening] " Joe Perches
2017-10-11  3:27       ` Joe Perches
2017-10-11  3:27       ` Joe Perches
2017-10-11 20:11   ` [kernel-hardening] " Jason A. Donenfeld
2017-10-11 20:11     ` Jason A. Donenfeld
2017-10-11 20:11     ` Jason A. Donenfeld
2017-10-11 21:29     ` [kernel-hardening] " Linus Torvalds
2017-10-11 21:29       ` Linus Torvalds
2017-10-11 21:29       ` Linus Torvalds
2017-10-11 22:11       ` [kernel-hardening] " Jason A. Donenfeld
2017-10-11 22:11         ` Jason A. Donenfeld
2017-10-11 22:11         ` Jason A. Donenfeld
2017-10-12 18:37         ` [kernel-hardening] " Linus Torvalds
2017-10-12 18:37           ` Linus Torvalds
2017-10-12 18:37           ` Linus Torvalds
2017-10-10 23:16 ` [kernel-hardening] " Linus Torvalds
2017-10-10 23:16   ` Linus Torvalds
2017-10-10 23:16   ` Linus Torvalds
2017-10-10 23:31   ` Tobin C. Harding [this message]
2017-10-10 23:31     ` Tobin C. Harding
2017-10-10 23:31     ` Tobin C. Harding
2017-10-13 17:54   ` [kernel-hardening] " Roberts, William C
2017-10-13 17:54     ` Roberts, William C
2017-10-13 17:54     ` Roberts, William C
2017-10-16  2:09     ` [kernel-hardening] " Tobin Harding
2017-10-16  2:09       ` Tobin Harding
2017-10-11 20:09 ` [kernel-hardening] " Jason A. Donenfeld
2017-10-11 20:09   ` Jason A. Donenfeld
2017-10-11 20:09   ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171010233116.GA2049@eros \
    --to=me@tobin.cc \
    --cc=Golden_Miller83@protonmail.ch \
    --cc=catalin.marinas@arm.com \
    --cc=cfries@google.com \
    --cc=danielmicay@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ijc@hellion.org.uk \
    --cc=joe@perches.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olorin@google.com \
    --cc=pbonzini@redhat.com \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tixxdz@gmail.com \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tycho@docker.com \
    --cc=will.deacon@arm.com \
    --cc=william.c.roberts@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.