* [PATCH] drm/i915/cnl: Symmetric scalers for each pipe
@ 2017-10-09 12:26 Mika Kahola
2017-10-09 14:37 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-10-11 12:43 ` [PATCH] " Ville Syrjälä
0 siblings, 2 replies; 5+ messages in thread
From: Mika Kahola @ 2017-10-09 12:26 UTC (permalink / raw)
To: intel-gfx; +Cc: rodrigo.vivi
For Cannonlake the number of scalers for each pipe is 2. Let's increase
the number of scalers for pipe C.
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
drivers/gpu/drm/i915/intel_device_info.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index 875d428..b2ab6cb 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -347,7 +347,10 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
struct intel_device_info *info = mkwrite_device_info(dev_priv);
enum pipe pipe;
- if (INTEL_GEN(dev_priv) >= 9) {
+ if (IS_CANNONLAKE(dev_priv)) {
+ for_each_pipe(dev_priv, pipe)
+ info->num_scalers[pipe] = 2;
+ } else if (INTEL_GEN(dev_priv) >= 9) {
info->num_scalers[PIPE_A] = 2;
info->num_scalers[PIPE_B] = 2;
info->num_scalers[PIPE_C] = 1;
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✗ Fi.CI.BAT: warning for drm/i915/cnl: Symmetric scalers for each pipe
2017-10-09 12:26 [PATCH] drm/i915/cnl: Symmetric scalers for each pipe Mika Kahola
@ 2017-10-09 14:37 ` Patchwork
2017-10-11 12:43 ` [PATCH] " Ville Syrjälä
1 sibling, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-10-09 14:37 UTC (permalink / raw)
To: Mika Kahola; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/cnl: Symmetric scalers for each pipe
URL : https://patchwork.freedesktop.org/series/31589/
State : warning
== Summary ==
Series 31589v1 drm/i915/cnl: Symmetric scalers for each pipe
https://patchwork.freedesktop.org/api/1.0/series/31589/revisions/1/mbox/
Test chamelium:
Subgroup dp-crc-fast:
pass -> FAIL (fi-kbl-7500u) fdo#102514
Test gem_exec_suspend:
Subgroup basic-s3:
dmesg-warn -> PASS (fi-cfl-s) fdo#103026
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-b-frame-sequence:
pass -> DMESG-WARN (fi-skl-6700k)
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#103026 https://bugs.freedesktop.org/show_bug.cgi?id=103026
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:458s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:473s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:389s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:574s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:284s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:518s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:526s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:541s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:530s
fi-cfl-s total:289 pass:257 dwarn:0 dfail:0 fail:0 skip:32 time:574s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:438s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:597s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:437s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:422s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:501s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:477s
fi-kbl-7500u total:289 pass:263 dwarn:1 dfail:0 fail:1 skip:24 time:499s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:585s
fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:496s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:593s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:659s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:466s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:657s
fi-skl-6700k total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:534s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:509s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:465s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:584s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:431s
7579653b5bfdee2b6a20aab20c36c516cbe3812f drm-tip: 2017y-10m-09d-12h-55m-47s UTC integration manifest
12ec98a87f9c drm/i915/cnl: Symmetric scalers for each pipe
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5953/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/cnl: Symmetric scalers for each pipe
2017-10-09 12:26 [PATCH] drm/i915/cnl: Symmetric scalers for each pipe Mika Kahola
2017-10-09 14:37 ` ✗ Fi.CI.BAT: warning for " Patchwork
@ 2017-10-11 12:43 ` Ville Syrjälä
2017-10-11 13:08 ` Mika Kahola
1 sibling, 1 reply; 5+ messages in thread
From: Ville Syrjälä @ 2017-10-11 12:43 UTC (permalink / raw)
To: Mika Kahola; +Cc: intel-gfx, rodrigo.vivi
On Mon, Oct 09, 2017 at 03:26:07PM +0300, Mika Kahola wrote:
> For Cannonlake the number of scalers for each pipe is 2. Let's increase
> the number of scalers for pipe C.
>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
> drivers/gpu/drm/i915/intel_device_info.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index 875d428..b2ab6cb 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -347,7 +347,10 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
> struct intel_device_info *info = mkwrite_device_info(dev_priv);
> enum pipe pipe;
>
> - if (INTEL_GEN(dev_priv) >= 9) {
> + if (IS_CANNONLAKE(dev_priv)) {
GEN >= 10 would be a bit more future proof.
> + for_each_pipe(dev_priv, pipe)
> + info->num_scalers[pipe] = 2;
> + } else if (INTEL_GEN(dev_priv) >= 9) {
> info->num_scalers[PIPE_A] = 2;
> info->num_scalers[PIPE_B] = 2;
> info->num_scalers[PIPE_C] = 1;
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/cnl: Symmetric scalers for each pipe
2017-10-11 12:43 ` [PATCH] " Ville Syrjälä
@ 2017-10-11 13:08 ` Mika Kahola
2017-10-24 10:05 ` Maiti, Nabendu Bikash
0 siblings, 1 reply; 5+ messages in thread
From: Mika Kahola @ 2017-10-11 13:08 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx, rodrigo.vivi
On Wed, 2017-10-11 at 15:43 +0300, Ville Syrjälä wrote:
> On Mon, Oct 09, 2017 at 03:26:07PM +0300, Mika Kahola wrote:
> >
> > For Cannonlake the number of scalers for each pipe is 2. Let's
> > increase
> > the number of scalers for pipe C.
> >
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_device_info.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_device_info.c
> > b/drivers/gpu/drm/i915/intel_device_info.c
> > index 875d428..b2ab6cb 100644
> > --- a/drivers/gpu/drm/i915/intel_device_info.c
> > +++ b/drivers/gpu/drm/i915/intel_device_info.c
> > @@ -347,7 +347,10 @@ void intel_device_info_runtime_init(struct
> > drm_i915_private *dev_priv)
> > struct intel_device_info *info =
> > mkwrite_device_info(dev_priv);
> > enum pipe pipe;
> >
> > - if (INTEL_GEN(dev_priv) >= 9) {
> > + if (IS_CANNONLAKE(dev_priv)) {
> GEN >= 10 would be a bit more future proof.
That's true. I actually tried this on trybot but the outcome wasn't
clean. Maybe I just switch back and give CI another go.
>
> >
> > + for_each_pipe(dev_priv, pipe)
> > + info->num_scalers[pipe] = 2;
> > + } else if (INTEL_GEN(dev_priv) >= 9) {
> > info->num_scalers[PIPE_A] = 2;
> > info->num_scalers[PIPE_B] = 2;
> > info->num_scalers[PIPE_C] = 1;
> > --
> > 2.7.4
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Mika Kahola - Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/cnl: Symmetric scalers for each pipe
2017-10-11 13:08 ` Mika Kahola
@ 2017-10-24 10:05 ` Maiti, Nabendu Bikash
0 siblings, 0 replies; 5+ messages in thread
From: Maiti, Nabendu Bikash @ 2017-10-24 10:05 UTC (permalink / raw)
To: mika.kahola, Ville Syrjälä; +Cc: intel-gfx, rodrigo.vivi
On 10/11/2017 6:38 PM, Mika Kahola wrote:
> On Wed, 2017-10-11 at 15:43 +0300, Ville Syrjälä wrote:
>> On Mon, Oct 09, 2017 at 03:26:07PM +0300, Mika Kahola wrote:
>>> For Cannonlake the number of scalers for each pipe is 2. Let's
>>> increase
>>> the number of scalers for pipe C.
>>>
>>> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/intel_device_info.c | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_device_info.c
>>> b/drivers/gpu/drm/i915/intel_device_info.c
>>> index 875d428..b2ab6cb 100644
>>> --- a/drivers/gpu/drm/i915/intel_device_info.c
>>> +++ b/drivers/gpu/drm/i915/intel_device_info.c
>>> @@ -347,7 +347,10 @@ void intel_device_info_runtime_init(struct
>>> drm_i915_private *dev_priv)
>>> struct intel_device_info *info =
>>> mkwrite_device_info(dev_priv);
>>> enum pipe pipe;
>>>
>>> - if (INTEL_GEN(dev_priv) >= 9) {
>>> + if (IS_CANNONLAKE(dev_priv)) {
>> GEN >= 10 would be a bit more future proof.
> That's true. I actually tried this on trybot but the outcome wasn't
> clean. Maybe I just switch back and give CI another go.
Similar patch I submitted in internal (merged).
>
>>> + for_each_pipe(dev_priv, pipe)
>>> + info->num_scalers[pipe] = 2;
>>> + } else if (INTEL_GEN(dev_priv) >= 9) {
>>> info->num_scalers[PIPE_A] = 2;
>>> info->num_scalers[PIPE_B] = 2;
>>> info->num_scalers[PIPE_C] = 1;
>>> --
>>> 2.7.4
>>>
>>> _______________________________________________
>>> Intel-gfx mailing list
>>> Intel-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Regards,
Nabendu
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-24 10:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-09 12:26 [PATCH] drm/i915/cnl: Symmetric scalers for each pipe Mika Kahola
2017-10-09 14:37 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-10-11 12:43 ` [PATCH] " Ville Syrjälä
2017-10-11 13:08 ` Mika Kahola
2017-10-24 10:05 ` Maiti, Nabendu Bikash
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.