From: Johan Hovold <johan@kernel.org>
To: Greg KH <greg@kroah.com>
Cc: Johan Hovold <johan@kernel.org>,
linux-usb@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH 1/5] USB: serial: garmin_gps: fix I/O after failed probe and remove
Date: Wed, 11 Oct 2017 15:27:25 +0200 [thread overview]
Message-ID: <20171011132725.GV4269@localhost> (raw)
In-Reply-To: <20171011125153.GA27734@kroah.com>
On Wed, Oct 11, 2017 at 02:51:53PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Oct 11, 2017 at 02:02:57PM +0200, Johan Hovold wrote:
> > Make sure to stop any submitted interrupt and bulk-out URBs before
> > returning after failed probe and when the port is being unbound to avoid
> > later NULL-pointer dereferences in the completion callbacks.
> >
> > Also fix up the related and broken I/O cancellation on failed open and
> > on close. (Note that port->write_urb was never submitted.)
> >
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > Cc: stable <stable@vger.kernel.org> # 51a2f077 ("USB: introduce usb_anchor")
> > Signed-off-by: Johan Hovold <johan@kernel.org>
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thanks for reviewing these. All now applied.
Johan
next prev parent reply other threads:[~2017-10-11 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171011120301.25673-1-johan@kernel.org>
2017-10-11 12:02 ` [PATCH 1/5] USB: serial: garmin_gps: fix I/O after failed probe and remove Johan Hovold
2017-10-11 12:51 ` Greg KH
2017-10-11 13:27 ` Johan Hovold [this message]
2017-10-11 12:02 ` [PATCH 2/5] USB: serial: garmin_gps: fix memory leak on probe errors Johan Hovold
2017-10-11 12:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011132725.GV4269@localhost \
--to=johan@kernel.org \
--cc=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.