All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [oe-commits] [openembedded-core] 01/01: bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
       [not found] ` <20171009090930.73387234938@git.openembedded.org>
@ 2017-10-12  1:56   ` Martin Jansa
  2017-10-12  2:15     ` Khem Raj
  2017-10-12  2:36     ` ChenQi
  0 siblings, 2 replies; 9+ messages in thread
From: Martin Jansa @ 2017-10-12  1:56 UTC (permalink / raw)
  To: openembedded-core, Chen Qi; +Cc: openembedded-commits

[-- Attachment #1: Type: text/plain, Size: 3096 bytes --]

On Mon, Oct 09, 2017 at 09:09:31AM +0000, git@git.openembedded.org wrote:
> This is an automated email from the git hooks/post-receive script.
> 
> rpurdie pushed a commit to branch master
> in repository openembedded-core.
> 
> commit 8ca61a5464743ff85b6d26886112750d6ddd13e0
> Author: Chen Qi <Qi.Chen@windriver.com>
> AuthorDate: Sat Sep 30 16:15:42 2017 +0800
> 
>     bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
>     
>     Add tools required by testimage to HOSTTOOLS only when testimage is
>     inherited. These tools, as described in the comment, are only required
>     by the testimage task. So this change should not have negtive effect.
>     This would also solve build error on hosts which miss some tool such as scp.
>     
>     Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>     Signed-off-by: Ross Burton <ross.burton@intel.com>
>     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/conf/bitbake.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 6f53b23..0eefb86 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -484,7 +484,7 @@ HOSTTOOLS += " \
>  "
>  
>  # Tools needed to run testimage runtime image testing
> -HOSTTOOLS += "ip ping ps scp ssh stty"
> +HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"

Shouldn't we include at least ssh by default?

I have some builds where CONNECTIVITY_CHECK_URIS contains private git repo (to make sure that users
configured their git + ssh correctly before starting the build) and since this change it fails, because
of missing ssh:

ERROR:  OE-core's config sanity checker detected a potential misconfiguration.
    Either fix the cause of this error or at your own risk disable the checker (see sanity.conf).
    Following is the list of potential problems / advisories:

    Fetcher failure: Fetch command export PATH="...snip.../hosttools"; export HOME="/home/jenkins"; git -c core.fsyncobjectfiles=0 ls-remote ssh://foo.com/bar/repo  failed with exit code 128, output:
error: cannot run ssh: No such file or directory
fatal: unable to fork
.
    Please ensure your host's network is configured correctly,
    or set BB_NO_NETWORK = "1" to disable network access if
    all required sources are on local disk.

I know I can add ssh locally, but do we really need to be so strict
here? We already include git and git might need ssh.

Regards,

>  # Link to these if present
>  HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
> 
> -- 
> To stop receiving notification emails like this one, please contact
> the administrator of this repository.
> -- 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [oe-commits] [openembedded-core] 01/01: bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
  2017-10-12  1:56   ` [oe-commits] [openembedded-core] 01/01: bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally Martin Jansa
@ 2017-10-12  2:15     ` Khem Raj
  2017-10-12  4:32       ` Paul Eggleton
  2017-10-12  2:36     ` ChenQi
  1 sibling, 1 reply; 9+ messages in thread
From: Khem Raj @ 2017-10-12  2:15 UTC (permalink / raw)
  To: Martin Jansa
  Cc: openembedded-commits@lists.openembedded.org,
	Patches and discussions about the oe-core layer

On Wed, Oct 11, 2017 at 6:56 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Mon, Oct 09, 2017 at 09:09:31AM +0000, git@git.openembedded.org wrote:
>> This is an automated email from the git hooks/post-receive script.
>>
>> rpurdie pushed a commit to branch master
>> in repository openembedded-core.
>>
>> commit 8ca61a5464743ff85b6d26886112750d6ddd13e0
>> Author: Chen Qi <Qi.Chen@windriver.com>
>> AuthorDate: Sat Sep 30 16:15:42 2017 +0800
>>
>>     bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
>>
>>     Add tools required by testimage to HOSTTOOLS only when testimage is
>>     inherited. These tools, as described in the comment, are only required
>>     by the testimage task. So this change should not have negtive effect.
>>     This would also solve build error on hosts which miss some tool such as scp.
>>
>>     Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>>     Signed-off-by: Ross Burton <ross.burton@intel.com>
>>     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>> ---
>>  meta/conf/bitbake.conf | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>> index 6f53b23..0eefb86 100644
>> --- a/meta/conf/bitbake.conf
>> +++ b/meta/conf/bitbake.conf
>> @@ -484,7 +484,7 @@ HOSTTOOLS += " \
>>  "
>>
>>  # Tools needed to run testimage runtime image testing
>> -HOSTTOOLS += "ip ping ps scp ssh stty"
>> +HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
>
> Shouldn't we include at least ssh by default?

I would say no, since nothing in OE-Core depends on it. more we
abstract from host system better it is.

>
> I have some builds where CONNECTIVITY_CHECK_URIS contains private git repo (to make sure that users
> configured their git + ssh correctly before starting the build) and since this change it fails, because
> of missing ssh:
>
> ERROR:  OE-core's config sanity checker detected a potential misconfiguration.
>     Either fix the cause of this error or at your own risk disable the checker (see sanity.conf).
>     Following is the list of potential problems / advisories:
>
>     Fetcher failure: Fetch command export PATH="...snip.../hosttools"; export HOME="/home/jenkins"; git -c core.fsyncobjectfiles=0 ls-remote ssh://foo.com/bar/repo  failed with exit code 128, output:
> error: cannot run ssh: No such file or directory
> fatal: unable to fork
> .
>     Please ensure your host's network is configured correctly,
>     or set BB_NO_NETWORK = "1" to disable network access if
>     all required sources are on local disk.
>
> I know I can add ssh locally, but do we really need to be so strict
> here? We already include git and git might need ssh.
>
> Regards,
>
>>  # Link to these if present
>>  HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
>>
>> --
>> To stop receiving notification emails like this one, please contact
>> the administrator of this repository.
>> --
>> _______________________________________________
>> Openembedded-commits mailing list
>> Openembedded-commits@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-commits
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [oe-commits] [openembedded-core] 01/01: bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
  2017-10-12  1:56   ` [oe-commits] [openembedded-core] 01/01: bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally Martin Jansa
  2017-10-12  2:15     ` Khem Raj
@ 2017-10-12  2:36     ` ChenQi
  1 sibling, 0 replies; 9+ messages in thread
From: ChenQi @ 2017-10-12  2:36 UTC (permalink / raw)
  To: Martin Jansa, openembedded-core; +Cc: openembedded-commits

[-- Attachment #1: Type: text/plain, Size: 4036 bytes --]

On 10/12/2017 09:56 AM, Martin Jansa wrote:
> On Mon, Oct 09, 2017 at 09:09:31AM +0000, git@git.openembedded.org wrote:
>> This is an automated email from the git hooks/post-receive script.
>>
>> rpurdie pushed a commit to branch master
>> in repository openembedded-core.
>>
>> commit 8ca61a5464743ff85b6d26886112750d6ddd13e0
>> Author: Chen Qi <Qi.Chen@windriver.com>
>> AuthorDate: Sat Sep 30 16:15:42 2017 +0800
>>
>>      bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
>>      
>>      Add tools required by testimage to HOSTTOOLS only when testimage is
>>      inherited. These tools, as described in the comment, are only required
>>      by the testimage task. So this change should not have negtive effect.
>>      This would also solve build error on hosts which miss some tool such as scp.
>>      
>>      Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>>      Signed-off-by: Ross Burton <ross.burton@intel.com>
>>      Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>> ---
>>   meta/conf/bitbake.conf | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>> index 6f53b23..0eefb86 100644
>> --- a/meta/conf/bitbake.conf
>> +++ b/meta/conf/bitbake.conf
>> @@ -484,7 +484,7 @@ HOSTTOOLS += " \
>>   "
>>   
>>   # Tools needed to run testimage runtime image testing
>> -HOSTTOOLS += "ip ping ps scp ssh stty"
>> +HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
> Shouldn't we include at least ssh by default?
>
> I have some builds where CONNECTIVITY_CHECK_URIS contains private git repo (to make sure that users
> configured their git + ssh correctly before starting the build) and since this change it fails, because
> of missing ssh:
>
> ERROR:  OE-core's config sanity checker detected a potential misconfiguration.
>      Either fix the cause of this error or at your own risk disable the checker (see sanity.conf).
>      Following is the list of potential problems / advisories:
>
>      Fetcher failure: Fetch command export PATH="...snip.../hosttools"; export HOME="/home/jenkins"; git -c core.fsyncobjectfiles=0 ls-remote ssh://foo.com/bar/repo  failed with exit code 128, output:
> error: cannot run ssh: No such file or directory
> fatal: unable to fork
> .
>      Please ensure your host's network is configured correctly,
>      or set BB_NO_NETWORK = "1" to disable network access if
>      all required sources are on local disk.
>
> I know I can add ssh locally, but do we really need to be so strict
> here? We already include git and git might need ssh.
>
> Regards,

Hi Martin,

The problem is mainly about documentation. We need to keep codes and 
docs in sync.

We have in our documentation (QuickStart) a list of software necessary 
to use basic yocto functionality.

e.g.

/Ubuntu and Debian/

      $ sudo apt-get install gawk wget git-core diffstat unzip texinfo gcc-multilib \
      build-essential chrpath socat cpio python python3 python3-pip python3-pexpect \
      xz-utils debianutils iputils-ping libsdl1.2-dev xterm
                         


I have hosts that only have the above packages installed. Thus I was 
meeting error when trying to build something, as ssh and scp are not 
available.

I'm OK with adding ssh into default HOSTTOOLS, but we need to keep 
documentation in sync with the codes. (e.g. adding openssh-client into 
the above list.)

Best Regards,
Chen Qi

>>   # Link to these if present
>>   HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
>>
>> -- 
>> To stop receiving notification emails like this one, please contact
>> the administrator of this repository.
>> -- 
>> _______________________________________________
>> Openembedded-commits mailing list
>> Openembedded-commits@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-commits



[-- Attachment #2: Type: text/html, Size: 5521 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [oe-commits] [openembedded-core] 01/01: bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
  2017-10-12  2:15     ` Khem Raj
@ 2017-10-12  4:32       ` Paul Eggleton
  2017-10-12  5:01         ` Khem Raj
  0 siblings, 1 reply; 9+ messages in thread
From: Paul Eggleton @ 2017-10-12  4:32 UTC (permalink / raw)
  To: openembedded-core; +Cc: openembedded-commits@lists.openembedded.org

On Thursday, 12 October 2017 3:15:12 PM NZDT Khem Raj wrote:
> On Wed, Oct 11, 2017 at 6:56 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > On Mon, Oct 09, 2017 at 09:09:31AM +0000, git@git.openembedded.org wrote:
> >> --- a/meta/conf/bitbake.conf
> >> +++ b/meta/conf/bitbake.conf
> >> @@ -484,7 +484,7 @@ HOSTTOOLS += " \
> >>  "
> >>
> >>  # Tools needed to run testimage runtime image testing
> >> -HOSTTOOLS += "ip ping ps scp ssh stty"
> >> +HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
> >
> > Shouldn't we include at least ssh by default?
> 
> I would say no, since nothing in OE-Core depends on it. more we
> abstract from host system better it is.

I'm with Martin on this one, let's not make it painful for people to use
the SSH protocol in git URLs in their recipes. I don't see much potential
for host contamination.

Cheers,
Paul


-- 

Paul Eggleton
Intel Open Source Technology Centre


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [oe-commits] [openembedded-core] 01/01: bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
  2017-10-12  4:32       ` Paul Eggleton
@ 2017-10-12  5:01         ` Khem Raj
  2017-10-12 11:34           ` Burton, Ross
  0 siblings, 1 reply; 9+ messages in thread
From: Khem Raj @ 2017-10-12  5:01 UTC (permalink / raw)
  To: Paul Eggleton
  Cc: openembedded-commits@lists.openembedded.org,
	Patches and discussions about the oe-core layer

On Wed, Oct 11, 2017 at 9:32 PM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> On Thursday, 12 October 2017 3:15:12 PM NZDT Khem Raj wrote:
>> On Wed, Oct 11, 2017 at 6:56 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> > On Mon, Oct 09, 2017 at 09:09:31AM +0000, git@git.openembedded.org wrote:
>> >> --- a/meta/conf/bitbake.conf
>> >> +++ b/meta/conf/bitbake.conf
>> >> @@ -484,7 +484,7 @@ HOSTTOOLS += " \
>> >>  "
>> >>
>> >>  # Tools needed to run testimage runtime image testing
>> >> -HOSTTOOLS += "ip ping ps scp ssh stty"
>> >> +HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
>> >
>> > Shouldn't we include at least ssh by default?
>>
>> I would say no, since nothing in OE-Core depends on it. more we
>> abstract from host system better it is.
>
> I'm with Martin on this one, let's not make it painful for people to use
> the SSH protocol in git URLs in their recipes. I don't see much potential
> for host contamination.

Standard distro do not install ssh, if we want to add it here, probably we
should at the same time let user know that he should install ssh

We have had certificate and cypto algorithms issues with openssh based
on host distros, where we have added customized sshd_config and ssh_config,

but, I dont have strong opinion either way


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [oe-commits] [openembedded-core] 01/01: bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
  2017-10-12  5:01         ` Khem Raj
@ 2017-10-12 11:34           ` Burton, Ross
  2017-10-13  2:35             ` Martin Jansa
  0 siblings, 1 reply; 9+ messages in thread
From: Burton, Ross @ 2017-10-12 11:34 UTC (permalink / raw)
  To: Khem Raj
  Cc: Paul Eggleton, Patches and discussions about the oe-core layer,
	openembedded-commits@lists.openembedded.org

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

On 12 October 2017 at 06:01, Khem Raj <raj.khem@gmail.com> wrote:

> On Wed, Oct 11, 2017 at 9:32 PM, Paul Eggleton
> <paul.eggleton@linux.intel.com> wrote:
> > On Thursday, 12 October 2017 3:15:12 PM NZDT Khem Raj wrote:
> >> On Wed, Oct 11, 2017 at 6:56 PM, Martin Jansa <martin.jansa@gmail.com>
> wrote:
> >> > On Mon, Oct 09, 2017 at 09:09:31AM +0000, git@git.openembedded.org
> wrote:
> >> >> --- a/meta/conf/bitbake.conf
> >> >> +++ b/meta/conf/bitbake.conf
> >> >> @@ -484,7 +484,7 @@ HOSTTOOLS += " \
> >> >>  "
> >> >>
> >> >>  # Tools needed to run testimage runtime image testing
> >> >> -HOSTTOOLS += "ip ping ps scp ssh stty"
> >> >> +HOSTTOOLS += "${@['', 'ip ping ps scp ssh
> stty'][bb.data.inherits_class('testimage', d)]}"
> >> >
> >> > Shouldn't we include at least ssh by default?
> >>
> >> I would say no, since nothing in OE-Core depends on it. more we
> >> abstract from host system better it is.
> >
> > I'm with Martin on this one, let's not make it painful for people to use
> > the SSH protocol in git URLs in their recipes. I don't see much potential
> > for host contamination.
>
> Standard distro do not install ssh, if we want to add it here, probably we
> should at the same time let user know that he should install ssh
>

That's what HOSTTOOLS_NONFATAL is for.  Who is going to claim the glory and
post a patch?

Ross

[-- Attachment #2: Type: text/html, Size: 2179 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [oe-commits] [openembedded-core] 01/01: bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
  2017-10-12 11:34           ` Burton, Ross
@ 2017-10-13  2:35             ` Martin Jansa
  2017-10-13  2:40               ` Khem Raj
  0 siblings, 1 reply; 9+ messages in thread
From: Martin Jansa @ 2017-10-13  2:35 UTC (permalink / raw)
  To: Burton, Ross
  Cc: Paul Eggleton, openembedded-commits@lists.openembedded.org,
	Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 1961 bytes --]

I just got bunch of do_fetch errors from components using
git://....;protocol=ssh

So it isn't just the sanity check and CONNECTIVITY_CHECK_URIS, it's
everywhere where git-native (by default in ASSUME_PROVIDED) is used with
ssh.

On Thu, Oct 12, 2017 at 1:34 PM, Burton, Ross <ross.burton@intel.com> wrote:

> On 12 October 2017 at 06:01, Khem Raj <raj.khem@gmail.com> wrote:
>
>> On Wed, Oct 11, 2017 at 9:32 PM, Paul Eggleton
>> <paul.eggleton@linux.intel.com> wrote:
>> > On Thursday, 12 October 2017 3:15:12 PM NZDT Khem Raj wrote:
>> >> On Wed, Oct 11, 2017 at 6:56 PM, Martin Jansa <martin.jansa@gmail.com>
>> wrote:
>> >> > On Mon, Oct 09, 2017 at 09:09:31AM +0000, git@git.openembedded.org
>> wrote:
>> >> >> --- a/meta/conf/bitbake.conf
>> >> >> +++ b/meta/conf/bitbake.conf
>> >> >> @@ -484,7 +484,7 @@ HOSTTOOLS += " \
>> >> >>  "
>> >> >>
>> >> >>  # Tools needed to run testimage runtime image testing
>> >> >> -HOSTTOOLS += "ip ping ps scp ssh stty"
>> >> >> +HOSTTOOLS += "${@['', 'ip ping ps scp ssh
>> stty'][bb.data.inherits_class('testimage', d)]}"
>> >> >
>> >> > Shouldn't we include at least ssh by default?
>> >>
>> >> I would say no, since nothing in OE-Core depends on it. more we
>> >> abstract from host system better it is.
>> >
>> > I'm with Martin on this one, let's not make it painful for people to use
>> > the SSH protocol in git URLs in their recipes. I don't see much
>> potential
>> > for host contamination.
>>
>> Standard distro do not install ssh, if we want to add it here, probably we
>> should at the same time let user know that he should install ssh
>>
>
> That's what HOSTTOOLS_NONFATAL is for.  Who is going to claim the glory
> and post a patch?
>
> Ross
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

[-- Attachment #2: Type: text/html, Size: 3409 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [oe-commits] [openembedded-core] 01/01: bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
  2017-10-13  2:35             ` Martin Jansa
@ 2017-10-13  2:40               ` Khem Raj
  2017-10-16  2:20                 ` ChenQi
  0 siblings, 1 reply; 9+ messages in thread
From: Khem Raj @ 2017-10-13  2:40 UTC (permalink / raw)
  To: Martin Jansa
  Cc: Paul Eggleton, openembedded-commits@lists.openembedded.org,
	Patches and discussions about the oe-core layer

On Thu, Oct 12, 2017 at 7:35 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> I just got bunch of do_fetch errors from components using
> git://....;protocol=ssh
>
> So it isn't just the sanity check and CONNECTIVITY_CHECK_URIS, it's
> everywhere where git-native (by default in ASSUME_PROVIDED) is used with
> ssh.

right, I realised that it wont make the situation worse, then it was
in last release,

>
> On Thu, Oct 12, 2017 at 1:34 PM, Burton, Ross <ross.burton@intel.com> wrote:
>>
>> On 12 October 2017 at 06:01, Khem Raj <raj.khem@gmail.com> wrote:
>>>
>>> On Wed, Oct 11, 2017 at 9:32 PM, Paul Eggleton
>>> <paul.eggleton@linux.intel.com> wrote:
>>> > On Thursday, 12 October 2017 3:15:12 PM NZDT Khem Raj wrote:
>>> >> On Wed, Oct 11, 2017 at 6:56 PM, Martin Jansa <martin.jansa@gmail.com>
>>> >> wrote:
>>> >> > On Mon, Oct 09, 2017 at 09:09:31AM +0000, git@git.openembedded.org
>>> >> > wrote:
>>> >> >> --- a/meta/conf/bitbake.conf
>>> >> >> +++ b/meta/conf/bitbake.conf
>>> >> >> @@ -484,7 +484,7 @@ HOSTTOOLS += " \
>>> >> >>  "
>>> >> >>
>>> >> >>  # Tools needed to run testimage runtime image testing
>>> >> >> -HOSTTOOLS += "ip ping ps scp ssh stty"
>>> >> >> +HOSTTOOLS += "${@['', 'ip ping ps scp ssh
>>> >> >> stty'][bb.data.inherits_class('testimage', d)]}"
>>> >> >
>>> >> > Shouldn't we include at least ssh by default?
>>> >>
>>> >> I would say no, since nothing in OE-Core depends on it. more we
>>> >> abstract from host system better it is.
>>> >
>>> > I'm with Martin on this one, let's not make it painful for people to
>>> > use
>>> > the SSH protocol in git URLs in their recipes. I don't see much
>>> > potential
>>> > for host contamination.
>>>
>>> Standard distro do not install ssh, if we want to add it here, probably
>>> we
>>> should at the same time let user know that he should install ssh
>>
>>
>> That's what HOSTTOOLS_NONFATAL is for.  Who is going to claim the glory
>> and post a patch?
>>
>> Ross
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [oe-commits] [openembedded-core] 01/01: bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally
  2017-10-13  2:40               ` Khem Raj
@ 2017-10-16  2:20                 ` ChenQi
  0 siblings, 0 replies; 9+ messages in thread
From: ChenQi @ 2017-10-16  2:20 UTC (permalink / raw)
  To: Khem Raj, Martin Jansa
  Cc: Paul Eggleton, Patches and discussions about the oe-core layer,
	openembedded-commits@lists.openembedded.org

I've created YOCTO#12227 
(https://bugzilla.yoctoproject.org/show_bug.cgi?id=12227).
And I've sent out a patch, adding ssh to HOSTTOOLS_NONFATAL.
Another way to fix things up is to add ssh to HOSTTOOLS and change 
QuickStart accordingly.
Either way is acceptable for me.
I'm using the first solution as I'm slightly leaning to it.

Best Regards,
Chen Qi

On 10/13/2017 10:40 AM, Khem Raj wrote:
> On Thu, Oct 12, 2017 at 7:35 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> I just got bunch of do_fetch errors from components using
>> git://....;protocol=ssh
>>
>> So it isn't just the sanity check and CONNECTIVITY_CHECK_URIS, it's
>> everywhere where git-native (by default in ASSUME_PROVIDED) is used with
>> ssh.
> right, I realised that it wont make the situation worse, then it was
> in last release,
>
>> On Thu, Oct 12, 2017 at 1:34 PM, Burton, Ross <ross.burton@intel.com> wrote:
>>> On 12 October 2017 at 06:01, Khem Raj <raj.khem@gmail.com> wrote:
>>>> On Wed, Oct 11, 2017 at 9:32 PM, Paul Eggleton
>>>> <paul.eggleton@linux.intel.com> wrote:
>>>>> On Thursday, 12 October 2017 3:15:12 PM NZDT Khem Raj wrote:
>>>>>> On Wed, Oct 11, 2017 at 6:56 PM, Martin Jansa <martin.jansa@gmail.com>
>>>>>> wrote:
>>>>>>> On Mon, Oct 09, 2017 at 09:09:31AM +0000, git@git.openembedded.org
>>>>>>> wrote:
>>>>>>>> --- a/meta/conf/bitbake.conf
>>>>>>>> +++ b/meta/conf/bitbake.conf
>>>>>>>> @@ -484,7 +484,7 @@ HOSTTOOLS += " \
>>>>>>>>   "
>>>>>>>>
>>>>>>>>   # Tools needed to run testimage runtime image testing
>>>>>>>> -HOSTTOOLS += "ip ping ps scp ssh stty"
>>>>>>>> +HOSTTOOLS += "${@['', 'ip ping ps scp ssh
>>>>>>>> stty'][bb.data.inherits_class('testimage', d)]}"
>>>>>>> Shouldn't we include at least ssh by default?
>>>>>> I would say no, since nothing in OE-Core depends on it. more we
>>>>>> abstract from host system better it is.
>>>>> I'm with Martin on this one, let's not make it painful for people to
>>>>> use
>>>>> the SSH protocol in git URLs in their recipes. I don't see much
>>>>> potential
>>>>> for host contamination.
>>>> Standard distro do not install ssh, if we want to add it here, probably
>>>> we
>>>> should at the same time let user know that he should install ssh
>>>
>>> That's what HOSTTOOLS_NONFATAL is for.  Who is going to claim the glory
>>> and post a patch?
>>>
>>> Ross
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-10-16  2:14 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <150754017019.10662.17591818165714630277@git.openembedded.org>
     [not found] ` <20171009090930.73387234938@git.openembedded.org>
2017-10-12  1:56   ` [oe-commits] [openembedded-core] 01/01: bitbake.conf: add tools required by testimage to HOSTTOOLS conditionally Martin Jansa
2017-10-12  2:15     ` Khem Raj
2017-10-12  4:32       ` Paul Eggleton
2017-10-12  5:01         ` Khem Raj
2017-10-12 11:34           ` Burton, Ross
2017-10-13  2:35             ` Martin Jansa
2017-10-13  2:40               ` Khem Raj
2017-10-16  2:20                 ` ChenQi
2017-10-12  2:36     ` ChenQi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.