All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Ping-Ke Shih <pkshih@realtek.com>,
	Yan-Hsuan Chuang <yhchuang@realtek.com>,
	Johannes Berg <johannes.berg@intel.com>,
	Souptick Joarder <jrdr.linux@gmail.com>,
	devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: Two rtlwifi drivers?
Date: Thu, 12 Oct 2017 10:34:50 +0000	[thread overview]
Message-ID: <20171012103450.GA24647@kroah.com> (raw)
In-Reply-To: <87h8v4pxqp.fsf@kamboji.qca.qualcomm.com>

On Thu, Oct 12, 2017 at 11:38:06AM +0300, Kalle Valo wrote:
> > So what to do?  Any ideas?  What makes your life easier?  You can just
> > ignore the staging tree, as it should not affect your portion of the
> > kernel at all, right?
> 
> Yes, I automatically ignore anything staging related. But the problem is
> that we now have two drivers with the same name and people don't always
> remember to prefix the patch with "staging: ". So on a bad day I might
> accidentally apply a patch which was meant for your tree. Of course I
> immediately revert it as soon as I, or someone else, catches that but
> annoying still.

It doesn't bother me if you apply staging patches, I can handle the
merge issues :)

> I think we have two options here:
> 
> 1) We set a deadline (like 12 months or something) for the
>    drivers/staging/rtlwifi and after that you refuse to take any patches
>    for it. Hopefully this makes it clear for everyone that this fork is
>    just temporary. I think Larry is trying to do this, which is great.

Fine with me, if Larry is ok with it.

> 2) We move the whole rtlwifi driver to staging. A very bad option but
>    still better than forking the drivers.

Ick, I don't want that to have to happen, that would not be good for the
users of other devices that the "real" rtlwifi driver supports.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Ping-Ke Shih <pkshih@realtek.com>,
	Yan-Hsuan Chuang <yhchuang@realtek.com>,
	Johannes Berg <johannes.berg@intel.com>,
	Souptick Joarder <jrdr.linux@gmail.com>,
	devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: Two rtlwifi drivers?
Date: Thu, 12 Oct 2017 12:34:50 +0200	[thread overview]
Message-ID: <20171012103450.GA24647@kroah.com> (raw)
In-Reply-To: <87h8v4pxqp.fsf@kamboji.qca.qualcomm.com>

On Thu, Oct 12, 2017 at 11:38:06AM +0300, Kalle Valo wrote:
> > So what to do?  Any ideas?  What makes your life easier?  You can just
> > ignore the staging tree, as it should not affect your portion of the
> > kernel at all, right?
> 
> Yes, I automatically ignore anything staging related. But the problem is
> that we now have two drivers with the same name and people don't always
> remember to prefix the patch with "staging: ". So on a bad day I might
> accidentally apply a patch which was meant for your tree. Of course I
> immediately revert it as soon as I, or someone else, catches that but
> annoying still.

It doesn't bother me if you apply staging patches, I can handle the
merge issues :)

> I think we have two options here:
> 
> 1) We set a deadline (like 12 months or something) for the
>    drivers/staging/rtlwifi and after that you refuse to take any patches
>    for it. Hopefully this makes it clear for everyone that this fork is
>    just temporary. I think Larry is trying to do this, which is great.

Fine with me, if Larry is ok with it.

> 2) We move the whole rtlwifi driver to staging. A very bad option but
>    still better than forking the drivers.

Ick, I don't want that to have to happen, that would not be good for the
users of other devices that the "real" rtlwifi driver supports.

thanks,

greg k-h

  reply	other threads:[~2017-10-12 10:34 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 10:08 [PATCH] staging: rtlwifi: check for array overflow Dan Carpenter
2017-08-24 10:08 ` Dan Carpenter
2017-08-24 12:14 ` Two rtlwifi drivers? Kalle Valo
2017-08-24 12:14   ` Kalle Valo
2017-08-24 14:41   ` Larry Finger
2017-08-24 14:41     ` Larry Finger
2017-10-11  9:06     ` Kalle Valo
2017-10-11  9:06       ` Kalle Valo
2017-10-11 13:13       ` Greg Kroah-Hartman
2017-10-11 13:13         ` Greg Kroah-Hartman
2017-10-11 13:54         ` Dan Carpenter
2017-10-11 13:54           ` Dan Carpenter
2017-10-11 14:19         ` Larry Finger
2017-10-11 14:19           ` Larry Finger
2017-10-12  8:57           ` Kalle Valo
2017-10-12  8:57             ` Kalle Valo
2017-10-12  8:38         ` Kalle Valo
2017-10-12  8:38           ` Kalle Valo
2017-10-12 10:34           ` Greg Kroah-Hartman [this message]
2017-10-12 10:34             ` Greg Kroah-Hartman
2017-10-16  2:41             ` Pkshih
2017-10-16  2:41               ` Pkshih
2017-10-16  6:46               ` Oleksij Rempel
2017-10-16  6:46                 ` Oleksij Rempel
2017-10-16 13:07                 ` Kalle Valo
2017-10-16 13:07                   ` Kalle Valo
2017-10-16 13:11                   ` Oleksij Rempel
2017-10-16 13:11                     ` Oleksij Rempel
2017-10-16  7:45               ` Dan Carpenter
2017-10-16  7:45                 ` Dan Carpenter
2017-10-16 13:03                 ` Kalle Valo
2017-10-16 13:03                   ` Kalle Valo
2017-10-16  7:50               ` Greg Kroah-Hartman
2017-10-16  7:50                 ` Greg Kroah-Hartman
2017-10-17  1:24                 ` Pkshih
2017-10-16 13:22               ` Kalle Valo
2017-10-16 13:22                 ` Kalle Valo
2017-10-17  1:45                 ` Pkshih
2017-10-18  5:33                   ` Kalle Valo
2017-10-16  8:07   ` walter harms
2017-08-24 18:51 ` [PATCH] staging: rtlwifi: check for array overflow Larry Finger
2017-08-24 18:51   ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171012103450.GA24647@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=johannes.berg@intel.com \
    --cc=jrdr.linux@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.