All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Luca Coelho <luca@coelho.fi>
Cc: stable@vger.kernel.org, luciano.coelho@intel.com
Subject: Re: [PATCH for v4.4] iwlwifi: mvm: use IWL_HCMD_NOCOPY for MCAST_FILTER_CMD
Date: Thu, 12 Oct 2017 13:46:04 +0200	[thread overview]
Message-ID: <20171012114604.GE32149@kroah.com> (raw)
In-Reply-To: <20171011072240.27825-1-luca@coelho.fi>

On Wed, Oct 11, 2017 at 10:22:40AM +0300, Luca Coelho wrote:
> From: Luca Coelho <luciano.coelho@intel.com>
> 
> commit 97bce57bd7f96e1218751996f549a6e61f18cc8c upstream.
> 
> The MCAST_FILTER_CMD can get quite large when we have many mcast
> addresses to set (we support up to 255).  So the command should be
> send as NOCOPY to prevent a warning caused by too-long commands:
> 
> WARNING: CPU: 0 PID: 9700 at /root/iwlwifi/stack-dev/drivers/net/wireless/intel/iwlwifi/pcie/tx.c:1550 iwl_pcie_enqueue_hcmd+0x8c7/0xb40 [iwlwifi]
> Command MCAST_FILTER_CMD (0x1d0) is too large (328 bytes)
> 
> This fixes: https://bugzilla.kernel.org/show_bug.cgi?id=196743
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
>  drivers/net/wireless/iwlwifi/mvm/mac80211.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)

Thanks for the patch, now queued up.

greg k-h

      reply	other threads:[~2017-10-12 11:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10 15:26 FAILED: patch "[PATCH] iwlwifi: mvm: use IWL_HCMD_NOCOPY for MCAST_FILTER_CMD" failed to apply to 4.4-stable tree gregkh
2017-10-11  7:22 ` [PATCH for v4.4] iwlwifi: mvm: use IWL_HCMD_NOCOPY for MCAST_FILTER_CMD Luca Coelho
2017-10-12 11:46   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171012114604.GE32149@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=luca@coelho.fi \
    --cc=luciano.coelho@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.