From: Vinod Koul <vinod.koul@intel.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH][dma-next] dmaengine: stm32: remove redundant initialization of hwdesc
Date: Thu, 12 Oct 2017 14:17:05 +0000 [thread overview]
Message-ID: <20171012140505.GP30097@localhost> (raw)
In-Reply-To: <20171011102822.19166-1-colin.king@canonical.com>
On Wed, Oct 11, 2017 at 11:28:22AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> hwdesc is being initialized to desc->hwdesc but this is never read
> as hwdesc is overwritten in a for-loop. Remove the redundant
> initialization and move the declaration of hwdesc into the for-loop.
>
> Cleans up clang warning:
> Value stored to 'hwdesc' during its initialization is never read
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH][dma-next] dmaengine: stm32: remove redundant initialization of hwdesc
Date: Thu, 12 Oct 2017 19:35:05 +0530 [thread overview]
Message-ID: <20171012140505.GP30097@localhost> (raw)
In-Reply-To: <20171011102822.19166-1-colin.king@canonical.com>
On Wed, Oct 11, 2017 at 11:28:22AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> hwdesc is being initialized to desc->hwdesc but this is never read
> as hwdesc is overwritten in a for-loop. Remove the redundant
> initialization and move the declaration of hwdesc into the for-loop.
>
> Cleans up clang warning:
> Value stored to 'hwdesc' during its initialization is never read
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][dma-next] dmaengine: stm32: remove redundant initialization of hwdesc
Date: Thu, 12 Oct 2017 19:35:05 +0530 [thread overview]
Message-ID: <20171012140505.GP30097@localhost> (raw)
In-Reply-To: <20171011102822.19166-1-colin.king@canonical.com>
On Wed, Oct 11, 2017 at 11:28:22AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> hwdesc is being initialized to desc->hwdesc but this is never read
> as hwdesc is overwritten in a for-loop. Remove the redundant
> initialization and move the declaration of hwdesc into the for-loop.
>
> Cleans up clang warning:
> Value stored to 'hwdesc' during its initialization is never read
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2017-10-12 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 10:28 [PATCH][dma-next] dmaengine: stm32: remove redundant initialization of hwdesc Colin King
2017-10-11 10:28 ` Colin King
2017-10-11 10:28 ` Colin King
2017-10-11 12:16 ` Pierre Yves MORDRET
2017-10-11 12:16 ` Pierre Yves MORDRET
2017-10-11 12:16 ` Pierre Yves MORDRET
2017-10-12 14:05 ` Vinod Koul [this message]
2017-10-12 14:17 ` Vinod Koul
2017-10-12 14:05 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012140505.GP30097@localhost \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.