From: Tejun Heo <tj@kernel.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: johannes.berg@intel.com, peterz@infradead.org, mingo@kernel.org,
tglx@linutronix.de, oleg@redhat.com,
linux-kernel@vger.kernel.org, kernel-team@lge.com
Subject: Re: [RESEND PATCH v2 2/2] lockdep: Remove unnecessary acquisitions wrt workqueue flush
Date: Thu, 12 Oct 2017 08:38:17 -0700 [thread overview]
Message-ID: <20171012153817.GQ3301751@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20171012075435.GK3323@X58A-UD3R>
Hello,
On Thu, Oct 12, 2017 at 04:54:35PM +0900, Byungchul Park wrote:
> On Tue, Oct 10, 2017 at 03:51:37PM +0900, Byungchul Park wrote:
> > The workqueue added manual acquisitions to catch deadlock cases.
> > Now crossrelease was introduced, some of those are redundant, since
> > wait_for_completion() already includes the acquisition for itself.
> > Removed it.
>
> I think manual annotations for wait_for_completion() should be removed
> in this way, since it's already embedded in wait_for_completion(), now.
> Don't you think so?
As long as we have the same level of protection, simpler code is of
course preferable. That said, I haven't followed the discussion
closely and don't want to apply it without Peter's ack. Peter?
Thanks.
--
tejun
next prev parent reply other threads:[~2017-10-12 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 6:51 [RESEND PATCH v2 1/2] completion: Add support for initializing completion with lockdep_map Byungchul Park
2017-10-10 6:51 ` [RESEND PATCH v2 2/2] lockdep: Remove unnecessary acquisitions wrt workqueue flush Byungchul Park
2017-10-12 7:54 ` Byungchul Park
2017-10-12 15:38 ` Tejun Heo [this message]
2017-10-12 15:56 ` Peter Zijlstra
2017-10-13 7:56 ` Byungchul Park
2017-10-13 8:27 ` Peter Zijlstra
2017-10-13 8:48 ` Byungchul Park
2017-10-16 10:58 ` Byungchul Park
2017-10-16 11:06 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012153817.GQ3301751@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=byungchul.park@lge.com \
--cc=johannes.berg@intel.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.