All of lore.kernel.org
 help / color / mirror / Atom feed
* [3rdparty][PATCH] wandboard: disable RevD1 support with use-mainline-bsp
@ 2017-10-15 13:14 Trevor Woerner
  2017-10-15 13:27 ` Fabio Estevam
  0 siblings, 1 reply; 3+ messages in thread
From: Trevor Woerner @ 2017-10-15 13:14 UTC (permalink / raw)
  To: meta-freescale

use-mainline-bsp uses linux-fslc (as opposed to linux-wandboard otherwise)
which doesn't currently have the RevD1 definitions.

Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
 conf/machine/wandboard.conf | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/conf/machine/wandboard.conf b/conf/machine/wandboard.conf
index e07046d..8eaf58e 100644
--- a/conf/machine/wandboard.conf
+++ b/conf/machine/wandboard.conf
@@ -29,6 +29,12 @@ KERNEL_DEVICETREE = " \
     imx6q-wandboard-revd1.dtb \
     imx6qp-wandboard-revd1.dtb \
 "
+KERNEL_DEVICETREE_use-mainline-bsp = " \
+    imx6dl-wandboard.dtb \
+    imx6dl-wandboard-revb1.dtb \
+    imx6q-wandboard.dtb \
+    imx6q-wandboard-revb1.dtb \
+"
 
 KERNEL_IMAGETYPE = "zImage"
 
-- 
2.14.1.459.g238e487ea



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [3rdparty][PATCH] wandboard: disable RevD1 support with use-mainline-bsp
  2017-10-15 13:14 [3rdparty][PATCH] wandboard: disable RevD1 support with use-mainline-bsp Trevor Woerner
@ 2017-10-15 13:27 ` Fabio Estevam
  2017-10-15 16:43   ` Trevor Woerner
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2017-10-15 13:27 UTC (permalink / raw)
  To: Trevor Woerner; +Cc: meta-freescale@yoctoproject.org

Hi Trevor,

On Sun, Oct 15, 2017 at 11:14 AM, Trevor Woerner <twoerner@gmail.com> wrote:
> use-mainline-bsp uses linux-fslc (as opposed to linux-wandboard otherwise)
> which doesn't currently have the RevD1 definitions.
>
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>

This fixes the build error, but it will give a run-time error in case
someone has a revd1 as the revd1 dtb's will not be found.

It would be better to add the revd1 dts as per this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit/?h=for-next&id=36cfd5b3fb556ea7f818f2669c29d15817942b97


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [3rdparty][PATCH] wandboard: disable RevD1 support with use-mainline-bsp
  2017-10-15 13:27 ` Fabio Estevam
@ 2017-10-15 16:43   ` Trevor Woerner
  0 siblings, 0 replies; 3+ messages in thread
From: Trevor Woerner @ 2017-10-15 16:43 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: meta-freescale@yoctoproject.org

On Sun, Oct 15, 2017 at 9:27 AM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Trevor,
>
> On Sun, Oct 15, 2017 at 11:14 AM, Trevor Woerner <twoerner@gmail.com> wrote:
>> use-mainline-bsp uses linux-fslc (as opposed to linux-wandboard otherwise)
>> which doesn't currently have the RevD1 definitions.
>>
>> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
>
> This fixes the build error, but it will give a run-time error in case
> someone has a revd1 as the revd1 dtb's will not be found.
>
> It would be better to add the revd1 dts as per this commit:
> https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit/?h=for-next&id=36cfd5b3fb556ea7f818f2669c29d15817942b97

Good point. I've submitted https://github.com/Freescale/linux-fslc/pull/16


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-10-15 16:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-15 13:14 [3rdparty][PATCH] wandboard: disable RevD1 support with use-mainline-bsp Trevor Woerner
2017-10-15 13:27 ` Fabio Estevam
2017-10-15 16:43   ` Trevor Woerner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.