From: LW@KARO-electronics.de (Lothar Waßmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property
Date: Mon, 16 Oct 2017 10:56:32 +0200 [thread overview]
Message-ID: <20171016105632.709e653c@karo-electronics.de> (raw)
In-Reply-To: <20171016071726.gyzvalxzk4o3jsuz@pengutronix.de>
Hi,
On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-K?nig wrote:
> Hello,
>
> On Wed, Oct 11, 2017 at 01:05:38PM +0200, Lothar Wa?mann wrote:
> > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> > index 211e67d..3c852f7 100644
> > --- a/arch/arm/boot/dts/imx28-tx28.dts
> > +++ b/arch/arm/boot/dts/imx28-tx28.dts
> > @@ -328,8 +328,7 @@
> > reg = <0x20>;
> > pinctrl-names = "default";
> > pinctrl-0 = <&tx28_pca9554_pins>;
> > - interrupt-parent = <&gpio3>;
> > - interrupts = <28 0>;
> > + interrupts-extended = <&gpio3 28 IRQ_TYPE_NONE>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
>
> While interrupts-extended looks nice,
> Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> has:
>
> "interrupts-extended" should only be used when a device has
> multiple interrupt parents.
>
> If this is still true, this patch is wrong.
>
Thanks for the hint. It really helps to read the documentation
sometimes, rahter than relying on existing code only...
A quick check shows, that more than 100 of the 130 uses of
interrupts-extended are wrong. :(
Lothar Wa?mann
WARNING: multiple messages have this Message-ID (diff)
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property
Date: Mon, 16 Oct 2017 10:56:32 +0200 [thread overview]
Message-ID: <20171016105632.709e653c@karo-electronics.de> (raw)
In-Reply-To: <20171016071726.gyzvalxzk4o3jsuz@pengutronix.de>
Hi,
On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Oct 11, 2017 at 01:05:38PM +0200, Lothar Waßmann wrote:
> > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> > index 211e67d..3c852f7 100644
> > --- a/arch/arm/boot/dts/imx28-tx28.dts
> > +++ b/arch/arm/boot/dts/imx28-tx28.dts
> > @@ -328,8 +328,7 @@
> > reg = <0x20>;
> > pinctrl-names = "default";
> > pinctrl-0 = <&tx28_pca9554_pins>;
> > - interrupt-parent = <&gpio3>;
> > - interrupts = <28 0>;
> > + interrupts-extended = <&gpio3 28 IRQ_TYPE_NONE>;
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
>
> While interrupts-extended looks nice,
> Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> has:
>
> "interrupts-extended" should only be used when a device has
> multiple interrupt parents.
>
> If this is still true, this patch is wrong.
>
Thanks for the hint. It really helps to read the documentation
sometimes, rahter than relying on existing code only...
A quick check shows, that more than 100 of the 130 uses of
interrupts-extended are wrong. :(
Lothar Waßmann
next prev parent reply other threads:[~2017-10-16 8:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 11:05 [PATCH 0/4] ARM: dts: imx28: Update Ka-Ro TX28 dts file Lothar Waßmann
2017-10-11 11:05 ` Lothar Waßmann
2017-10-11 11:05 ` [PATCH 1/4] ARM: dts: imx28-tx28: Relicense the TX28 dts file under GPLv2/X11 Lothar Waßmann
2017-10-11 11:05 ` Lothar Waßmann
2017-10-11 11:05 ` Lothar Waßmann
2017-10-11 11:05 ` [PATCH 2/4] ARM: dts: imx28-tx28: remove the regulators bus Lothar Waßmann
2017-10-11 11:05 ` Lothar Waßmann
2017-10-11 11:05 ` Lothar Waßmann
2017-10-11 11:05 ` [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property Lothar Waßmann
2017-10-11 11:05 ` Lothar Waßmann
2017-10-11 11:05 ` Lothar Waßmann
2017-10-16 7:17 ` Uwe Kleine-König
2017-10-16 7:17 ` Uwe Kleine-König
2017-10-16 7:17 ` Uwe Kleine-König
2017-10-16 8:56 ` Lothar Waßmann [this message]
2017-10-16 8:56 ` Lothar Waßmann
2017-10-16 9:03 ` interrupts-extended only allowed with different parents? [Was: Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property] Uwe Kleine-König
2017-10-16 9:03 ` Uwe Kleine-König
2017-10-16 9:03 ` Uwe Kleine-König
2017-10-16 21:29 ` Rob Herring
2017-10-16 21:29 ` Rob Herring
2017-10-18 2:13 ` [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property Shawn Guo
2017-10-18 2:13 ` Shawn Guo
2017-10-18 6:40 ` Lothar Waßmann
2017-10-18 6:40 ` Lothar Waßmann
2017-10-18 6:40 ` Lothar Waßmann
2017-10-23 0:20 ` Shawn Guo
2017-10-23 0:20 ` Shawn Guo
2017-10-11 11:05 ` [PATCH 4/4] ARM: dts: imx28-tx28: add trickle-charge config for DS1339 Lothar Waßmann
2017-10-11 11:05 ` Lothar Waßmann
2017-10-11 11:05 ` Lothar Waßmann
2017-10-14 15:08 ` [PATCH 0/4] ARM: dts: imx28: Update Ka-Ro TX28 dts file Shawn Guo
2017-10-14 15:08 ` Shawn Guo
2017-10-14 15:08 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016105632.709e653c@karo-electronics.de \
--to=lw@karo-electronics.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.