From: Greg KH <gregkh@linuxfoundation.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v2 01/15] configfs: make ci_type field, some pointers and function arguments const
Date: Tue, 17 Oct 2017 12:24:27 +0200 [thread overview]
Message-ID: <20171017102427.GB25786@kroah.com> (raw)
In-Reply-To: <1508167134-6243-2-git-send-email-bhumirks@gmail.com>
On Mon, Oct 16, 2017 at 05:18:40PM +0200, Bhumika Goyal wrote:
> The ci_type field of the config_item structure do not modify the fields
> of the config_item_type structure it points to. And the other pointers
> initialized with ci_type do not modify the fields as well.
> So, make the ci_type field and the pointers initialized with ci_type
> as const.
>
> Make the struct config_item_type *type function argument of functions
> config_{item/group}_init_type_name const as the argument in both the
> functions is only stored in the ci_type field of a config_item structure
> which is now made const.
> Make the argument of configfs_register_default_group const as it is
> only passed to the argument of the function config_group_init_type_name
> which is now const.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> * Changes in v2- Combine all the followup patches and the constification
> patches into a series.
>
> fs/configfs/dir.c | 10 +++++-----
> fs/configfs/item.c | 6 +++---
> fs/configfs/symlink.c | 4 ++--
> include/linux/configfs.h | 8 ++++----
> 4 files changed, 14 insertions(+), 14 deletions(-)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, rjw@rjwysocki.net, lenb@kernel.org,
alexander.shishkin@linux.intel.com, jic23@kernel.org,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, hch@lst.de, sagi@grimberg.me,
kishon@ti.com, bhelgaas@google.com, nab@linux-iscsi.org,
balbi@kernel.org, laurent.pinchart@ideasonboard.com,
jlbec@evilplan.org, ccaulfie@redhat.com, teigland@redhat.com,
mfasheh@versity.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-usb@vger.kernel.org, cluster-devel@redhat.com,
ocfs2-devel@oss.orac
Subject: Re: [PATCH v2 01/15] configfs: make ci_type field, some pointers and function arguments const
Date: Tue, 17 Oct 2017 12:24:27 +0200 [thread overview]
Message-ID: <20171017102427.GB25786@kroah.com> (raw)
In-Reply-To: <1508167134-6243-2-git-send-email-bhumirks@gmail.com>
On Mon, Oct 16, 2017 at 05:18:40PM +0200, Bhumika Goyal wrote:
> The ci_type field of the config_item structure do not modify the fields
> of the config_item_type structure it points to. And the other pointers
> initialized with ci_type do not modify the fields as well.
> So, make the ci_type field and the pointers initialized with ci_type
> as const.
>
> Make the struct config_item_type *type function argument of functions
> config_{item/group}_init_type_name const as the argument in both the
> functions is only stored in the ci_type field of a config_item structure
> which is now made const.
> Make the argument of configfs_register_default_group const as it is
> only passed to the argument of the function config_group_init_type_name
> which is now const.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> * Changes in v2- Combine all the followup patches and the constification
> patches into a series.
>
> fs/configfs/dir.c | 10 +++++-----
> fs/configfs/item.c | 6 +++---
> fs/configfs/symlink.c | 4 ++--
> include/linux/configfs.h | 8 ++++----
> 4 files changed, 14 insertions(+), 14 deletions(-)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, rjw@rjwysocki.net, lenb@kernel.org,
alexander.shishkin@linux.intel.com, jic23@kernel.org,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, hch@lst.de, sagi@grimberg.me,
kishon@ti.com, bhelgaas@google.com, nab@linux-iscsi.org,
balbi@kernel.org, laurent.pinchart@ideasonboard.com,
jlbec@evilplan.org, ccaulfie@redhat.com, teigland@redhat.com,
mfasheh@versity.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-usb@vger.kernel.org, cluster-devel@redhat.com,
ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 01/15] configfs: make ci_type field, some pointers and function arguments const
Date: Tue, 17 Oct 2017 12:24:27 +0200 [thread overview]
Message-ID: <20171017102427.GB25786@kroah.com> (raw)
In-Reply-To: <1508167134-6243-2-git-send-email-bhumirks@gmail.com>
On Mon, Oct 16, 2017 at 05:18:40PM +0200, Bhumika Goyal wrote:
> The ci_type field of the config_item structure do not modify the fields
> of the config_item_type structure it points to. And the other pointers
> initialized with ci_type do not modify the fields as well.
> So, make the ci_type field and the pointers initialized with ci_type
> as const.
>
> Make the struct config_item_type *type function argument of functions
> config_{item/group}_init_type_name const as the argument in both the
> functions is only stored in the ci_type field of a config_item structure
> which is now made const.
> Make the argument of configfs_register_default_group const as it is
> only passed to the argument of the function config_group_init_type_name
> which is now const.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> * Changes in v2- Combine all the followup patches and the constification
> patches into a series.
>
> fs/configfs/dir.c | 10 +++++-----
> fs/configfs/item.c | 6 +++---
> fs/configfs/symlink.c | 4 ++--
> include/linux/configfs.h | 8 ++++----
> 4 files changed, 14 insertions(+), 14 deletions(-)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, rjw@rjwysocki.net, lenb@kernel.org,
alexander.shishkin@linux.intel.com, jic23@kernel.org,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, hch@lst.de, sagi@grimberg.me,
kishon@ti.com, bhelgaas@google.com, nab@linux-iscsi.org,
balbi@kernel.org, laurent.pinchart@ideasonboard.com,
jlbec@evilplan.org, ccaulfie@redhat.com, teigland@redhat.com,
mfasheh@versity.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-usb@vger.kernel.org, cluster-devel@redhat.com,
ocfs2-devel@oss.orac
Subject: Re: [PATCH v2 01/15] configfs: make ci_type field, some pointers and function arguments const
Date: Tue, 17 Oct 2017 10:24:27 +0000 [thread overview]
Message-ID: <20171017102427.GB25786@kroah.com> (raw)
In-Reply-To: <1508167134-6243-2-git-send-email-bhumirks@gmail.com>
On Mon, Oct 16, 2017 at 05:18:40PM +0200, Bhumika Goyal wrote:
> The ci_type field of the config_item structure do not modify the fields
> of the config_item_type structure it points to. And the other pointers
> initialized with ci_type do not modify the fields as well.
> So, make the ci_type field and the pointers initialized with ci_type
> as const.
>
> Make the struct config_item_type *type function argument of functions
> config_{item/group}_init_type_name const as the argument in both the
> functions is only stored in the ci_type field of a config_item structure
> which is now made const.
> Make the argument of configfs_register_default_group const as it is
> only passed to the argument of the function config_group_init_type_name
> which is now const.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> * Changes in v2- Combine all the followup patches and the constification
> patches into a series.
>
> fs/configfs/dir.c | 10 +++++-----
> fs/configfs/item.c | 6 +++---
> fs/configfs/symlink.c | 4 ++--
> include/linux/configfs.h | 8 ++++----
> 4 files changed, 14 insertions(+), 14 deletions(-)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2017-10-17 10:24 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 15:18 [Cluster-devel] [PATCH v2 00/15] make structure field, function arguments and structures const Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` [Cluster-devel] [PATCH v2 01/15] configfs: make ci_type field, some pointers and function arguments const Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-17 10:24 ` Greg KH [this message]
2017-10-17 10:24 ` Greg KH
2017-10-17 10:24 ` Greg KH
2017-10-17 10:24 ` Greg KH
2017-10-16 15:18 ` [Cluster-devel] [PATCH v2 02/15] usb: gadget: make config_item_type structures const Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-17 8:30 ` [Cluster-devel] " Felipe Balbi
2017-10-17 8:30 ` Felipe Balbi
2017-10-17 8:30 ` Felipe Balbi
2017-10-17 8:30 ` Felipe Balbi
2017-10-17 8:30 ` Felipe Balbi
2017-10-18 16:05 ` [Cluster-devel] " Laurent Pinchart
2017-10-18 16:05 ` Laurent Pinchart
2017-10-18 16:05 ` Laurent Pinchart
2017-10-18 16:05 ` Laurent Pinchart
2017-10-18 16:05 ` Laurent Pinchart
2017-10-19 14:06 ` [Cluster-devel] " Christoph Hellwig
2017-10-19 14:06 ` Christoph Hellwig
2017-10-19 14:06 ` Christoph Hellwig
2017-10-19 14:06 ` Christoph Hellwig
2017-10-19 15:05 ` [Cluster-devel] " Laurent Pinchart
2017-10-19 15:05 ` Laurent Pinchart
2017-10-19 15:05 ` Laurent Pinchart
2017-10-19 15:05 ` Laurent Pinchart
2017-10-20 8:02 ` [Cluster-devel] " Julia Lawall
2017-10-20 8:02 ` Julia Lawall
2017-10-20 8:02 ` Julia Lawall
2017-10-20 8:02 ` Julia Lawall
2017-10-20 8:02 ` Julia Lawall
2017-10-20 8:13 ` [Cluster-devel] " Bhumika Goyal
2017-10-20 8:13 ` Bhumika Goyal
2017-10-20 8:13 ` Bhumika Goyal
2017-10-20 8:13 ` Bhumika Goyal
2017-10-20 8:13 ` Bhumika Goyal
2017-10-16 15:18 ` [Cluster-devel] [PATCH v2 03/15] target: make config_item_type const Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` [Cluster-devel] [PATCH v2 04/15] iio: make function argument and some structures const Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 18:48 ` [Cluster-devel] " Jonathan Cameron
2017-10-16 18:48 ` Jonathan Cameron
2017-10-16 18:48 ` Jonathan Cameron
2017-10-16 18:48 ` Jonathan Cameron
2017-10-16 18:48 ` Jonathan Cameron
2017-10-16 18:48 ` Jonathan Cameron
2017-10-16 15:18 ` [Cluster-devel] [PATCH v2 05/15] ocfs2/cluster: make config_item_type const Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` [Cluster-devel] [PATCH v2 06/15] PCI: endpoint: " Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 18:24 ` [Cluster-devel] " Bjorn Helgaas
2017-10-16 18:24 ` Bjorn Helgaas
2017-10-16 18:24 ` Bjorn Helgaas
2017-10-16 18:24 ` Bjorn Helgaas
2017-10-16 15:18 ` [Cluster-devel] [PATCH v2 07/15] usb: gadget: configfs: " Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-17 8:31 ` [Cluster-devel] " Felipe Balbi
2017-10-17 8:31 ` Felipe Balbi
2017-10-17 8:31 ` Felipe Balbi
2017-10-17 8:31 ` Felipe Balbi
2017-10-17 8:31 ` Felipe Balbi
2017-10-16 15:18 ` [Cluster-devel] [PATCH v2 08/15] nvmet: " Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-17 10:18 ` [Cluster-devel] " Sagi Grimberg
2017-10-17 10:18 ` Sagi Grimberg
2017-10-17 10:18 ` Sagi Grimberg
2017-10-17 10:18 ` Sagi Grimberg
2017-10-17 10:18 ` Sagi Grimberg
2017-10-16 15:18 ` [Cluster-devel] [PATCH v2 09/15] ACPI: configfs: " Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-17 0:10 ` [Cluster-devel] " Rafael J. Wysocki
2017-10-17 0:10 ` Rafael J. Wysocki
2017-10-17 0:10 ` Rafael J. Wysocki
2017-10-17 0:10 ` Rafael J. Wysocki
2017-10-16 15:18 ` [Cluster-devel] [PATCH v2 10/15] nullb: " Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` [Cluster-devel] [PATCH v2 11/15] stm class: " Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-17 10:25 ` [Cluster-devel] " Greg KH
2017-10-17 10:25 ` Greg KH
2017-10-17 10:25 ` Greg KH
2017-10-17 10:25 ` Greg KH
2017-10-16 15:18 ` [Cluster-devel] [PATCH v2 12/15] RDMA/cma: " Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-17 10:56 ` [Cluster-devel] " Leon Romanovsky
2017-10-17 10:56 ` Leon Romanovsky
2017-10-17 10:56 ` Leon Romanovsky
2017-10-17 10:56 ` Leon Romanovsky
2017-10-18 14:33 ` [Cluster-devel] " Doug Ledford
2017-10-18 14:33 ` Doug Ledford
2017-10-18 14:33 ` Doug Ledford
2017-10-18 14:33 ` Doug Ledford
2017-10-16 15:18 ` [Cluster-devel] [PATCH v2 13/15] netconsole: " Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` [Cluster-devel] [PATCH v2 14/15] dlm: " Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` [Cluster-devel] [PATCH v2 15/15] configfs: " Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-16 15:18 ` Bhumika Goyal
2017-10-17 10:12 ` [Cluster-devel] [PATCH v2 00/15] make structure field, function arguments and structures const Greg KH
2017-10-17 10:12 ` Greg KH
2017-10-17 10:12 ` Greg KH
2017-10-17 10:12 ` Greg KH
2017-10-17 10:16 ` [Cluster-devel] " Julia Lawall
2017-10-17 10:16 ` Julia Lawall
2017-10-17 10:16 ` Julia Lawall
2017-10-17 10:16 ` Julia Lawall
2017-10-17 10:23 ` [Cluster-devel] " Greg KH
2017-10-17 10:23 ` Greg KH
2017-10-17 10:23 ` Greg KH
2017-10-17 10:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017102427.GB25786@kroah.com \
--to=gregkh@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.