* [PATCH] fluidsynth: update 1.1.6 -> 1.1.8
@ 2017-10-16 10:42 Andreas Müller
2017-10-16 17:40 ` Leonardo Sandoval
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Müller @ 2017-10-16 10:42 UTC (permalink / raw)
To: openembedded-devel
* project has moved from sourceforge to github
* autotools was replaced by cmake [1]
[1] https://github.com/FluidSynth/fluidsynth/commit/3939941c5f3fdaef6bf9258fabd5725e7666554a
Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
.../fluidsynth/fluidsynth_1.1.6.bb | 23 ----------------------
.../fluidsynth/fluidsynth_1.1.8.bb | 19 ++++++++++++++++++
2 files changed, 19 insertions(+), 23 deletions(-)
delete mode 100644 meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb
create mode 100644 meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb
diff --git a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb
deleted file mode 100644
index 88981e4..0000000
--- a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb
+++ /dev/null
@@ -1,23 +0,0 @@
-SUMMARY = "Fluidsynth is a software synthesizer"
-HOMEPAGE = "http://www.fluidsynth.org/"
-SECTION = "libs/multimedia"
-LICENSE = "LGPL-2.0+"
-LIC_FILES_CHKSUM = "file://COPYING;md5=e198e9aac94943d0ec29a7dae8c29416"
-
-DEPENDS = "alsa-lib ncurses glib-2.0"
-
-SRC_URI = "${SOURCEFORGE_MIRROR}/project/${BPN}/${BP}/${BP}.tar.gz"
-SRC_URI[md5sum] = "ae5aca6de824b4173667cbd3a310b263"
-SRC_URI[sha256sum] = "50853391d9ebeda9b4db787efb23f98b1e26b7296dd2bb5d0d96b5bccee2171c"
-
-inherit autotools-brokensep pkgconfig lib_package
-
-PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio', d)}"
-PACKAGECONFIG[sndfile] = "--enable-libsndfile-support,--disable-libsndfile-support,libsndfile1"
-PACKAGECONFIG[jack] = "--enable-jack-support,--disable-jack-support,jack"
-PACKAGECONFIG[pulseaudio] = "--enable-pulse-support,--disable-pulse-support,pulseaudio"
-PACKAGECONFIG[portaudio] = "--enable-portaudio-support,--disable-portaudio-support,portaudio-v19"
-
-do_configure_prepend () {
- rm -f ${S}/m4/*
-}
diff --git a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb
new file mode 100644
index 0000000..754fadc
--- /dev/null
+++ b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb
@@ -0,0 +1,19 @@
+SUMMARY = "Fluidsynth is a software synthesizer"
+HOMEPAGE = "http://www.fluidsynth.org/"
+SECTION = "libs/multimedia"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=fc178bcd425090939a8b634d1d6a9594"
+
+DEPENDS = "alsa-lib ncurses glib-2.0"
+
+SRC_URI = "git://github.com/FluidSynth/fluidsynth.git;branch=1.1.x"
+SRCREV = "12e7afe3a806a6b397f28e0ca4bc6bab9ebe7047"
+S = "${WORKDIR}/git"
+
+inherit cmake pkgconfig lib_package
+
+PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio', d)}"
+PACKAGECONFIG[sndfile] = "-Denable-libsndfile-support=ON,-Denable-libsndfile-support=OFF,libsndfile1"
+PACKAGECONFIG[jack] = "-Denable-jack-support=ON,-Denable-jack-support=OFF,jack"
+PACKAGECONFIG[pulseaudio] = "-Denable-pulseaudio=ON,--Denable-pulseaudio=OFF,pulseaudio"
+PACKAGECONFIG[portaudio] = "-Denable-portaudio=ON,-Denable-portaudio=OFF,portaudio-v19"
--
2.9.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] fluidsynth: update 1.1.6 -> 1.1.8
2017-10-16 10:42 [PATCH] fluidsynth: update 1.1.6 -> 1.1.8 Andreas Müller
@ 2017-10-16 17:40 ` Leonardo Sandoval
2017-10-16 19:44 ` Andreas Müller
0 siblings, 1 reply; 7+ messages in thread
From: Leonardo Sandoval @ 2017-10-16 17:40 UTC (permalink / raw)
To: Andreas Müller; +Cc: openembedded-devel
On Mon, 16 Oct 2017 12:42:28 +0200
Andreas Müller <schnitzeltony@googlemail.com> wrote:
> * project has moved from sourceforge to github
> * autotools was replaced by cmake [1]
Worth noting that license changed from LGPL-2.0+ to LPGL-2.1. In case you send a v2, use a lower -M value for your git-format-patch command, this may detect the rename.
>
> [1] https://github.com/FluidSynth/fluidsynth/commit/3939941c5f3fdaef6bf9258fabd5725e7666554a
>
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
> .../fluidsynth/fluidsynth_1.1.6.bb | 23 ----------------------
> .../fluidsynth/fluidsynth_1.1.8.bb | 19 ++++++++++++++++++
> 2 files changed, 19 insertions(+), 23 deletions(-)
> delete mode 100644 meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb
> create mode 100644 meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb
>
> diff --git a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb
> deleted file mode 100644
> index 88981e4..0000000
> --- a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -SUMMARY = "Fluidsynth is a software synthesizer"
> -HOMEPAGE = "http://www.fluidsynth.org/"
> -SECTION = "libs/multimedia"
> -LICENSE = "LGPL-2.0+"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=e198e9aac94943d0ec29a7dae8c29416"
> -
> -DEPENDS = "alsa-lib ncurses glib-2.0"
> -
> -SRC_URI = "${SOURCEFORGE_MIRROR}/project/${BPN}/${BP}/${BP}.tar.gz"
> -SRC_URI[md5sum] = "ae5aca6de824b4173667cbd3a310b263"
> -SRC_URI[sha256sum] = "50853391d9ebeda9b4db787efb23f98b1e26b7296dd2bb5d0d96b5bccee2171c"
> -
> -inherit autotools-brokensep pkgconfig lib_package
> -
> -PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio', d)}"
> -PACKAGECONFIG[sndfile] = "--enable-libsndfile-support,--disable-libsndfile-support,libsndfile1"
> -PACKAGECONFIG[jack] = "--enable-jack-support,--disable-jack-support,jack"
> -PACKAGECONFIG[pulseaudio] = "--enable-pulse-support,--disable-pulse-support,pulseaudio"
> -PACKAGECONFIG[portaudio] = "--enable-portaudio-support,--disable-portaudio-support,portaudio-v19"
> -
> -do_configure_prepend () {
> - rm -f ${S}/m4/*
> -}
> diff --git a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb
> new file mode 100644
> index 0000000..754fadc
> --- /dev/null
> +++ b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb
> @@ -0,0 +1,19 @@
> +SUMMARY = "Fluidsynth is a software synthesizer"
> +HOMEPAGE = "http://www.fluidsynth.org/"
> +SECTION = "libs/multimedia"
> +LICENSE = "LGPL-2.1"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=fc178bcd425090939a8b634d1d6a9594"
> +
> +DEPENDS = "alsa-lib ncurses glib-2.0"
> +
> +SRC_URI = "git://github.com/FluidSynth/fluidsynth.git;branch=1.1.x"
> +SRCREV = "12e7afe3a806a6b397f28e0ca4bc6bab9ebe7047"
> +S = "${WORKDIR}/git"
> +
> +inherit cmake pkgconfig lib_package
> +
> +PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio', d)}"
> +PACKAGECONFIG[sndfile] = "-Denable-libsndfile-support=ON,-Denable-libsndfile-support=OFF,libsndfile1"
> +PACKAGECONFIG[jack] = "-Denable-jack-support=ON,-Denable-jack-support=OFF,jack"
> +PACKAGECONFIG[pulseaudio] = "-Denable-pulseaudio=ON,--Denable-pulseaudio=OFF,pulseaudio"
> +PACKAGECONFIG[portaudio] = "-Denable-portaudio=ON,-Denable-portaudio=OFF,portaudio-v19"
> --
> 2.9.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fluidsynth: update 1.1.6 -> 1.1.8
2017-10-16 17:40 ` Leonardo Sandoval
@ 2017-10-16 19:44 ` Andreas Müller
2017-10-16 21:05 ` Leonardo Sandoval
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Müller @ 2017-10-16 19:44 UTC (permalink / raw)
To: Leonardo Sandoval; +Cc: openembedded-devel@lists.openembedded.org
On Mon, Oct 16, 2017 at 7:40 PM, Leonardo Sandoval <
leonardo.sandoval.gonzalez@linux.intel.com> wrote:
> On Mon, 16 Oct 2017 12:42:28 +0200
> Andreas Müller <schnitzeltony@googlemail.com> wrote:
>
> > * project has moved from sourceforge to github
> > * autotools was replaced by cmake [1]
>
> Worth noting that license changed from LGPL-2.0+ to LPGL-2.1.
Yes I forgot to mention
> In case you send a v2, use a lower -M value for your git-format-patch
> command, this may detect the rename.
>
I have
[diff]
renames = true
in my .gitconfig which does this job fine usually. I think rename due to
changes in almost all lines.
V2 required?
Andreas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fluidsynth: update 1.1.6 -> 1.1.8
2017-10-16 21:05 ` Leonardo Sandoval
@ 2017-10-16 20:58 ` Martin Jansa
2017-10-17 10:28 ` Martin Jansa
0 siblings, 1 reply; 7+ messages in thread
From: Martin Jansa @ 2017-10-16 20:58 UTC (permalink / raw)
To: Leonardo Sandoval; +Cc: openembedded-devel@lists.openembedded.org
It's already in master-next, if it builds fine, I don't require v2 to be
sent.
On Mon, Oct 16, 2017 at 11:05 PM, Leonardo Sandoval <
leonardo.sandoval.gonzalez@linux.intel.com> wrote:
> On Mon, 16 Oct 2017 21:44:23 +0200
> Andreas Müller <schnitzeltony@googlemail.com> wrote:
>
> > On Mon, Oct 16, 2017 at 7:40 PM, Leonardo Sandoval <
> > leonardo.sandoval.gonzalez@linux.intel.com> wrote:
> >
> > > On Mon, 16 Oct 2017 12:42:28 +0200
> > > Andreas Müller <schnitzeltony@googlemail.com> wrote:
> > >
> > > > * project has moved from sourceforge to github
> > > > * autotools was replaced by cmake [1]
> > >
> > > Worth noting that license changed from LGPL-2.0+ to LPGL-2.1.
> >
> > Yes I forgot to mention
> >
> > > In case you send a v2, use a lower -M value for your git-format-patch
> > > command, this may detect the rename.
> > >
> > I have
> >
> > [diff]
> > renames = true
>
> I use git-format-patch which by defaults does renames with 50 of
> similarity index (defined by -M). I believe there is a git-diff-config for
> the latter value.
>
> >
> > in my .gitconfig which does this job fine usually. I think rename due to
> > changes in almost all lines.
> >
> > V2 required?
>
> worth it in my opinion.
>
> I just format your patch with the -M2 and this is the output, indicating
> that lots of stuff change but makes it easier to read.
>
> diff --git a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsyn
> th_1.1.6.bb b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsyn
> th_1.1.8.bb
> similarity index 23%
> rename from meta-multimedia/recipes-multimedia/fluidsynth/fluidsyn
> th_1.1.6.bb
> rename to meta-multimedia/recipes-multimedia/fluidsynth/fluidsyn
> th_1.1.8.bb
> index 88981e44b..754fadc2e 100644
> --- a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb
> +++ b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb
> @@ -1,23 +1,19 @@
> SUMMARY = "Fluidsynth is a software synthesizer"
> HOMEPAGE = "http://www.fluidsynth.org/"
> SECTION = "libs/multimedia"
> -LICENSE = "LGPL-2.0+"
> -LIC_FILES_CHKSUM = "file://COPYING;md5=e198e9aac94943d0ec29a7dae8c29416"
> +LICENSE = "LGPL-2.1"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=fc178bcd425090939a8b634d1d6a9594"
>
> DEPENDS = "alsa-lib ncurses glib-2.0"
>
> -SRC_URI = "${SOURCEFORGE_MIRROR}/project/${BPN}/${BP}/${BP}.tar.gz"
> -SRC_URI[md5sum] = "ae5aca6de824b4173667cbd3a310b263"
> -SRC_URI[sha256sum] = "50853391d9ebeda9b4db787efb23f9
> 8b1e26b7296dd2bb5d0d96b5bccee2171c"
> +SRC_URI = "git://github.com/FluidSynth/fluidsynth.git;branch=1.1.x"
> +SRCREV = "12e7afe3a806a6b397f28e0ca4bc6bab9ebe7047"
> +S = "${WORKDIR}/git"
>
> -inherit autotools-brokensep pkgconfig lib_package
> +inherit cmake pkgconfig lib_package
>
> PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio',
> d)}"
> -PACKAGECONFIG[sndfile] = "--enable-libsndfile-support,-
> -disable-libsndfile-support,libsndfile1"
> -PACKAGECONFIG[jack] = "--enable-jack-support,--disable-jack-support,jack"
> -PACKAGECONFIG[pulseaudio] = "--enable-pulse-support,--
> disable-pulse-support,pulseaudio"
> -PACKAGECONFIG[portaudio] = "--enable-portaudio-support,--
> disable-portaudio-support,portaudio-v19"
> -
> -do_configure_prepend () {
> - rm -f ${S}/m4/*
> -}
> +PACKAGECONFIG[sndfile] = "-Denable-libsndfile-support=
> ON,-Denable-libsndfile-support=OFF,libsndfile1"
> +PACKAGECONFIG[jack] = "-Denable-jack-support=ON,-
> Denable-jack-support=OFF,jack"
> +PACKAGECONFIG[pulseaudio] = "-Denable-pulseaudio=ON,--
> Denable-pulseaudio=OFF,pulseaudio"
> +PACKAGECONFIG[portaudio] = "-Denable-portaudio=ON,-Denable-portaudio=OFF,
> portaudio-v19"
>
>
>
> >
> > Andreas
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
> --
> Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fluidsynth: update 1.1.6 -> 1.1.8
2017-10-16 19:44 ` Andreas Müller
@ 2017-10-16 21:05 ` Leonardo Sandoval
2017-10-16 20:58 ` Martin Jansa
0 siblings, 1 reply; 7+ messages in thread
From: Leonardo Sandoval @ 2017-10-16 21:05 UTC (permalink / raw)
To: Andreas Müller; +Cc: openembedded-devel@lists.openembedded.org
On Mon, 16 Oct 2017 21:44:23 +0200
Andreas Müller <schnitzeltony@googlemail.com> wrote:
> On Mon, Oct 16, 2017 at 7:40 PM, Leonardo Sandoval <
> leonardo.sandoval.gonzalez@linux.intel.com> wrote:
>
> > On Mon, 16 Oct 2017 12:42:28 +0200
> > Andreas Müller <schnitzeltony@googlemail.com> wrote:
> >
> > > * project has moved from sourceforge to github
> > > * autotools was replaced by cmake [1]
> >
> > Worth noting that license changed from LGPL-2.0+ to LPGL-2.1.
>
> Yes I forgot to mention
>
> > In case you send a v2, use a lower -M value for your git-format-patch
> > command, this may detect the rename.
> >
> I have
>
> [diff]
> renames = true
I use git-format-patch which by defaults does renames with 50 of similarity index (defined by -M). I believe there is a git-diff-config for the latter value.
>
> in my .gitconfig which does this job fine usually. I think rename due to
> changes in almost all lines.
>
> V2 required?
worth it in my opinion.
I just format your patch with the -M2 and this is the output, indicating that lots of stuff change but makes it easier to read.
diff --git a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb
similarity index 23%
rename from meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb
rename to meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb
index 88981e44b..754fadc2e 100644
--- a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb
+++ b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb
@@ -1,23 +1,19 @@
SUMMARY = "Fluidsynth is a software synthesizer"
HOMEPAGE = "http://www.fluidsynth.org/"
SECTION = "libs/multimedia"
-LICENSE = "LGPL-2.0+"
-LIC_FILES_CHKSUM = "file://COPYING;md5=e198e9aac94943d0ec29a7dae8c29416"
+LICENSE = "LGPL-2.1"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=fc178bcd425090939a8b634d1d6a9594"
DEPENDS = "alsa-lib ncurses glib-2.0"
-SRC_URI = "${SOURCEFORGE_MIRROR}/project/${BPN}/${BP}/${BP}.tar.gz"
-SRC_URI[md5sum] = "ae5aca6de824b4173667cbd3a310b263"
-SRC_URI[sha256sum] = "50853391d9ebeda9b4db787efb23f98b1e26b7296dd2bb5d0d96b5bccee2171c"
+SRC_URI = "git://github.com/FluidSynth/fluidsynth.git;branch=1.1.x"
+SRCREV = "12e7afe3a806a6b397f28e0ca4bc6bab9ebe7047"
+S = "${WORKDIR}/git"
-inherit autotools-brokensep pkgconfig lib_package
+inherit cmake pkgconfig lib_package
PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio', d)}"
-PACKAGECONFIG[sndfile] = "--enable-libsndfile-support,--disable-libsndfile-support,libsndfile1"
-PACKAGECONFIG[jack] = "--enable-jack-support,--disable-jack-support,jack"
-PACKAGECONFIG[pulseaudio] = "--enable-pulse-support,--disable-pulse-support,pulseaudio"
-PACKAGECONFIG[portaudio] = "--enable-portaudio-support,--disable-portaudio-support,portaudio-v19"
-
-do_configure_prepend () {
- rm -f ${S}/m4/*
-}
+PACKAGECONFIG[sndfile] = "-Denable-libsndfile-support=ON,-Denable-libsndfile-support=OFF,libsndfile1"
+PACKAGECONFIG[jack] = "-Denable-jack-support=ON,-Denable-jack-support=OFF,jack"
+PACKAGECONFIG[pulseaudio] = "-Denable-pulseaudio=ON,--Denable-pulseaudio=OFF,pulseaudio"
+PACKAGECONFIG[portaudio] = "-Denable-portaudio=ON,-Denable-portaudio=OFF,portaudio-v19"
>
> Andreas
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] fluidsynth: update 1.1.6 -> 1.1.8
2017-10-16 20:58 ` Martin Jansa
@ 2017-10-17 10:28 ` Martin Jansa
2017-10-17 10:37 ` Andreas Müller
0 siblings, 1 reply; 7+ messages in thread
From: Martin Jansa @ 2017-10-17 10:28 UTC (permalink / raw)
To: Leonardo Sandoval; +Cc: openembedded-devel@lists.openembedded.org
[-- Attachment #1: Type: text/plain, Size: 4764 bytes --]
On Mon, Oct 16, 2017 at 10:58:16PM +0200, Martin Jansa wrote:
> It's already in master-next, if it builds fine, I don't require v2 to be
> sent.
Unfortunately it fails to build for qemux86-64, so v2 will be needed
http://errors.yoctoproject.org/Errors/Details/157327/
>
> On Mon, Oct 16, 2017 at 11:05 PM, Leonardo Sandoval <
> leonardo.sandoval.gonzalez@linux.intel.com> wrote:
>
> > On Mon, 16 Oct 2017 21:44:23 +0200
> > Andreas Müller <schnitzeltony@googlemail.com> wrote:
> >
> > > On Mon, Oct 16, 2017 at 7:40 PM, Leonardo Sandoval <
> > > leonardo.sandoval.gonzalez@linux.intel.com> wrote:
> > >
> > > > On Mon, 16 Oct 2017 12:42:28 +0200
> > > > Andreas Müller <schnitzeltony@googlemail.com> wrote:
> > > >
> > > > > * project has moved from sourceforge to github
> > > > > * autotools was replaced by cmake [1]
> > > >
> > > > Worth noting that license changed from LGPL-2.0+ to LPGL-2.1.
> > >
> > > Yes I forgot to mention
> > >
> > > > In case you send a v2, use a lower -M value for your git-format-patch
> > > > command, this may detect the rename.
> > > >
> > > I have
> > >
> > > [diff]
> > > renames = true
> >
> > I use git-format-patch which by defaults does renames with 50 of
> > similarity index (defined by -M). I believe there is a git-diff-config for
> > the latter value.
> >
> > >
> > > in my .gitconfig which does this job fine usually. I think rename due to
> > > changes in almost all lines.
> > >
> > > V2 required?
> >
> > worth it in my opinion.
> >
> > I just format your patch with the -M2 and this is the output, indicating
> > that lots of stuff change but makes it easier to read.
> >
> > diff --git a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsyn
> > th_1.1.6.bb b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsyn
> > th_1.1.8.bb
> > similarity index 23%
> > rename from meta-multimedia/recipes-multimedia/fluidsynth/fluidsyn
> > th_1.1.6.bb
> > rename to meta-multimedia/recipes-multimedia/fluidsynth/fluidsyn
> > th_1.1.8.bb
> > index 88981e44b..754fadc2e 100644
> > --- a/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.6.bb
> > +++ b/meta-multimedia/recipes-multimedia/fluidsynth/fluidsynth_1.1.8.bb
> > @@ -1,23 +1,19 @@
> > SUMMARY = "Fluidsynth is a software synthesizer"
> > HOMEPAGE = "http://www.fluidsynth.org/"
> > SECTION = "libs/multimedia"
> > -LICENSE = "LGPL-2.0+"
> > -LIC_FILES_CHKSUM = "file://COPYING;md5=e198e9aac94943d0ec29a7dae8c29416"
> > +LICENSE = "LGPL-2.1"
> > +LIC_FILES_CHKSUM = "file://LICENSE;md5=fc178bcd425090939a8b634d1d6a9594"
> >
> > DEPENDS = "alsa-lib ncurses glib-2.0"
> >
> > -SRC_URI = "${SOURCEFORGE_MIRROR}/project/${BPN}/${BP}/${BP}.tar.gz"
> > -SRC_URI[md5sum] = "ae5aca6de824b4173667cbd3a310b263"
> > -SRC_URI[sha256sum] = "50853391d9ebeda9b4db787efb23f9
> > 8b1e26b7296dd2bb5d0d96b5bccee2171c"
> > +SRC_URI = "git://github.com/FluidSynth/fluidsynth.git;branch=1.1.x"
> > +SRCREV = "12e7afe3a806a6b397f28e0ca4bc6bab9ebe7047"
> > +S = "${WORKDIR}/git"
> >
> > -inherit autotools-brokensep pkgconfig lib_package
> > +inherit cmake pkgconfig lib_package
> >
> > PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio',
> > d)}"
> > -PACKAGECONFIG[sndfile] = "--enable-libsndfile-support,-
> > -disable-libsndfile-support,libsndfile1"
> > -PACKAGECONFIG[jack] = "--enable-jack-support,--disable-jack-support,jack"
> > -PACKAGECONFIG[pulseaudio] = "--enable-pulse-support,--
> > disable-pulse-support,pulseaudio"
> > -PACKAGECONFIG[portaudio] = "--enable-portaudio-support,--
> > disable-portaudio-support,portaudio-v19"
> > -
> > -do_configure_prepend () {
> > - rm -f ${S}/m4/*
> > -}
> > +PACKAGECONFIG[sndfile] = "-Denable-libsndfile-support=
> > ON,-Denable-libsndfile-support=OFF,libsndfile1"
> > +PACKAGECONFIG[jack] = "-Denable-jack-support=ON,-
> > Denable-jack-support=OFF,jack"
> > +PACKAGECONFIG[pulseaudio] = "-Denable-pulseaudio=ON,--
> > Denable-pulseaudio=OFF,pulseaudio"
> > +PACKAGECONFIG[portaudio] = "-Denable-portaudio=ON,-Denable-portaudio=OFF,
> > portaudio-v19"
> >
> >
> >
> > >
> > > Andreas
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> >
> > --
> > Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fluidsynth: update 1.1.6 -> 1.1.8
2017-10-17 10:28 ` Martin Jansa
@ 2017-10-17 10:37 ` Andreas Müller
0 siblings, 0 replies; 7+ messages in thread
From: Andreas Müller @ 2017-10-17 10:37 UTC (permalink / raw)
To: Martin Jansa; +Cc: Leonardo Sandoval, openembedded-devel@lists.openembedded.org
On Tue, Oct 17, 2017 at 12:28 PM, Martin Jansa <martin.jansa@gmail.com>
wrote:
> On Mon, Oct 16, 2017 at 10:58:16PM +0200, Martin Jansa wrote:
> > It's already in master-next, if it builds fine, I don't require v2 to be
> > sent.
>
> Unfortunately it fails to build for qemux86-64, so v2 will be needed
> http://errors.yoctoproject.org/Errors/Details/157327/
>
> With -M <small number> :)
Andreas
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-10-17 10:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-16 10:42 [PATCH] fluidsynth: update 1.1.6 -> 1.1.8 Andreas Müller
2017-10-16 17:40 ` Leonardo Sandoval
2017-10-16 19:44 ` Andreas Müller
2017-10-16 21:05 ` Leonardo Sandoval
2017-10-16 20:58 ` Martin Jansa
2017-10-17 10:28 ` Martin Jansa
2017-10-17 10:37 ` Andreas Müller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.