* [meta-oe][PATCH] mraa/upm: enable nodejs bindings by default @ 2017-10-11 7:35 Mikko Ylinen 2017-10-15 23:14 ` Martin Jansa 0 siblings, 1 reply; 10+ messages in thread From: Mikko Ylinen @ 2017-10-11 7:35 UTC (permalink / raw) To: openembedded-devel HAVE_NODEJS is a leftover from meta-refkit-core where the layer had to adapt to different BBLAYER combinations (some where nodejs wasn't available but mraa/upm were). Since that check is no longer needed and nodejs is in fact part of meta-oe, nodejs bindings can be enabled by default. Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com> --- meta-oe/recipes-extended/mraa/mraa_git.bb | 2 +- meta-oe/recipes-extended/upm/upm_git.bb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meta-oe/recipes-extended/mraa/mraa_git.bb b/meta-oe/recipes-extended/mraa/mraa_git.bb index 616048fac..56557cca8 100644 --- a/meta-oe/recipes-extended/mraa/mraa_git.bb +++ b/meta-oe/recipes-extended/mraa/mraa_git.bb @@ -31,7 +31,7 @@ FILES_${PN}-utils = "${bindir}/" # override this in local.conf to get needed bindings. # BINDINGS_pn-mraa="python" # will result in only the python bindings being built/packaged. -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS') or '0') else '' }" +BINDINGS ??= "python nodejs" PACKAGECONFIG ??= "${@bb.utils.contains('PACKAGES', 'node-${PN}', 'nodejs', '', d)} \ ${@bb.utils.contains('PACKAGES', '${PYTHON_PN}-${PN}', 'python', '', d)}" diff --git a/meta-oe/recipes-extended/upm/upm_git.bb b/meta-oe/recipes-extended/upm/upm_git.bb index 38065ce53..a258ac8b2 100644 --- a/meta-oe/recipes-extended/upm/upm_git.bb +++ b/meta-oe/recipes-extended/upm/upm_git.bb @@ -26,7 +26,7 @@ inherit distutils3-base cmake # override this in local.conf to get needed bindings. # BINDINGS_pn-upm="python" # will result in only the python bindings being built/packaged. -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS') or '0') else '' }" +BINDINGS ??= "python nodejs" PACKAGECONFIG ??= "${@bb.utils.contains('PACKAGES', 'node-${PN}', 'nodejs', '', d)} \ ${@bb.utils.contains('PACKAGES', '${PYTHON_PN}-${PN}', 'python', '', d)}" -- 2.11.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [meta-oe][PATCH] mraa/upm: enable nodejs bindings by default 2017-10-11 7:35 [meta-oe][PATCH] mraa/upm: enable nodejs bindings by default Mikko Ylinen @ 2017-10-15 23:14 ` Martin Jansa 2017-10-17 10:35 ` [meta-oe][PATCH v2] " Mikko Ylinen 0 siblings, 1 reply; 10+ messages in thread From: Martin Jansa @ 2017-10-15 23:14 UTC (permalink / raw) To: Mikko Ylinen; +Cc: openembedded-devel Breaks qemuarm builds: NOTE: Resolving any missing task queue dependencies ERROR: Nothing RPROVIDES 'nodejs' (but /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/mraa/mraa_git.bb, /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/upm/upm_git.bb RDEPENDS on or otherwise requires it) nodejs was skipped: incompatible with machine qemuarm (not in COMPATIBLE_MACHINE) NOTE: Runtime target 'nodejs' is unbuildable, removing... Missing or unbuildable dependency chain was: ['nodejs'] NOTE: Runtime target 'upm-dev' is unbuildable, removing... Missing or unbuildable dependency chain was: ['upm-dev', 'mraa', 'nodejs'] NOTE: Runtime target 'upm' is unbuildable, removing... Missing or unbuildable dependency chain was: ['upm', 'mraa', 'nodejs'] NOTE: Runtime target 'mraa' is unbuildable, removing... Missing or unbuildable dependency chain was: ['mraa', 'nodejs'] ERROR: Nothing RPROVIDES 'mraa-dev' (but /home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/mraa/mraa_git.bb RDEPENDS on or otherwise requires it) No eligible RPROVIDERs exist for 'mraa-dev' NOTE: Runtime target 'mraa-dev' is unbuildable, removing... Missing or unbuildable dependency chain was: ['mraa-dev'] On Wed, Oct 11, 2017 at 9:35 AM, Mikko Ylinen <mikko.ylinen@linux.intel.com> wrote: > HAVE_NODEJS is a leftover from meta-refkit-core where the > layer had to adapt to different BBLAYER combinations (some > where nodejs wasn't available but mraa/upm were). > > Since that check is no longer needed and nodejs is in fact > part of meta-oe, nodejs bindings can be enabled by default. > > Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com> > --- > meta-oe/recipes-extended/mraa/mraa_git.bb | 2 +- > meta-oe/recipes-extended/upm/upm_git.bb | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta-oe/recipes-extended/mraa/mraa_git.bb > b/meta-oe/recipes-extended/mraa/mraa_git.bb > index 616048fac..56557cca8 100644 > --- a/meta-oe/recipes-extended/mraa/mraa_git.bb > +++ b/meta-oe/recipes-extended/mraa/mraa_git.bb > @@ -31,7 +31,7 @@ FILES_${PN}-utils = "${bindir}/" > # override this in local.conf to get needed bindings. > # BINDINGS_pn-mraa="python" > # will result in only the python bindings being built/packaged. > -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS') > or '0') else '' }" > +BINDINGS ??= "python nodejs" > > PACKAGECONFIG ??= "${@bb.utils.contains('PACKAGES', 'node-${PN}', > 'nodejs', '', d)} \ > ${@bb.utils.contains('PACKAGES', '${PYTHON_PN}-${PN}', 'python', '', > d)}" > diff --git a/meta-oe/recipes-extended/upm/upm_git.bb > b/meta-oe/recipes-extended/upm/upm_git.bb > index 38065ce53..a258ac8b2 100644 > --- a/meta-oe/recipes-extended/upm/upm_git.bb > +++ b/meta-oe/recipes-extended/upm/upm_git.bb > @@ -26,7 +26,7 @@ inherit distutils3-base cmake > # override this in local.conf to get needed bindings. > # BINDINGS_pn-upm="python" > # will result in only the python bindings being built/packaged. > -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS') > or '0') else '' }" > +BINDINGS ??= "python nodejs" > > PACKAGECONFIG ??= "${@bb.utils.contains('PACKAGES', 'node-${PN}', > 'nodejs', '', d)} \ > ${@bb.utils.contains('PACKAGES', '${PYTHON_PN}-${PN}', 'python', '', > d)}" > -- > 2.11.0 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > ^ permalink raw reply [flat|nested] 10+ messages in thread
* [meta-oe][PATCH v2] mraa/upm: enable nodejs bindings by default 2017-10-15 23:14 ` Martin Jansa @ 2017-10-17 10:35 ` Mikko Ylinen 2017-10-17 10:51 ` Martin Jansa 0 siblings, 1 reply; 10+ messages in thread From: Mikko Ylinen @ 2017-10-17 10:35 UTC (permalink / raw) To: openembedded-devel HAVE_NODEJS is a leftover from meta-refkit-core where the layer had to adapt to different BBLAYER combinations (some where nodejs wasn't available but mraa/upm were). Since that check is no longer needed and nodejs is in fact part of meta-oe, nodejs bindings can be enabled by default (with an exception for qemuarm/armv5 where nodejs isn't available). Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com> --- meta-oe/recipes-extended/mraa/mraa_git.bb | 5 ++++- meta-oe/recipes-extended/upm/upm_git.bb | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/meta-oe/recipes-extended/mraa/mraa_git.bb b/meta-oe/recipes-extended/mraa/mraa_git.bb index 616048fac..b22691ca4 100644 --- a/meta-oe/recipes-extended/mraa/mraa_git.bb +++ b/meta-oe/recipes-extended/mraa/mraa_git.bb @@ -31,7 +31,10 @@ FILES_${PN}-utils = "${bindir}/" # override this in local.conf to get needed bindings. # BINDINGS_pn-mraa="python" # will result in only the python bindings being built/packaged. -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS') or '0') else '' }" +BINDINGS ??= "python nodejs" + +# nodejs isn't available for armv5 architecture +BINDINGS_qemuarm ??= "python" PACKAGECONFIG ??= "${@bb.utils.contains('PACKAGES', 'node-${PN}', 'nodejs', '', d)} \ ${@bb.utils.contains('PACKAGES', '${PYTHON_PN}-${PN}', 'python', '', d)}" diff --git a/meta-oe/recipes-extended/upm/upm_git.bb b/meta-oe/recipes-extended/upm/upm_git.bb index 38065ce53..eea5ae80a 100644 --- a/meta-oe/recipes-extended/upm/upm_git.bb +++ b/meta-oe/recipes-extended/upm/upm_git.bb @@ -26,7 +26,10 @@ inherit distutils3-base cmake # override this in local.conf to get needed bindings. # BINDINGS_pn-upm="python" # will result in only the python bindings being built/packaged. -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS') or '0') else '' }" +BINDINGS ??= "python nodejs" + +# nodejs isn't available for armv5 architecture +BINDINGS_qemuarm ??= "python" PACKAGECONFIG ??= "${@bb.utils.contains('PACKAGES', 'node-${PN}', 'nodejs', '', d)} \ ${@bb.utils.contains('PACKAGES', '${PYTHON_PN}-${PN}', 'python', '', d)}" -- 2.11.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [meta-oe][PATCH v2] mraa/upm: enable nodejs bindings by default 2017-10-17 10:35 ` [meta-oe][PATCH v2] " Mikko Ylinen @ 2017-10-17 10:51 ` Martin Jansa 2017-10-17 11:55 ` [meta-oe][PATCH v3] " Mikko Ylinen 0 siblings, 1 reply; 10+ messages in thread From: Martin Jansa @ 2017-10-17 10:51 UTC (permalink / raw) To: Mikko Ylinen; +Cc: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 2778 bytes --] On Tue, Oct 17, 2017 at 01:35:15PM +0300, Mikko Ylinen wrote: > HAVE_NODEJS is a leftover from meta-refkit-core where the > layer had to adapt to different BBLAYER combinations (some > where nodejs wasn't available but mraa/upm were). > > Since that check is no longer needed and nodejs is in fact > part of meta-oe, nodejs bindings can be enabled by default > (with an exception for qemuarm/armv5 where nodejs isn't > available). > > Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com> > --- > meta-oe/recipes-extended/mraa/mraa_git.bb | 5 ++++- > meta-oe/recipes-extended/upm/upm_git.bb | 5 ++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/meta-oe/recipes-extended/mraa/mraa_git.bb b/meta-oe/recipes-extended/mraa/mraa_git.bb > index 616048fac..b22691ca4 100644 > --- a/meta-oe/recipes-extended/mraa/mraa_git.bb > +++ b/meta-oe/recipes-extended/mraa/mraa_git.bb > @@ -31,7 +31,10 @@ FILES_${PN}-utils = "${bindir}/" > # override this in local.conf to get needed bindings. > # BINDINGS_pn-mraa="python" > # will result in only the python bindings being built/packaged. > -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS') or '0') else '' }" > +BINDINGS ??= "python nodejs" > + > +# nodejs isn't available for armv5 architecture > +BINDINGS_qemuarm ??= "python" qemuarm isn't the only armv4 and armv5 MACHINE OE supports, use the same 3 overrides nodejs recipe is using. > PACKAGECONFIG ??= "${@bb.utils.contains('PACKAGES', 'node-${PN}', 'nodejs', '', d)} \ > ${@bb.utils.contains('PACKAGES', '${PYTHON_PN}-${PN}', 'python', '', d)}" > diff --git a/meta-oe/recipes-extended/upm/upm_git.bb b/meta-oe/recipes-extended/upm/upm_git.bb > index 38065ce53..eea5ae80a 100644 > --- a/meta-oe/recipes-extended/upm/upm_git.bb > +++ b/meta-oe/recipes-extended/upm/upm_git.bb > @@ -26,7 +26,10 @@ inherit distutils3-base cmake > # override this in local.conf to get needed bindings. > # BINDINGS_pn-upm="python" > # will result in only the python bindings being built/packaged. > -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS') or '0') else '' }" > +BINDINGS ??= "python nodejs" > + > +# nodejs isn't available for armv5 architecture > +BINDINGS_qemuarm ??= "python" > > PACKAGECONFIG ??= "${@bb.utils.contains('PACKAGES', 'node-${PN}', 'nodejs', '', d)} \ > ${@bb.utils.contains('PACKAGES', '${PYTHON_PN}-${PN}', 'python', '', d)}" > -- > 2.11.0 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 201 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [meta-oe][PATCH v3] mraa/upm: enable nodejs bindings by default 2017-10-17 10:51 ` Martin Jansa @ 2017-10-17 11:55 ` Mikko Ylinen 2017-10-17 12:07 ` Martin Jansa 0 siblings, 1 reply; 10+ messages in thread From: Mikko Ylinen @ 2017-10-17 11:55 UTC (permalink / raw) To: openembedded-devel HAVE_NODEJS is a leftover from meta-refkit-core where the layer had to adapt to different BBLAYER combinations (some where nodejs wasn't available but mraa/upm were). Since that check is no longer needed and nodejs is in fact part of meta-oe, nodejs bindings can be enabled by default (with exceptions for armv4 and armv5 where nodejs isn't available). Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com> --- meta-oe/recipes-extended/mraa/mraa_git.bb | 6 +++++- meta-oe/recipes-extended/upm/upm_git.bb | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/meta-oe/recipes-extended/mraa/mraa_git.bb b/meta-oe/recipes-extended/mraa/mraa_git.bb index 616048fac..b93fd72c8 100644 --- a/meta-oe/recipes-extended/mraa/mraa_git.bb +++ b/meta-oe/recipes-extended/mraa/mraa_git.bb @@ -31,7 +31,11 @@ FILES_${PN}-utils = "${bindir}/" # override this in local.conf to get needed bindings. # BINDINGS_pn-mraa="python" # will result in only the python bindings being built/packaged. -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS') or '0') else '' }" +BINDINGS ??= "python nodejs" + +# nodejs isn't available for armv4/armv5 architectures +BINDINGS_armv4 ??= "python" +BINDINGS_armv5 ??= "python" PACKAGECONFIG ??= "${@bb.utils.contains('PACKAGES', 'node-${PN}', 'nodejs', '', d)} \ ${@bb.utils.contains('PACKAGES', '${PYTHON_PN}-${PN}', 'python', '', d)}" diff --git a/meta-oe/recipes-extended/upm/upm_git.bb b/meta-oe/recipes-extended/upm/upm_git.bb index 38065ce53..da1e4add5 100644 --- a/meta-oe/recipes-extended/upm/upm_git.bb +++ b/meta-oe/recipes-extended/upm/upm_git.bb @@ -26,7 +26,11 @@ inherit distutils3-base cmake # override this in local.conf to get needed bindings. # BINDINGS_pn-upm="python" # will result in only the python bindings being built/packaged. -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS') or '0') else '' }" +BINDINGS ??= "python nodejs" + +# nodejs isn't available for armv4/armv5 architectures +BINDINGS_armv4 ??= "python" +BINDINGS_armv5 ??= "python" PACKAGECONFIG ??= "${@bb.utils.contains('PACKAGES', 'node-${PN}', 'nodejs', '', d)} \ ${@bb.utils.contains('PACKAGES', '${PYTHON_PN}-${PN}', 'python', '', d)}" -- 2.11.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [meta-oe][PATCH v3] mraa/upm: enable nodejs bindings by default 2017-10-17 11:55 ` [meta-oe][PATCH v3] " Mikko Ylinen @ 2017-10-17 12:07 ` Martin Jansa 2017-10-17 12:12 ` Mikko Ylinen 0 siblings, 1 reply; 10+ messages in thread From: Martin Jansa @ 2017-10-17 12:07 UTC (permalink / raw) To: Mikko Ylinen; +Cc: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 2776 bytes --] On Tue, Oct 17, 2017 at 02:55:39PM +0300, Mikko Ylinen wrote: > HAVE_NODEJS is a leftover from meta-refkit-core where the > layer had to adapt to different BBLAYER combinations (some > where nodejs wasn't available but mraa/upm were). > > Since that check is no longer needed and nodejs is in fact > part of meta-oe, nodejs bindings can be enabled by default > (with exceptions for armv4 and armv5 where nodejs isn't > available). > > Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com> > --- > meta-oe/recipes-extended/mraa/mraa_git.bb | 6 +++++- > meta-oe/recipes-extended/upm/upm_git.bb | 6 +++++- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/meta-oe/recipes-extended/mraa/mraa_git.bb b/meta-oe/recipes-extended/mraa/mraa_git.bb > index 616048fac..b93fd72c8 100644 > --- a/meta-oe/recipes-extended/mraa/mraa_git.bb > +++ b/meta-oe/recipes-extended/mraa/mraa_git.bb > @@ -31,7 +31,11 @@ FILES_${PN}-utils = "${bindir}/" > # override this in local.conf to get needed bindings. > # BINDINGS_pn-mraa="python" > # will result in only the python bindings being built/packaged. > -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS') or '0') else '' }" > +BINDINGS ??= "python nodejs" > + > +# nodejs isn't available for armv4/armv5 architectures > +BINDINGS_armv4 ??= "python" > +BINDINGS_armv5 ??= "python" Still missing one, aren't you? > PACKAGECONFIG ??= "${@bb.utils.contains('PACKAGES', 'node-${PN}', 'nodejs', '', d)} \ > ${@bb.utils.contains('PACKAGES', '${PYTHON_PN}-${PN}', 'python', '', d)}" > diff --git a/meta-oe/recipes-extended/upm/upm_git.bb b/meta-oe/recipes-extended/upm/upm_git.bb > index 38065ce53..da1e4add5 100644 > --- a/meta-oe/recipes-extended/upm/upm_git.bb > +++ b/meta-oe/recipes-extended/upm/upm_git.bb > @@ -26,7 +26,11 @@ inherit distutils3-base cmake > # override this in local.conf to get needed bindings. > # BINDINGS_pn-upm="python" > # will result in only the python bindings being built/packaged. > -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS') or '0') else '' }" > +BINDINGS ??= "python nodejs" > + > +# nodejs isn't available for armv4/armv5 architectures > +BINDINGS_armv4 ??= "python" > +BINDINGS_armv5 ??= "python" > > PACKAGECONFIG ??= "${@bb.utils.contains('PACKAGES', 'node-${PN}', 'nodejs', '', d)} \ > ${@bb.utils.contains('PACKAGES', '${PYTHON_PN}-${PN}', 'python', '', d)}" > -- > 2.11.0 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 201 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [meta-oe][PATCH v3] mraa/upm: enable nodejs bindings by default 2017-10-17 12:07 ` Martin Jansa @ 2017-10-17 12:12 ` Mikko Ylinen 2017-10-20 22:53 ` Martin Jansa 0 siblings, 1 reply; 10+ messages in thread From: Mikko Ylinen @ 2017-10-17 12:12 UTC (permalink / raw) To: Martin Jansa; +Cc: openembedded-devel Hi, On 17/10/17 15:07, Martin Jansa wrote: > On Tue, Oct 17, 2017 at 02:55:39PM +0300, Mikko Ylinen wrote: >> HAVE_NODEJS is a leftover from meta-refkit-core where the >> layer had to adapt to different BBLAYER combinations (some >> where nodejs wasn't available but mraa/upm were). >> >> Since that check is no longer needed and nodejs is in fact >> part of meta-oe, nodejs bindings can be enabled by default >> (with exceptions for armv4 and armv5 where nodejs isn't >> available). >> >> Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com> >> --- >> meta-oe/recipes-extended/mraa/mraa_git.bb | 6 +++++- >> meta-oe/recipes-extended/upm/upm_git.bb | 6 +++++- >> 2 files changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/meta-oe/recipes-extended/mraa/mraa_git.bb b/meta-oe/recipes-extended/mraa/mraa_git.bb >> index 616048fac..b93fd72c8 100644 >> --- a/meta-oe/recipes-extended/mraa/mraa_git.bb >> +++ b/meta-oe/recipes-extended/mraa/mraa_git.bb >> @@ -31,7 +31,11 @@ FILES_${PN}-utils = "${bindir}/" >> # override this in local.conf to get needed bindings. >> # BINDINGS_pn-mraa="python" >> # will result in only the python bindings being built/packaged. >> -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS') or '0') else '' }" >> +BINDINGS ??= "python nodejs" >> + >> +# nodejs isn't available for armv4/armv5 architectures >> +BINDINGS_armv4 ??= "python" >> +BINDINGS_armv5 ??= "python" > Still missing one, aren't you? > With qemumips64 I got: ERROR: Nothing PROVIDES 'mraa' mraa was skipped: incompatible with host mips64-refkit-linux (not in COMPATIBLE_HOST) So I left it out. -- Mikko ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [meta-oe][PATCH v3] mraa/upm: enable nodejs bindings by default 2017-10-17 12:12 ` Mikko Ylinen @ 2017-10-20 22:53 ` Martin Jansa 2017-10-21 15:39 ` Khem Raj 0 siblings, 1 reply; 10+ messages in thread From: Martin Jansa @ 2017-10-20 22:53 UTC (permalink / raw) To: Mikko Ylinen; +Cc: openembedded-devel Fails to build: http://errors.yoctoproject.org/Errors/Details/157425/ On Tue, Oct 17, 2017 at 2:12 PM, Mikko Ylinen <mikko.ylinen@linux.intel.com> wrote: > Hi, > > > > On 17/10/17 15:07, Martin Jansa wrote: > >> On Tue, Oct 17, 2017 at 02:55:39PM +0300, Mikko Ylinen wrote: >> >>> HAVE_NODEJS is a leftover from meta-refkit-core where the >>> layer had to adapt to different BBLAYER combinations (some >>> where nodejs wasn't available but mraa/upm were). >>> >>> Since that check is no longer needed and nodejs is in fact >>> part of meta-oe, nodejs bindings can be enabled by default >>> (with exceptions for armv4 and armv5 where nodejs isn't >>> available). >>> >>> Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com> >>> --- >>> meta-oe/recipes-extended/mraa/mraa_git.bb | 6 +++++- >>> meta-oe/recipes-extended/upm/upm_git.bb | 6 +++++- >>> 2 files changed, 10 insertions(+), 2 deletions(-) >>> >>> diff --git a/meta-oe/recipes-extended/mraa/mraa_git.bb >>> b/meta-oe/recipes-extended/mraa/mraa_git.bb >>> index 616048fac..b93fd72c8 100644 >>> --- a/meta-oe/recipes-extended/mraa/mraa_git.bb >>> +++ b/meta-oe/recipes-extended/mraa/mraa_git.bb >>> @@ -31,7 +31,11 @@ FILES_${PN}-utils = "${bindir}/" >>> # override this in local.conf to get needed bindings. >>> # BINDINGS_pn-mraa="python" >>> # will result in only the python bindings being built/packaged. >>> -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS') >>> or '0') else '' }" >>> +BINDINGS ??= "python nodejs" >>> + >>> +# nodejs isn't available for armv4/armv5 architectures >>> +BINDINGS_armv4 ??= "python" >>> +BINDINGS_armv5 ??= "python" >>> >> Still missing one, aren't you? >> >> > With qemumips64 I got: > > ERROR: Nothing PROVIDES 'mraa' > mraa was skipped: incompatible with host mips64-refkit-linux (not in > COMPATIBLE_HOST) > > So I left it out. > > -- Mikko > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [meta-oe][PATCH v3] mraa/upm: enable nodejs bindings by default 2017-10-20 22:53 ` Martin Jansa @ 2017-10-21 15:39 ` Khem Raj 2017-10-25 4:42 ` Mikko Ylinen 0 siblings, 1 reply; 10+ messages in thread From: Khem Raj @ 2017-10-21 15:39 UTC (permalink / raw) To: Martin Jansa; +Cc: openembedded-devel On Fri, Oct 20, 2017 at 3:53 PM, Martin Jansa <martin.jansa@gmail.com> wrote: > Fails to build: > http://errors.yoctoproject.org/Errors/Details/157425/ > and fails on musl too http://errors.yoctoproject.org/Errors/Build/47646/ > On Tue, Oct 17, 2017 at 2:12 PM, Mikko Ylinen <mikko.ylinen@linux.intel.com> > wrote: > >> Hi, >> >> >> >> On 17/10/17 15:07, Martin Jansa wrote: >> >>> On Tue, Oct 17, 2017 at 02:55:39PM +0300, Mikko Ylinen wrote: >>> >>>> HAVE_NODEJS is a leftover from meta-refkit-core where the >>>> layer had to adapt to different BBLAYER combinations (some >>>> where nodejs wasn't available but mraa/upm were). >>>> >>>> Since that check is no longer needed and nodejs is in fact >>>> part of meta-oe, nodejs bindings can be enabled by default >>>> (with exceptions for armv4 and armv5 where nodejs isn't >>>> available). >>>> >>>> Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com> >>>> --- >>>> meta-oe/recipes-extended/mraa/mraa_git.bb | 6 +++++- >>>> meta-oe/recipes-extended/upm/upm_git.bb | 6 +++++- >>>> 2 files changed, 10 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/meta-oe/recipes-extended/mraa/mraa_git.bb >>>> b/meta-oe/recipes-extended/mraa/mraa_git.bb >>>> index 616048fac..b93fd72c8 100644 >>>> --- a/meta-oe/recipes-extended/mraa/mraa_git.bb >>>> +++ b/meta-oe/recipes-extended/mraa/mraa_git.bb >>>> @@ -31,7 +31,11 @@ FILES_${PN}-utils = "${bindir}/" >>>> # override this in local.conf to get needed bindings. >>>> # BINDINGS_pn-mraa="python" >>>> # will result in only the python bindings being built/packaged. >>>> -BINDINGS ??= "python ${@ 'nodejs' if oe.types.boolean(d.getVar('HAVE_NODEJS') >>>> or '0') else '' }" >>>> +BINDINGS ??= "python nodejs" >>>> + >>>> +# nodejs isn't available for armv4/armv5 architectures >>>> +BINDINGS_armv4 ??= "python" >>>> +BINDINGS_armv5 ??= "python" >>>> >>> Still missing one, aren't you? >>> >>> >> With qemumips64 I got: >> >> ERROR: Nothing PROVIDES 'mraa' >> mraa was skipped: incompatible with host mips64-refkit-linux (not in >> COMPATIBLE_HOST) >> >> So I left it out. >> >> -- Mikko >> > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [meta-oe][PATCH v3] mraa/upm: enable nodejs bindings by default 2017-10-21 15:39 ` Khem Raj @ 2017-10-25 4:42 ` Mikko Ylinen 0 siblings, 0 replies; 10+ messages in thread From: Mikko Ylinen @ 2017-10-25 4:42 UTC (permalink / raw) To: Khem Raj, Martin Jansa; +Cc: openembedded-devel Hi, On 21/10/17 18:39, Khem Raj wrote: > On Fri, Oct 20, 2017 at 3:53 PM, Martin Jansa <martin.jansa@gmail.com> wrote: >> Fails to build: >> http://errors.yoctoproject.org/Errors/Details/157425/ >> > and fails on musl too > > http://errors.yoctoproject.org/Errors/Build/47646/ > > We've been using nodejs bindings via HAVE_NODEJS but with nodejs 6.x (which I used in my testing too). It looks the errors are because nodejs >7.x- break swig bindings: https://github.com/swig/swig/pull/968 Until oe-core gets the new version of swig, we'll have to keep the nodejs bindings disabled. Let's scratch my previous patches and I'll submit a new one that just cleans out that HAVE_NODEJS leftover. -- Mikko ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-10-25 4:42 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-10-11 7:35 [meta-oe][PATCH] mraa/upm: enable nodejs bindings by default Mikko Ylinen 2017-10-15 23:14 ` Martin Jansa 2017-10-17 10:35 ` [meta-oe][PATCH v2] " Mikko Ylinen 2017-10-17 10:51 ` Martin Jansa 2017-10-17 11:55 ` [meta-oe][PATCH v3] " Mikko Ylinen 2017-10-17 12:07 ` Martin Jansa 2017-10-17 12:12 ` Mikko Ylinen 2017-10-20 22:53 ` Martin Jansa 2017-10-21 15:39 ` Khem Raj 2017-10-25 4:42 ` Mikko Ylinen
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.