From: Thierry Reding <thierry.reding@gmail.com>
To: Jeffy Chen <jeffy.chen@rock-chips.com>
Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
heiko@sntech.de, briannorris@chromium.org, rjw@rjwysocki.net,
dianders@chromium.org, tfiga@chromium.org, broonie@kernel.org,
seanpaul@chromium.org, linux-pwm@vger.kernel.org
Subject: Re: [RFC PATCH v4 7/8] pwm: Add dummy pwmchip for orphan pwms
Date: Tue, 17 Oct 2017 14:40:31 +0200 [thread overview]
Message-ID: <20171017124031.GA27983@ulmo> (raw)
In-Reply-To: <20171017101624.12506-8-jeffy.chen@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
On Tue, Oct 17, 2017 at 06:16:23PM +0800, Jeffy Chen wrote:
> When the pwm driver is unbound while the pwm is still requested, the
> pwm core would not actually remove the pwmchip(return -EBUSY instead).
>
> So it would hold some references to the invalid resources(e.g. pwmchip).
>
> And the customer who requested the pwm would have those references too,
> and may crash the kernel when trying to access them later.
>
> Add a dummy pwmchip, and assign orphan pwms to it to avoid that.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
>
> Changes in v4:
> Fix compile warning.
>
> Changes in v3:
> Assign orphan pwms to dummy pwmchip instead of adding device link in the
> customer driver.
What happened to this? Device links were specifically designed to avoid
situations like these.
A dummy PWM chip doesn't seem like the right solution to this.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-17 12:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 10:16 [RFC PATCH v4 0/8] rockchip: kevin: Enable edp display Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 10:16 ` [RFC PATCH v4 1/8] arm64: dts: rockchip: Enable edp disaplay on kevin Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 10:16 ` [RFC PATCH v4 2/8] drm/rockchip: analogix_dp: Fix error handling path Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 17:57 ` Sean Paul
2017-10-17 17:57 ` Sean Paul
2017-10-17 17:57 ` Sean Paul
2017-10-17 10:16 ` [RFC PATCH v4 3/8] drm/rockchip: dw-mipi-dsi: " Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 18:02 ` Sean Paul
2017-10-17 18:02 ` Sean Paul
2017-10-17 18:02 ` Sean Paul
2017-10-17 10:16 ` [RFC PATCH v4 4/8] drm/rockchip: dw_hdmi: " Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 18:10 ` Sean Paul
2017-10-17 18:10 ` Sean Paul
2017-10-17 18:10 ` Sean Paul
2017-10-19 1:54 ` jeffy
2017-10-19 1:54 ` jeffy
2017-10-19 1:54 ` jeffy
2017-10-17 10:16 ` [RFC PATCH v4 5/8] drm/rockchip: inno_hdmi: " Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 18:18 ` Sean Paul
2017-10-17 18:18 ` Sean Paul
2017-10-17 10:16 ` [RFC PATCH v4 6/8] drm/bridge/analogix: Do not use device's drvdata Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 18:18 ` Sean Paul
2017-10-17 18:18 ` Sean Paul
2017-10-17 18:18 ` Sean Paul
2017-10-17 23:43 ` Jingoo Han
2017-10-17 23:43 ` Jingoo Han
2017-10-17 23:43 ` Jingoo Han
2017-10-18 4:46 ` Archit Taneja
2017-10-18 4:46 ` Archit Taneja
2017-10-18 4:46 ` Archit Taneja
2017-10-17 10:16 ` [RFC PATCH v4 7/8] pwm: Add dummy pwmchip for orphan pwms Jeffy Chen
2017-10-17 12:40 ` Thierry Reding [this message]
2017-10-17 17:04 ` Brian Norris
2017-10-17 18:24 ` Dmitry Torokhov
2017-10-17 18:46 ` Mark Brown
2017-10-17 18:53 ` Brian Norris
2017-10-17 19:05 ` Mark Brown
2017-10-18 5:16 ` jeffy
2017-10-17 10:16 ` [RFC PATCH v4 8/8] drm/rockchip: Add device links for master and components Jeffy Chen
2017-10-17 10:16 ` Jeffy Chen
2017-10-17 18:24 ` Sean Paul
2017-10-17 18:24 ` Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017124031.GA27983@ulmo \
--to=thierry.reding@gmail.com \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=heiko@sntech.de \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=seanpaul@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.