Re: [PATCHv3 4/7] powerpc64: Add .opd based function descriptor dereference

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	James Bottomley <jejb@parisc-linux.org>,
	Helge Deller <deller@gmx.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jessica Yu <jeyu@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
	linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 4/7] powerpc64: Add .opd based function descriptor dereference
Date: Thu, 19 Oct 2017 06:45:04 +0000	[thread overview]
Message-ID: <20171019064504.GD449@jagdpanzerIV> (raw)
In-Reply-To: <20171004092108.GF20084@pathway.suse.cz>

On (10/04/17 11:21), Petr Mladek wrote:
[..]
> > +#ifdef PPC64_ELF_ABI_v1
> > +unsigned long dereference_module_function_descriptor(struct module *mod,
> > +						     unsigned long addr)
> > +{
> > +	if (addr < mod->arch.start_opd || addr >= mod->arch.end_opd)
> > +		return addr;
> > +
> > +	return dereference_function_descriptor(addr);
> > +}
> > +#endif /* PPC64_ELF_ABI_v1 */
> 
> I would personally move this up in the source file. It is related to
> the definition of func_desc() and other functions that are
> also PPC_ELF_ABI-specific.
> 
> Otherwise, it looks good to me.
> 
> Reviewed-by: Petr Mladek <pmladek@suse.com>

OK, will move.

	-ss

WARNING: multiple messages have this Message-ID (diff)

From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	James Bottomley <jejb@parisc-linux.org>,
	Helge Deller <deller@gmx.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jessica Yu <jeyu@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
	linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 4/7] powerpc64: Add .opd based function descriptor dereference
Date: Thu, 19 Oct 2017 15:45:04 +0900	[thread overview]
Message-ID: <20171019064504.GD449@jagdpanzerIV> (raw)
In-Reply-To: <20171004092108.GF20084@pathway.suse.cz>

On (10/04/17 11:21), Petr Mladek wrote:
[..]
> > +#ifdef PPC64_ELF_ABI_v1
> > +unsigned long dereference_module_function_descriptor(struct module *mod,
> > +						     unsigned long addr)
> > +{
> > +	if (addr < mod->arch.start_opd || addr >= mod->arch.end_opd)
> > +		return addr;
> > +
> > +	return dereference_function_descriptor(addr);
> > +}
> > +#endif /* PPC64_ELF_ABI_v1 */
> 
> I would personally move this up in the source file. It is related to
> the definition of func_desc() and other functions that are
> also PPC_ELF_ABI-specific.
> 
> Otherwise, it looks good to me.
> 
> Reviewed-by: Petr Mladek <pmladek@suse.com>

OK, will move.

	-ss

next prev parent reply	other threads:[~2017-10-19  6:45 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-30  2:53 [PATCHv3 0/7] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers Sergey Senozhatsky
2017-09-30  2:53 ` Sergey Senozhatsky
2017-09-30  2:53 ` [PATCHv3 1/7] switch dereference_function_descriptor() to `unsigned long' Sergey Senozhatsky
2017-09-30  2:53   ` Sergey Senozhatsky
2017-10-04  8:24   ` Petr Mladek
2017-10-04  8:24     ` Petr Mladek
2017-10-19  6:50     ` Sergey Senozhatsky
2017-10-19  6:50       ` Sergey Senozhatsky
2017-10-20 13:25       ` Petr Mladek
2017-10-20 13:25         ` Petr Mladek
2017-09-30  2:53 ` [PATCHv3 2/7] sections: split dereference_function_descriptor() Sergey Senozhatsky
2017-09-30  2:53   ` Sergey Senozhatsky
2017-10-04  9:00   ` Petr Mladek
2017-10-04  9:00     ` Petr Mladek
2017-10-19  6:45     ` Sergey Senozhatsky
2017-10-19  6:45       ` Sergey Senozhatsky
2017-09-30  2:53 ` [PATCHv3 3/7] ia64: Add .opd based function descriptor dereference Sergey Senozhatsky
2017-09-30  2:53   ` Sergey Senozhatsky
2017-10-04  9:05   ` Petr Mladek
2017-10-04  9:05     ` Petr Mladek
2017-09-30  2:53 ` [PATCHv3 4/7] powerpc64: " Sergey Senozhatsky
2017-09-30  2:53   ` Sergey Senozhatsky
2017-10-04  9:21   ` Petr Mladek
2017-10-04  9:21     ` Petr Mladek
2017-10-04 11:06     ` Michael Ellerman
2017-10-04 11:06       ` Michael Ellerman
2017-10-19 14:01       ` Sergey Senozhatsky
2017-10-19 14:01         ` Sergey Senozhatsky
2017-10-19  6:45     ` Sergey Senozhatsky [this message]
2017-10-19  6:45       ` Sergey Senozhatsky
2017-09-30  2:53 ` [PATCHv3 5/7] parisc64: " Sergey Senozhatsky
2017-09-30  2:53   ` Sergey Senozhatsky
2017-10-04 10:40   ` Petr Mladek
2017-10-04 10:40     ` Petr Mladek
2017-10-19  6:44     ` Sergey Senozhatsky
2017-10-19  6:44       ` Sergey Senozhatsky
2017-09-30  2:53 ` [PATCHv3 6/7] symbol lookup: use new kernel and module dereference functions Sergey Senozhatsky
2017-09-30  2:53   ` Sergey Senozhatsky
2017-10-04 11:53   ` Petr Mladek
2017-10-04 11:53     ` Petr Mladek
2017-10-19  6:42     ` Sergey Senozhatsky
2017-10-19  6:42       ` Sergey Senozhatsky
2017-10-20 13:08       ` Petr Mladek
2017-10-20 13:08         ` Petr Mladek
2017-10-23  8:38         ` Sergey Senozhatsky
2017-10-23  8:38           ` Sergey Senozhatsky
2017-09-30  2:53 ` [PATCHv3 7/7] checkpatch: add pF/pf deprecation warning Sergey Senozhatsky
2017-09-30  2:53   ` Sergey Senozhatsky
2017-10-04 12:08   ` Petr Mladek
2017-10-04 12:08     ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171019064504.GD449@jagdpanzerIV \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=benh@kernel.crashing.org \
    --cc=deller@gmx.de \
    --cc=fenghua.yu@intel.com \
    --cc=jejb@parisc-linux.org \
    --cc=jeyu@kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.