All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] panel: display: Add support for Mitsubishi aa070mc01 TFT panel
Date: Thu, 19 Oct 2017 10:15:10 +0200	[thread overview]
Message-ID: <20171019081510.GA4459@ulmo> (raw)
In-Reply-To: <1504863782-3293-1-git-send-email-lukma@denx.de>


[-- Attachment #1.1: Type: text/plain, Size: 1997 bytes --]

On Fri, Sep 08, 2017 at 11:43:02AM +0200, Lukasz Majewski wrote:
> This commit adds support for Mitsubishi aa070mc01 TFT panel working
> with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)

This is missing a device tree binding.

> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3d2cb8b..0c64ec6 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1141,6 +1141,38 @@ static const struct panel_desc innolux_g121x1_l03 = {
>  	},
>  };
>  
> +static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
> +	.clock = 30400,
> +	.hdisplay = 800,
> +	.hsync_start = 800 + 0,
> +	.hsync_end = 800 + 1,
> +	.htotal = 800 + 0 + 1 + 160,
> +	.vdisplay = 480,
> +	.vsync_start = 480 + 0,
> +	.vsync_end = 480 + 48 + 1,
> +	.vtotal = 480 + 48 + 1 + 0,
> +	.vrefresh = 60,
> +	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc mitsubishi_aa070mc01 = {
> +	.modes = &mitsubishi_aa070mc01_mode,
> +	.num_modes = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 152,
> +		.height = 91,
> +	},
> +
> +	.delay = {
> +		.enable = 200,
> +		.unprepare = 200,
> +		.disable = 400,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
> +};

And this isn't sorted properly.

> +
>  static const struct drm_display_mode innolux_n116bge_mode = {
>  	.clock = 76420,
>  	.hdisplay = 1366,
> @@ -2029,6 +2061,9 @@ static const struct of_device_id platform_of_match[] = {
>  		.compatible = "innolux,g121x1-l03",
>  		.data = &innolux_g121x1_l03,
>  	}, {
> +		.compatible = "mitsubishi,aa070mc01-ca1",
> +		.data = &mitsubishi_aa070mc01,
> +	}, {

Same here.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] panel: display: Add support for Mitsubishi aa070mc01 TFT panel
Date: Thu, 19 Oct 2017 10:15:10 +0200	[thread overview]
Message-ID: <20171019081510.GA4459@ulmo> (raw)
In-Reply-To: <1504863782-3293-1-git-send-email-lukma@denx.de>

[-- Attachment #1: Type: text/plain, Size: 1997 bytes --]

On Fri, Sep 08, 2017 at 11:43:02AM +0200, Lukasz Majewski wrote:
> This commit adds support for Mitsubishi aa070mc01 TFT panel working
> with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)

This is missing a device tree binding.

> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3d2cb8b..0c64ec6 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1141,6 +1141,38 @@ static const struct panel_desc innolux_g121x1_l03 = {
>  	},
>  };
>  
> +static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
> +	.clock = 30400,
> +	.hdisplay = 800,
> +	.hsync_start = 800 + 0,
> +	.hsync_end = 800 + 1,
> +	.htotal = 800 + 0 + 1 + 160,
> +	.vdisplay = 480,
> +	.vsync_start = 480 + 0,
> +	.vsync_end = 480 + 48 + 1,
> +	.vtotal = 480 + 48 + 1 + 0,
> +	.vrefresh = 60,
> +	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc mitsubishi_aa070mc01 = {
> +	.modes = &mitsubishi_aa070mc01_mode,
> +	.num_modes = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 152,
> +		.height = 91,
> +	},
> +
> +	.delay = {
> +		.enable = 200,
> +		.unprepare = 200,
> +		.disable = 400,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
> +};

And this isn't sorted properly.

> +
>  static const struct drm_display_mode innolux_n116bge_mode = {
>  	.clock = 76420,
>  	.hdisplay = 1366,
> @@ -2029,6 +2061,9 @@ static const struct of_device_id platform_of_match[] = {
>  		.compatible = "innolux,g121x1-l03",
>  		.data = &innolux_g121x1_l03,
>  	}, {
> +		.compatible = "mitsubishi,aa070mc01-ca1",
> +		.data = &mitsubishi_aa070mc01,
> +	}, {

Same here.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2017-10-19  8:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-08  9:43 [PATCH] panel: display: Add support for Mitsubishi aa070mc01 TFT panel Lukasz Majewski
2017-09-24 21:18 ` Łukasz Majewski
2017-10-19  8:15 ` Thierry Reding [this message]
2017-10-19  8:15   ` Thierry Reding
2017-10-19 19:25   ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171019081510.GA4459@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukma@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.