From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 4.14-rc] nvme-rdma: Fix error status return in tagset allocation failure
Date: Thu, 19 Oct 2017 10:49:26 +0200 [thread overview]
Message-ID: <20171019084926.GA14227@lst.de> (raw)
In-Reply-To: <1508396289-12237-1-git-send-email-sagi@grimberg.me>
> if (new) {
> ctrl->ctrl.admin_tagset = nvme_rdma_alloc_tagset(&ctrl->ctrl, true);
> - if (IS_ERR(ctrl->ctrl.admin_tagset))
> + if (IS_ERR(ctrl->ctrl.admin_tagset)) {
> + error = PTR_ERR(ctrl->ctrl.admin_tagset);
> goto out_free_queue;
> + }
Can we return an error code instead and just pass in the tag set
to be allocated instead of the admin flag?A E.g.:
error = nvme_rdma_alloc_tagset(&ctrl->ctrl, &ctrl->ctrl.admin_tagset);
if (error)
goto out_free_queue;
next prev parent reply other threads:[~2017-10-19 8:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 6:58 [PATCH 4.14-rc] nvme-rdma: Fix error status return in tagset allocation failure Sagi Grimberg
2017-10-19 8:49 ` Christoph Hellwig [this message]
2017-10-19 9:41 ` Sagi Grimberg
2017-10-19 10:20 ` Christoph Hellwig
2017-10-19 10:28 ` Sagi Grimberg
2017-10-19 13:55 ` Christoph Hellwig
2017-10-19 14:44 ` Sagi Grimberg
2017-10-19 14:49 ` Christoph Hellwig
2017-10-19 14:58 ` Sagi Grimberg
2017-10-19 15:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019084926.GA14227@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.