All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 4.14-rc] nvme-rdma: Fix error status return in tagset allocation failure
Date: Thu, 19 Oct 2017 15:55:22 +0200	[thread overview]
Message-ID: <20171019135522.GF21452@lst.de> (raw)
In-Reply-To: <9cb7f448-f4a3-e3e6-e906-749a56daa943@grimberg.me>

On Thu, Oct 19, 2017@01:28:42PM +0300, Sagi Grimberg wrote:
>>> We could, but that would mean that the nvme_ctrl tagset pointer will
>>> need to be updated later (or from the routine itself).
>>
>> That why I want to pass the address of the tagset pointers, so that
>> it can be updated.
>
> But I'm targeting this code to nvme-core which at this point, only has
> a pointer to the tagsets (which are embedded in the transport ctrl
> structs).

But with a a double indirection you _can_ update the pointers.

  reply	other threads:[~2017-10-19 13:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19  6:58 [PATCH 4.14-rc] nvme-rdma: Fix error status return in tagset allocation failure Sagi Grimberg
2017-10-19  8:49 ` Christoph Hellwig
2017-10-19  9:41   ` Sagi Grimberg
2017-10-19 10:20     ` Christoph Hellwig
2017-10-19 10:28       ` Sagi Grimberg
2017-10-19 13:55         ` Christoph Hellwig [this message]
2017-10-19 14:44           ` Sagi Grimberg
2017-10-19 14:49             ` Christoph Hellwig
2017-10-19 14:58               ` Sagi Grimberg
2017-10-19 15:04                 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171019135522.GF21452@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.