From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] perf kmem: Perform some cleanup if '--time' is given an invalid value
Date: Thu, 19 Oct 2017 12:37:30 +0000 [thread overview]
Message-ID: <20171019123730.GJ3707@kernel.org> (raw)
In-Reply-To: <20170916060936.28199-1-christophe.jaillet@wanadoo.fr>
Em Sat, Sep 16, 2017 at 08:09:36AM +0200, Christophe JAILLET escreveu:
> If the string passed in '--time' is invalid, we must do some cleanup
> before leaving. As in the other error handling paths of this function.
Thanks, applied.
- Arnaldo
> Fixes: 2a865bd8dddd ("perf kmem: Add option to specify time window of interest")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> tools/perf/builtin-kmem.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
> index 24ee68ecdd42..d8f25ef8157b 100644
> --- a/tools/perf/builtin-kmem.c
> +++ b/tools/perf/builtin-kmem.c
> @@ -1983,7 +1983,8 @@ int cmd_kmem(int argc, const char **argv)
>
> if (perf_time__parse_str(&ptime, time_str) != 0) {
> pr_err("Invalid time string\n");
> - return -EINVAL;
> + ret = -EINVAL;
> + goto out_delete;
> }
>
> if (!strcmp(argv[0], "stat")) {
> --
> 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] perf kmem: Perform some cleanup if '--time' is given an invalid value
Date: Thu, 19 Oct 2017 09:37:30 -0300 [thread overview]
Message-ID: <20171019123730.GJ3707@kernel.org> (raw)
In-Reply-To: <20170916060936.28199-1-christophe.jaillet@wanadoo.fr>
Em Sat, Sep 16, 2017 at 08:09:36AM +0200, Christophe JAILLET escreveu:
> If the string passed in '--time' is invalid, we must do some cleanup
> before leaving. As in the other error handling paths of this function.
Thanks, applied.
- Arnaldo
> Fixes: 2a865bd8dddd ("perf kmem: Add option to specify time window of interest")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> tools/perf/builtin-kmem.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
> index 24ee68ecdd42..d8f25ef8157b 100644
> --- a/tools/perf/builtin-kmem.c
> +++ b/tools/perf/builtin-kmem.c
> @@ -1983,7 +1983,8 @@ int cmd_kmem(int argc, const char **argv)
>
> if (perf_time__parse_str(&ptime, time_str) != 0) {
> pr_err("Invalid time string\n");
> - return -EINVAL;
> + ret = -EINVAL;
> + goto out_delete;
> }
>
> if (!strcmp(argv[0], "stat")) {
> --
> 2.11.0
next prev parent reply other threads:[~2017-10-19 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-16 6:09 [PATCH] perf kmem: Perform some cleanup if '--time' is given an invalid value Christophe JAILLET
2017-09-16 6:09 ` Christophe JAILLET
2017-10-19 12:37 ` Arnaldo Carvalho de Melo [this message]
2017-10-19 12:37 ` Arnaldo Carvalho de Melo
2017-10-24 10:16 ` [tip:perf/core] " tip-bot for Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019123730.GJ3707@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.