From: Balbir Singh <bsingharora@gmail.com>
To: jglisse@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Joerg Roedel <jroedel@suse.de>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
David Woodhouse <dwmw2@infradead.org>,
Alistair Popple <alistair@popple.id.au>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 0/2] Optimize mmu_notifier->invalidate_range callback
Date: Thu, 19 Oct 2017 13:43:19 +1100 [thread overview]
Message-ID: <20171019134319.1b856091@MiWiFi-R3-srv> (raw)
In-Reply-To: <20171017031003.7481-1-jglisse@redhat.com>
On Mon, 16 Oct 2017 23:10:01 -0400
jglisse@redhat.com wrote:
> From: Jérôme Glisse <jglisse@redhat.com>
>
> (Andrew you already have v1 in your queue of patch 1, patch 2 is new,
> i think you can drop it patch 1 v1 for v2, v2 is bit more conservative
> and i fixed typos)
>
> All this only affect user of invalidate_range callback (at this time
> CAPI arch/powerpc/platforms/powernv/npu-dma.c, IOMMU ATS/PASID in
> drivers/iommu/amd_iommu_v2.c|intel-svm.c)
>
> This patchset remove useless double call to mmu_notifier->invalidate_range
> callback wherever it is safe to do so. The first patch just remove useless
> call
As in an extra call? Where does that come from?
> and add documentation explaining why it is safe to do so. The second
> patch go further by introducing mmu_notifier_invalidate_range_only_end()
> which skip callback to invalidate_range this can be done when clearing a
> pte, pmd or pud with notification which call invalidate_range right after
> clearing under the page table lock.
>
Balbir Singh.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <bsingharora@gmail.com>
To: jglisse@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Joerg Roedel <jroedel@suse.de>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
David Woodhouse <dwmw2@infradead.org>,
Alistair Popple <alistair@popple.id.au>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 0/2] Optimize mmu_notifier->invalidate_range callback
Date: Thu, 19 Oct 2017 13:43:19 +1100 [thread overview]
Message-ID: <20171019134319.1b856091@MiWiFi-R3-srv> (raw)
In-Reply-To: <20171017031003.7481-1-jglisse@redhat.com>
On Mon, 16 Oct 2017 23:10:01 -0400
jglisse@redhat.com wrote:
> From: J=C3=A9r=C3=B4me Glisse <jglisse@redhat.com>
>=20
> (Andrew you already have v1 in your queue of patch 1, patch 2 is new,
> i think you can drop it patch 1 v1 for v2, v2 is bit more conservative
> and i fixed typos)
>=20
> All this only affect user of invalidate_range callback (at this time
> CAPI arch/powerpc/platforms/powernv/npu-dma.c, IOMMU ATS/PASID in
> drivers/iommu/amd_iommu_v2.c|intel-svm.c)
>=20
> This patchset remove useless double call to mmu_notifier->invalidate_range
> callback wherever it is safe to do so. The first patch just remove useless
> call
As in an extra call? Where does that come from?
> and add documentation explaining why it is safe to do so. The second
> patch go further by introducing mmu_notifier_invalidate_range_only_end()
> which skip callback to invalidate_range this can be done when clearing a
> pte, pmd or pud with notification which call invalidate_range right after
> clearing under the page table lock.
>
Balbir Singh.
WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <bsingharora@gmail.com>
To: jglisse@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Joerg Roedel <jroedel@suse.de>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
David Woodhouse <dwmw2@infradead.org>,
Alistair Popple <alistair@popple.id.au>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 0/2] Optimize mmu_notifier->invalidate_range callback
Date: Thu, 19 Oct 2017 13:43:19 +1100 [thread overview]
Message-ID: <20171019134319.1b856091@MiWiFi-R3-srv> (raw)
In-Reply-To: <20171017031003.7481-1-jglisse@redhat.com>
On Mon, 16 Oct 2017 23:10:01 -0400
jglisse@redhat.com wrote:
> From: Jérôme Glisse <jglisse@redhat.com>
>
> (Andrew you already have v1 in your queue of patch 1, patch 2 is new,
> i think you can drop it patch 1 v1 for v2, v2 is bit more conservative
> and i fixed typos)
>
> All this only affect user of invalidate_range callback (at this time
> CAPI arch/powerpc/platforms/powernv/npu-dma.c, IOMMU ATS/PASID in
> drivers/iommu/amd_iommu_v2.c|intel-svm.c)
>
> This patchset remove useless double call to mmu_notifier->invalidate_range
> callback wherever it is safe to do so. The first patch just remove useless
> call
As in an extra call? Where does that come from?
> and add documentation explaining why it is safe to do so. The second
> patch go further by introducing mmu_notifier_invalidate_range_only_end()
> which skip callback to invalidate_range this can be done when clearing a
> pte, pmd or pud with notification which call invalidate_range right after
> clearing under the page table lock.
>
Balbir Singh.
next prev parent reply other threads:[~2017-10-19 2:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 3:10 [PATCH 0/2] Optimize mmu_notifier->invalidate_range callback jglisse
2017-10-17 3:10 ` jglisse
2017-10-17 3:10 ` jglisse
[not found] ` <20171017031003.7481-1-jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-17 3:10 ` [PATCH 1/2] mm/mmu_notifier: avoid double notification when it is useless v2 jglisse-H+wXaHxf7aLQT0dZR+AlfA
2017-10-17 3:10 ` jglisse
2017-10-17 3:10 ` jglisse
2017-10-19 3:04 ` Balbir Singh
2017-10-19 3:04 ` Balbir Singh
2017-10-19 3:04 ` Balbir Singh
2017-10-19 3:28 ` Jerome Glisse
2017-10-19 3:28 ` Jerome Glisse
2017-10-19 3:28 ` Jerome Glisse
2017-10-19 10:53 ` Balbir Singh
2017-10-19 10:53 ` Balbir Singh
2017-10-19 10:53 ` Balbir Singh
2017-10-19 16:58 ` Jerome Glisse
2017-10-19 16:58 ` Jerome Glisse
2017-10-19 16:58 ` Jerome Glisse
[not found] ` <20171019165823.GA3044-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-21 5:54 ` Balbir Singh
2017-10-21 5:54 ` Balbir Singh
2017-10-21 5:54 ` Balbir Singh
2017-10-21 15:47 ` Jerome Glisse
2017-10-21 15:47 ` Jerome Glisse
2017-10-21 15:47 ` Jerome Glisse
2017-10-23 20:35 ` Jerome Glisse
2017-10-23 20:35 ` Jerome Glisse
2017-10-23 20:35 ` Jerome Glisse
2017-10-17 3:10 ` [PATCH 2/2] mm/mmu_notifier: avoid call to invalidate_range() in range_end() jglisse
2017-10-17 3:10 ` jglisse
2017-10-17 3:10 ` jglisse
2017-10-19 2:43 ` Balbir Singh [this message]
2017-10-19 2:43 ` [PATCH 0/2] Optimize mmu_notifier->invalidate_range callback Balbir Singh
2017-10-19 2:43 ` Balbir Singh
2017-10-19 3:08 ` Jerome Glisse
2017-10-19 3:08 ` Jerome Glisse
2017-10-19 3:08 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019134319.1b856091@MiWiFi-R3-srv \
--to=bsingharora@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alistair@popple.id.au \
--cc=andrew.donnellan@au1.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jglisse@redhat.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=sfr@canb.auug.org.au \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.